From 07d66aa6dcd4ce9473be7ee250aff2ae6867d456 Mon Sep 17 00:00:00 2001 From: alaningtrump Date: Sun, 5 Jul 2026 06:58:18 +0800 Subject: [PATCH] refactor: use the built-in max/min to simplify the code (#5751) Signed-off-by: alaningtrump --- internal/web/service/client_groups.go | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/internal/web/service/client_groups.go b/internal/web/service/client_groups.go index 72c78a845..fa3f2c159 100644 --- a/internal/web/service/client_groups.go +++ b/internal/web/service/client_groups.go @@ -55,14 +55,8 @@ func (s *ClientService) ListGroups() ([]GroupSummary, error) { } out := make([]GroupSummary, 0, len(merged)) for name, agg := range merged { - up := agg.up - baseUp[name] - if up < 0 { - up = 0 - } - down := agg.down - baseDown[name] - if down < 0 { - down = 0 - } + up := max(agg.up-baseUp[name], 0) + down := max(agg.down-baseDown[name], 0) out = append(out, GroupSummary{Name: name, ClientCount: agg.count, TrafficUsed: up + down, Up: up, Down: down}) } sort.Slice(out, func(i, j int) bool {