From ff322f901ac19e1a9698c818221ade289c8bbd6f Mon Sep 17 00:00:00 2001 From: MHSanaei Date: Sun, 27 Sep 2026 15:32:22 +0200 Subject: [PATCH] fix(panel): skip the proxy env forwarding test on Windows Windows env var names are case-insensitive, so https_proxy and HTTPS_PROXY resolve to the same variable there and updateProxyEnvVars forwards it under both names. The helper only runs on Linux - startUpdate refuses every other platform - so the test's case-sensitive expectations only hold, and only matter, on Linux. --- internal/web/service/panel/panel_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/web/service/panel/panel_test.go b/internal/web/service/panel/panel_test.go index e51717452..d6e5d79e7 100644 --- a/internal/web/service/panel/panel_test.go +++ b/internal/web/service/panel/panel_test.go @@ -54,6 +54,9 @@ func TestShellQuote(t *testing.T) { // TestUpdateProxyEnvVars covers the bug this function fixes: ambient proxy // vars must reach update.sh's systemd-run child, which inherits nothing. func TestUpdateProxyEnvVars(t *testing.T) { + if runtime.GOOS == "windows" { + t.Skip("Windows env var names are case-insensitive, so both spellings resolve; the updater runs only on Linux") + } allKeys := []string{"https_proxy", "HTTPS_PROXY", "all_proxy", "ALL_PROXY", "http_proxy", "HTTP_PROXY", "no_proxy", "NO_PROXY"} clearAll := func(t *testing.T) { t.Helper()