From d78f4ecd2d4ec44f7e347e55b9c7bd49571754de Mon Sep 17 00:00:00 2001
From: Martin Ambrus <martin@martinambrus.com>
Date: Thu, 2 Nov 2017 00:58:36 +0100
Subject: [PATCH] fix: undefined indexes

---
 Templates/Build/15_1.tpl      |  2 +-
 Templates/Build/avaliable.tpl |  2 +-
 build.php                     | 16 ++++++++--------
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/Templates/Build/15_1.tpl b/Templates/Build/15_1.tpl
index 7bc0d793..aaa84b8f 100644
--- a/Templates/Build/15_1.tpl
+++ b/Templates/Build/15_1.tpl
@@ -1,6 +1,6 @@
 <?php
 $ty=(isset($_GET['ty']))? $_GET['ty']:"";
-if($_REQUEST["cancel"] == "1") {
+if(isset($_REQUEST["cancel"]) && $_REQUEST["cancel"] == "1") {
 if($session->access != BANNED){
     $database->delDemolition($village->wid);
     header("Location: build.php?gid=15&ty=$ty&cancel=0&demolish=0");
diff --git a/Templates/Build/avaliable.tpl b/Templates/Build/avaliable.tpl
index 2354989f..db80e2ad 100644
--- a/Templates/Build/avaliable.tpl
+++ b/Templates/Build/avaliable.tpl
@@ -269,7 +269,7 @@ if($armoury == 0 && ($mainbuilding <= 2 || $academy == 0)) {
 if($cropland <= 4) {
    include("soon/grainmill.tpl");
 }
-if($marketplace == 0 && ($mainbuilding <= 2 || $granary <= 0 || $warehouse <= 0)) {
+if(isset($marketplace) && $marketplace == 0 && ($mainbuilding <= 2 || $granary <= 0 || $warehouse <= 0)) {
    include("soon/marketplace.tpl");
 }
 if($residence == 0 && $mainbuilding <= 4) {
diff --git a/build.php b/build.php
index c1b35be2..2df46d1b 100644
--- a/build.php
+++ b/build.php
@@ -22,7 +22,7 @@ if(isset($_GET['newdid'])) {
 	header("Location: ".$_SERVER['PHP_SELF'].(isset($_GET['id'])?'?id='.$_GET['id']:(isset($_GET['gid'])?'?gid='.$_GET['gid']:'')));
 	exit;
 }
-if($_GET['id'] == 99 && $village->natar == 0){
+if(isset($_GET['id']) && $_GET['id'] == 99 && $village->natar == 0){
 header("Location: dorf2.php");
 exit;
 }
@@ -185,33 +185,33 @@ if($session->goldclub == 1 && count($session->villages) > 1){
 if($session->goldclub == 1){
 		if(isset($_GET['t'])==99) {
 
-			if($_GET['action'] == 'addList') {
+		    if(isset($_GET['action']) && $_GET['action'] == 'addList') {
 				$create = 1;
-			}else if($_GET['action'] == 'addraid') {
+		    }else if(isset($_GET['action']) && $_GET['action'] == 'addraid') {
 				$create = 2;
-			}else if($_GET['action'] == 'showSlot' && $_GET['eid']) {
+		    }else if(isset($_GET['action']) && $_GET['action'] == 'showSlot' && $_GET['eid']) {
 				$create = 3;
 			}else{
 				$create = 0;
 			}
 
-			if($_GET['slid']) {
+			if(isset($_GET['slid']) && $_GET['slid']) {
 			$FLData = $database->getFLData($_GET['slid']);
 			if($FLData['owner'] == $session->uid){
 			$checked[$_GET['slid']] = 1;
 			}
 			}
 
-			if($_GET['action'] == 'deleteList') {
+			if(isset($_GET['action']) && $_GET['action'] == 'deleteList') {
 				$database->delFarmList($_GET['lid'], $session->uid);
 				header("Location: build.php?id=39&t=99");
 				exit;
-			}elseif($_GET['action'] == 'deleteSlot') {
+			}elseif(isset($_GET['action']) && $_GET['action'] == 'deleteSlot') {
 				$database->delSlotFarm($_GET['eid']);
 				   header("Location: build.php?id=39&t=99");
 				   exit;
 			}
-			if($_POST['action'] == 'startRaid'){
+			if(isset($_POST['action']) && $_POST['action'] == 'startRaid'){
 			if($session->access != BANNED){
 			include ("Templates/a2b/startRaid.tpl");
 			}else{