xinyin025/TravianZ
1
0
Fork 0
mirror of https://github.com/Shadowss/TravianZ.git synced 2026-09-18 08:07:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor(Technology): make getTrainingList() table-driven [#219] (#287)

Browse Source
This commit is contained in:
Ferywir
2026-06-25 14:45:05 +02:00
committed by GitHub
parent 8f204ec4ae
commit 082ad85697
1 changed files with 17 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
GameEngine/Technology.php
+17 -35
View File
@@ -121,42 +121,24 @@ class Technology {
$residence = [9, 10, 19, 20, 29, 30, 49, 50]; $residence = [9, 10, 19, 20, 29, 30, 49, 50];
$trapper = [99]; $trapper = [99];
if(count($trainingarray) > 0) { $categories = [
1 => [$barracks, 0, null],
2 => [$stables, 0, null],
3 => [$workshop, 0, null],
4 => [$residence, 0, null],
5 => [$greatbarracks, 60, null],
6 => [$greatstables, 60, null],
7 => [$greatworkshop, 60, null],
8 => [$trapper, 0, 'Trap'],
];
if(count($trainingarray) > 0 && isset($categories[$type])) {
[$units, $offset, $fallback] = $categories[$type];
foreach($trainingarray as $train) { foreach($trainingarray as $train) {
if($type == 1 && in_array($train['unit'],$barracks)) { if(in_array($train['unit'], $units)) {
$train['name'] = $this->unarray[$train['unit']]; $train['unit'] -= $offset;
array_push($listarray,$train); $train['name'] = $fallback === null ? $this->unarray[$train['unit']] : ($this->unarray[$train['unit']] ?? $fallback);
} array_push($listarray, $train);
if($type == 2 && in_array($train['unit'],$stables)) {
$train['name'] = $this->unarray[$train['unit']];
array_push($listarray,$train);
}
if($type == 3 && in_array($train['unit'],$workshop)) {
$train['name'] = $this->unarray[$train['unit']];
array_push($listarray,$train);
}
if($type == 4 && in_array($train['unit'],$residence)) {
$train['name'] = $this->unarray[$train['unit']];
array_push($listarray,$train);
}
if($type == 5 && in_array($train['unit'],$greatbarracks)) {
$train['name'] = $this->unarray[$train['unit']-60];
$train['unit'] -= 60;
array_push($listarray,$train);
}
if($type == 6 && in_array($train['unit'],$greatstables)) {
$train['name'] = $this->unarray[$train['unit']-60];
$train['unit'] -= 60;
array_push($listarray,$train);
}
if($type == 7 && in_array($train['unit'],$greatworkshop)) {
$train['name'] = $this->unarray[$train['unit']-60];
$train['unit'] -= 60;
array_push($listarray,$train);
}
if($type == 8 && in_array($train['unit'],$trapper)) {
$train['name'] = $this->unarray[$train['unit']]?? 'Trap';
array_push($listarray,$train);
} }
} }
} }