Update some shit code

Update some shit code
This commit is contained in:
Catalin Novgorodschi
2026-04-30 14:24:31 +03:00
parent 1ea6873826
commit 544496c515
3 changed files with 1169 additions and 733 deletions
+281 -183
View File
@@ -61,213 +61,311 @@ class Account {
} }
private function Signup() { private function Signup() {
global $database,$form,$mailer,$generator,$session; global $database, $form, $mailer, $generator, $session;
// ==================== VERIFICARE WINNER ==================== // ==================== VERIFICARE WINNER ====================
$sql = mysqli_query($database->dblink, "SELECT 1 FROM " . TB_PREFIX . "fdata WHERE f99 = '100' AND f99t = '40' LIMIT 1"); $winnerResult = $database->query("SELECT 1 FROM " . TB_PREFIX . "fdata WHERE f99 = '100' AND f99t = '40' LIMIT 1");
$winner = mysqli_fetch_row($sql); if ($winnerResult && mysqli_num_rows($winnerResult) > 0) {
if ($winner) {
$form->addError("winner", WINNER_ERROR); $form->addError("winner", WINNER_ERROR);
} }
if(!isset($_POST['name']) || trim($_POST['name']) == "") {
$form->addError("name",USRNM_EMPTY);
}
else {
if(strlen($_POST['name']) < USRNM_MIN_LENGTH) {
$form->addError("name",USRNM_SHORT);
}
else if(!USRNM_SPECIAL && preg_match('/[^0-9A-Za-z]/',$_POST['name'])) {
$form->addError("name",USRNM_CHAR);
}
else if(USRNM_SPECIAL && preg_match("/[:,\\. \\n\\r\\t\\s\\<\\>]+/", $_POST['name'])) {
$form->addError("name",USRNM_CHAR);
}
else if(strtolower($_POST['name']) == 'natars') {
$form->addError("name",USRNM_TAKEN);
}
else if(User::exists($database,$_POST['name'])) {
$form->addError("name",USRNM_TAKEN);
}
}
if(!isset($_POST['pw']) || trim($_POST['pw']) == "") {
$form->addError("pw",PW_EMPTY);
}
else {
if(strlen($_POST['pw']) < PW_MIN_LENGTH) {
$form->addError("pw",PW_SHORT);
}
else if($_POST['pw'] == $_POST['name']) {
$form->addError("pw",PW_INSECURE);
} // ==================== VALIDĂRI ====================
}
if(!isset($_POST['email'])) {
$form->addError("email",EMAIL_EMPTY);
}
else {
if(!$this->validEmail($_POST['email'])) {
$form->addError("email",EMAIL_INVALID);
}
else if(User::exists($database,$_POST['email'])) {
$form->addError("email",EMAIL_TAKEN);
}
}
if(!isset($_POST['vid']) || !in_array($_POST['vid'], [1, 2, 3])) {
$form->addError("tribe",TRIBE_EMPTY);
}
if(!isset($_POST['agb'])) {
$form->addError("agree",AGREE_ERROR);
}
if($form->returnErrors() > 0) {
$form->addError("invt",$_POST['invited']);
$_SESSION['errorarray'] = $form->getErrors();
$_SESSION['valuearray'] = $_POST;
// Username
if (!isset($_POST['name']) || trim($_POST['name']) === '') {
$form->addError("name", USRNM_EMPTY);
} else {
if (strlen($_POST['name']) < USRNM_MIN_LENGTH) {
$form->addError("name", USRNM_SHORT);
} elseif (!USRNM_SPECIAL && preg_match('/[^0-9A-Za-z]/', $_POST['name'])) {
$form->addError("name", USRNM_CHAR);
} elseif (USRNM_SPECIAL && preg_match("/[:,\\. \\n\\r\\t\\s\\<\\>]+/", $_POST['name'])) {
$form->addError("name", USRNM_CHAR);
} elseif (strtolower($_POST['name']) === 'natars') {
$form->addError("name", USRNM_TAKEN);
} elseif (User::exists($database, $_POST['name'])) {
$form->addError("name", USRNM_TAKEN);
}
}
header("Location: anmelden.php"); // Password
if (!isset($_POST['pw']) || trim($_POST['pw']) === '') {
$form->addError("pw", PW_EMPTY);
} else {
if (strlen($_POST['pw']) < PW_MIN_LENGTH) {
$form->addError("pw", PW_SHORT);
} elseif ($_POST['pw'] === $_POST['name']) {
$form->addError("pw", PW_INSECURE);
}
}
// Email
if (!isset($_POST['email']) || trim($_POST['email']) === '') {
$form->addError("email", EMAIL_EMPTY);
} elseif (!$this->validEmail($_POST['email'])) {
$form->addError("email", EMAIL_INVALID);
} elseif (User::exists($database, $_POST['email'])) {
$form->addError("email", EMAIL_TAKEN);
}
// Tribe
if (!isset($_POST['vid']) || !in_array((int)$_POST['vid'], [1, 2, 3], true)) {
$form->addError("tribe", TRIBE_EMPTY);
}
// Agreement
if (!isset($_POST['agb'])) {
$form->addError("agree", AGREE_ERROR);
}
// ==================== VERIFICARE ERORI ====================
if ($form->returnErrors() > 0) {
$form->addError("invt", $_POST['invited'] ?? '');
$_SESSION['errorarray'] = $form->getErrors();
$_SESSION['valuearray'] = $_POST;
header("Location: anmelden.php");
exit;
}
// ==================== PROCESARE ÎNREGISTRARE ====================
$hashedPassword = password_hash($_POST['pw'], PASSWORD_BCRYPT, ['cost' => 12]);
if (AUTH_EMAIL) {
$act = $generator->generateRandStr(10);
$act2 = $generator->generateRandStr(5);
$uid = $database->activate(
$_POST['name'],
$hashedPassword,
$_POST['email'],
$_POST['vid'],
$_POST['kid'],
$act,
$act2
);
if ($uid) {
$mailer->sendActivate($_POST['email'], $_POST['name'], $_POST['pw'], $act);
header("Location: activate.php?id=$uid&q=$act2");
exit; exit;
} }
else { } else {
if(AUTH_EMAIL){ // Ramura fără activare prin email (act era undefined în codul original)
$act = $generator->generateRandStr(10); $act = '';
$act2 = $generator->generateRandStr(5);
$uid = $database->activate($_POST['name'],password_hash($_POST['pw'], PASSWORD_BCRYPT,['cost' => 12]),$_POST['email'],$_POST['vid'],$_POST['kid'],$act,$act2);
if($uid) {
$mailer->sendActivate($_POST['email'],$_POST['name'],$_POST['pw'],$act); $uid = $database->register(
header("Location: activate.php?id=$uid&q=$act2"); $_POST['name'],
exit; $hashedPassword,
} $_POST['email'],
} $_POST['vid'],
else { $act
$uid = $database->register($_POST['name'], password_hash($_POST['pw'], PASSWORD_BCRYPT, ['cost' => 12]), $_POST['email'], $_POST['vid'], $act); );
if($uid) {
setcookie("COOKUSR" , $_POST['name'], time() + COOKIE_EXPIRE,COOKIE_PATH); if ($uid) {
setcookie("COOKEMAIL" , $_POST['email'], time() + COOKIE_EXPIRE,COOKIE_PATH); setcookie("COOKUSR", $_POST['name'], time() + COOKIE_EXPIRE, COOKIE_PATH);
$database->updateUserField( setcookie("COOKEMAIL", $_POST['email'], time() + COOKIE_EXPIRE, COOKIE_PATH);
$uid,
["act", "invited"], $database->updateUserField(
["", $_POST['invited']], $uid,
1 ["act", "invited"],
); ["", $_POST['invited'] ?? ''],
$this->generateBase($_POST['kid'], $uid, $_POST['name']); 1
header("Location: login.php"); );
exit;
} $this->generateBase($_POST['kid'], $uid, $_POST['name']);
}
} header("Location: login.php");
} exit;
}
}
}
private function Activate() { private function Activate() {
global $database; global $database;
if(START_DATE < date('d.m.Y') or START_DATE == date('d.m.Y') && START_TIME <= date('H:i'))
{ // ==================== VERIFICARE DATA DE START A SERVERULUI ====================
$q = "SELECT act, username, password, email, tribe, location FROM ".TB_PREFIX."activate where act = '".$database->escape($_POST['id'])."'"; if (START_DATE < date('d.m.Y') || (START_DATE === date('d.m.Y') && START_TIME <= date('H:i'))) {
$result = mysqli_query($database->dblink,$q);
$dbarray = mysqli_fetch_array($result); // Caută codul de activare în tabela activate
if($dbarray['act'] == $_POST['id']) { $id = $database->escape($_POST['id'] ?? '');
$uid = $database->register($dbarray['username'], $dbarray['password'], $dbarray['email'], $dbarray['tribe'], ""); $q = "SELECT act, username, password, email, tribe, location
if($uid) { FROM " . TB_PREFIX . "activate
$database->unreg($dbarray['username']); WHERE act = '" . $id . "'";
$this->generateBase($dbarray['location'],$uid,$dbarray['username']);
header("Location: activate.php?e=2"); $result = $database->query($q);
exit; $dbarray = mysqli_fetch_array($result);
}
} // Verificăm dacă am găsit exact codul trimis
else if ($dbarray && $dbarray['act'] === $_POST['id']) {
{
header("Location: activate.php?e=3"); $uid = $database->register(
exit; $dbarray['username'],
} $dbarray['password'],
} $dbarray['email'],
else $dbarray['tribe'],
{ ""
header("Location: activate.php"); );
exit;
} if ($uid) {
} $database->unreg($dbarray['username']);
$this->generateBase($dbarray['location'], $uid, $dbarray['username']);
header("Location: activate.php?e=2");
exit;
}
// dacă register eșuează → comportamentul original (fără redirect)
} else {
// Cod de activare invalid sau inexistent
header("Location: activate.php?e=3");
exit;
}
} else {
// Serverul nu a început încă
header("Location: activate.php");
exit;
}
}
private function Unreg() { private function Unreg() {
global $database; global $database;
$q = "SELECT password, username FROM ".TB_PREFIX."activate where id = ".(int) $_POST['id'];
$result = mysqli_query($database->dblink,$q); // ==================== VERIFICARE ID & PAROLĂ ====================
$dbarray = mysqli_fetch_array($result); $id = (int)($_POST['id'] ?? 0);
if(password_verify($_POST['pw'], $dbarray['password'])) {
$database->unreg($dbarray['username']); $q = "SELECT password, username
header("Location: anmelden.php"); FROM " . TB_PREFIX . "activate
exit; WHERE id = " . $id;
}
else { $result = $database->query($q);
header("Location: activate.php?e=3"); $dbarray = mysqli_fetch_array($result);
exit;
} // Verificăm dacă înregistrarea există și parola este corectă
} // (protejează împotriva notice-urilor PHP dacă nu există rândul)
if ($dbarray && password_verify($_POST['pw'] ?? '', $dbarray['password'])) {
$database->unreg($dbarray['username']);
header("Location: anmelden.php");
exit;
}
// Parolă greșită sau ID inexistent → comportamentul original
header("Location: activate.php?e=3");
exit;
}
private function Login() { private function Login() {
global $database, $session, $form; global $database, $session, $form;
$user = $_POST['user'];
if(!isset($_POST['user']) || empty($_POST['user'])){ // ==================== INITIALIZARE SIGURĂ ====================
$form->addError("user", $user); $username = $_POST['user'] ?? '';
}else if(!User::exists($database, $_POST['user'])){ $password = $_POST['pw'] ?? '';
$form->addError("user", USR_NT_FOUND);
} // $userData este folosit înainte de a fi definit în codul original
if(!isset($_POST['pw']) || empty($_POST['pw'])){ // Păstrăm comportamentul exact (null aici)
$form->addError("pw", LOGIN_PASS_EMPTY); $userData = null;
}else if(!$database->login($_POST['user'], $_POST['pw']) && !$database->sitterLogin($_POST['user'], $_POST['pw'])){
// try activation data if the user was not found // ==================== VALIDĂRI ====================
if(!$userData){
$activateData = $database->getActivateField($_POST['user'], 'act', 1); // Username
if(!empty($activateData)) $form->addError("activate", $_POST['user']); if (empty($username)) {
else $form->addError("pw", LOGIN_PW_ERROR); $form->addError("user", $username);
} } elseif (!User::exists($database, $username)) {
else $form->addError("pw", LOGIN_PW_ERROR); $form->addError("user", USR_NT_FOUND);
} }
$userData = $database->getUserArray($_POST['user'], 0);
// Vacation mode by Shadow // Password
if($userData["vac_mode"] == 1 && $userData["vac_time"] > time()){ if (empty($password)) {
$form->addError("vacation", "Vacation mode is still enabled"); $form->addError("pw", LOGIN_PASS_EMPTY);
} } elseif (!$database->login($username, $password) && !$database->sitterLogin($username, $password)) {
// Vacation mode by Shadow // try activation data if the user was not found
if($form->returnErrors() > 0){ // (păstrăm exact logica originală - $userData e încă null aici)
$_SESSION['errorarray'] = $form->getErrors(); if (!$userData) {
$_SESSION['valuearray'] = $_POST; $activateData = $database->getActivateField($username, 'act', 1);
header("Location: login.php"); if (!empty($activateData)) {
exit(); $form->addError("activate", $username);
}else{ } else {
// Vacation mode by Shadow $form->addError("pw", LOGIN_PW_ERROR);
$database->removevacationmode($userData['id']); }
// Vacation mode by Shadow } else {
if($database->login($_POST['user'], $_POST['pw'])){ $form->addError("pw", LOGIN_PW_ERROR);
$database->UpdateOnline("login", $_POST['user'], time(), $userData['id']); }
}else if($database->sitterLogin($_POST['user'], $_POST['pw'])){ }
$database->UpdateOnline("sitter", $_POST['user'], time(), $userData['id']);
} // Obținem datele utilizatorului (după validări - exact ca în original)
setcookie("COOKUSR", $_POST['user'], time() + COOKIE_EXPIRE, COOKIE_PATH); $userData = $database->getUserArray($username, 0);
$session->login($_POST['user']);
} // Vacation mode by Shadow
} if (!empty($userData) && $userData['vac_mode'] == 1 && $userData['vac_time'] > time()) {
$form->addError("vacation", LOGIN_VACATION);
}
// ==================== VERIFICARE ERORI ====================
if ($form->returnErrors() > 0) {
$_SESSION['errorarray'] = $form->getErrors();
$_SESSION['valuearray'] = $_POST;
header("Location: login.php");
exit();
}
// ==================== LOGIN CU SUCCES ====================
// Vacation mode by Shadow
$database->removevacationmode($userData['id']);
if ($database->login($username, $password)) {
$database->UpdateOnline("login", $username, time(), $userData['id']);
} elseif ($database->sitterLogin($username, $password)) {
$database->UpdateOnline("sitter", $username, time(), $userData['id']);
}
setcookie("COOKUSR", $username, time() + COOKIE_EXPIRE, COOKIE_PATH);
$session->login($username);
}
private function Logout() { private function Logout() {
global $session, $database; global $session, $database;
unset($_SESSION['wid']); unset($_SESSION['wid']);
$database->activeModify(addslashes($session->username),1); // actualizează statusul "activ" al utilizatorului
$database->UpdateOnline("logout") or die(mysqli_error($database->dblink)); $database->activeModify($database->escape($session->username), 1);
$session->Logout(); // actualizează ultima activitate online
} $database->UpdateOnline("logout");
$session->Logout();
}
private function validEmail($email) { private function validEmail($email) {
$regexp="/^[a-z0-9]+([_\\.-][a-z0-9]+)*@([a-z0-9]+([\.-][a-z0-9]+)*)+\\.[a-z]{2,}$/i"; // Regex exact ca în varianta originală (nu am schimbat logica de validare)
return preg_match($regexp, $email); $regexp = "/^[a-z0-9]+([_\\.-][a-z0-9]+)*@([a-z0-9]+([\.-][a-z0-9]+)*)+\\.[a-z]{2,}$/i";
} return (bool) preg_match($regexp, $email);
}
function generateBase($kid, $uid, $username) { function generateBase($kid, $uid, $username) {
global $database; global $database;
$message = new Message(); $message = new Message();
if($kid == 0) $kid = rand(1,4); // Logica exactă din original
else $kid = $_POST['kid']; if ($kid == 0) {
$database->generateVillages([['wid' => 0, 'mode' => 0, 'type' => 3, 'kid' => $kid, 'capital' => 1, 'pop' => 2, 'name' => null, 'natar' => 0]], $uid, $username); $kid = rand(1, 4);
$message->sendWelcome($uid, $username); } else {
} $kid = $_POST['kid']; // suprascrie parametrul cu valoarea din POST
}
$database->generateVillages(
[
[
'wid' => 0,
'mode' => 0,
'type' => 3,
'kid' => $kid,
'capital'=> 1,
'pop' => 2,
'name' => null,
'natar' => 0
]
],
$uid,
$username
);
$message->sendWelcome($uid, $username);
}
}; };
$account = new Account; $account = new Account;
?> ?>
+887 -550
View File
File diff suppressed because it is too large Load Diff
+1
View File
@@ -62,6 +62,7 @@ define('TRIBE_EMPTY', '<li>Please choose a tribe.</li>');
define('AGREE_ERROR', '<li>You have to agree to the game rules and the general terms & conditions in order to register.</li>'); define('AGREE_ERROR', '<li>You have to agree to the game rules and the general terms & conditions in order to register.</li>');
define('LOGIN_USR_EMPTY', 'Enter name.'); define('LOGIN_USR_EMPTY', 'Enter name.');
define('LOGIN_PASS_EMPTY', 'Enter password.'); define('LOGIN_PASS_EMPTY', 'Enter password.');
define('LOGIN_VACATION', 'Vacation mode is still enable.');
define('EMAIL_ERROR', 'Email does not match existing'); define('EMAIL_ERROR', 'Email does not match existing');
define('PASS_MISMATCH', 'Passwords do not match'); define('PASS_MISMATCH', 'Passwords do not match');
define('ALLI_OWNER', 'Please appoint an alliance owner before deleting'); define('ALLI_OWNER', 'Please appoint an alliance owner before deleting');