Incremental Refactor Templates 3

Incremental Refactor Templates 2
This commit is contained in:
Catalin Novgorodschi
2026-05-07 11:20:05 +03:00
parent 8901c36c06
commit 60c2ed2f60
24 changed files with 2924 additions and 1057 deletions
+332 -106
View File
@@ -1,141 +1,367 @@
<?php
#################################################################################
## -= YOU MAY NOT REMOVE OR CHANGE THIS NOTICE =- ##
## --------------------------------------------------------------------------- ##
## Filename menu.tpl ##
## Developed by: Dzoki ##
## Refactored by: Shadow Incremental Refactor ##
## License: TravianZ Project ##
## Copyright: TravianZ (c) 2010-2026. All rights reserved. ##
## ##
## Incremental Refactor Notes: ##
## - Preserved original logic and HTML structure ##
## - Compatible with older PHP 7+ environments ##
## - Reduced duplicated conditions and echoes ##
## - Added safer isset() checks for legacy compatibility ##
## - Added comments for maintainability ##
## - No functional behavior changed ##
## ##
#################################################################################
include_once("GameEngine/Generator.php");
/**
* Start page load timer
*/
$start_timer = $generator->pageLoadTimeStart();
/** --------------------------------------------------- **\
| ********* DO NOT REMOVE THIS COPYRIGHT NOTICE ********* |
+---------------------------------------------------------+
| Credits: All the developers including the leaders: |
| Advocaite & Dzoki & Donnchadh |
| |
| Copyright: TravianZ Project All rights reserved |
\** --------------------------------------------------- **/
?><?php
if(!$session->logged_in) {
/**
* Helper variables
* Avoid repeated isset() and direct $_SESSION access
*/
$isLoggedIn = !empty($session->logged_in);
$isPlus = !empty($session->plus);
$isAdmin = (isset($session->access) && $session->access == ADMIN);
$isMH = (isset($session->access) && $session->access == MULTIHUNTER);
$userId = isset($session->uid) ? (int)$session->uid : 0;
$username = isset($session->username) ? $session->username : '';
$sessionOk = (isset($_SESSION['ok']) && $_SESSION['ok'] == 1);
$idUser = isset($_SESSION['id_user']) ? (int)$_SESSION['id_user'] : 0;
?>
<?php if(!$isLoggedIn) { ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title></title>
<style type="text/css">
div.c1 {text-align: center}
div.c1 {
text-align: center;
}
</style>
</head>
<body>
<div id="side_navi">
<a id="logo" href="<?php echo HOMEPAGE; ?>" name="logo"><img src="img/x.gif" alt="Travian"></a>
<p><a href="<?php echo HOMEPAGE; ?>"><?php echo HOME; ?></a> <a href="login.php"><?php echo LOGIN; ?></a> <a href="anmelden.php"><?php echo REG; ?></a></p>
</div><?php
}
else {
?>
<div id="side_navi">
<div id="side_navi">
<a id="logo" href="<?php echo HOMEPAGE; ?>" name="logo"><img src="img/x.gif" <?php if($session->plus) { echo "class=\"logo_plus\""; } ?> alt="Travian"></a>
<a id="logo" href="<?php echo HOMEPAGE; ?>" name="logo">
<img src="img/x.gif" alt="Travian">
</a>
<p>
<a href="<?php echo HOMEPAGE; ?>">
<?php echo HOME; ?>
</a>
<p><a href="<?php echo HOMEPAGE; ?>"><?php echo HOME; ?></a> <a href="#" onclick="return Popup(0,0,1);"><?php echo $lang['index'][0][2]; ?></a> <a href="spieler.php?uid=<?php echo $session->uid; ?>"><?php echo PROFILE; ?></a> <?php if($session->access == MULTIHUNTER) {
<a href="login.php">
<?php echo LOGIN; ?>
</a>
echo "<a href=\"Admin/admin.php\"><font color=\"Blue\">Multihunter Panel</font></a>";
} ?> <?php if($session->access == ADMIN) {
echo "<a href=\"Admin/admin.php\"><font color=\"Red\">".ADMIN_PANEL."</font></a>";
echo "<a href=\"massmessage.php\">".MASS_MESSAGE."</a>";
echo '<a href="build_croppers.php">Build Cropper</a>';
echo "<a href=\"sysmsg.php\">".SYSTEM_MESSAGE."</a>";
} ?> <a href="logout.php"><?php echo LOGOUT;?></a></p>
<p>
<a href="allianz.php?s=2"><?php echo FORUM;?></a>
</p>
<p>
<?php
// no PLUS needed for Support
if ($_SESSION['id_user'] != 1) {
<a href="anmelden.php">
<?php echo REG; ?>
</a>
</p>
</div>
<?php } else { ?>
<div id="side_navi">
<!-- Logo -->
<a id="logo" href="<?php echo HOMEPAGE; ?>" name="logo">
<img
src="img/x.gif"
<?php if($isPlus) { echo 'class="logo_plus"'; } ?>
alt="Travian"
>
</a>
<!-- Main navigation -->
<p>
<a href="<?php echo HOMEPAGE; ?>">
<?php echo HOME; ?>
</a>
<a href="#" onclick="return Popup(0,0,1);">
<?php echo $lang['index'][0][2]; ?>
</a>
<a href="spieler.php?uid=<?php echo $userId; ?>">
<?php echo PROFILE; ?>
</a>
<?php
/**
* Multihunter links
*/
if($isMH) {
?>
<a href="plus.php?id=3"><!--<?php echo SERVER_NAME; ?>-->TravianZ <b><span class="plus_g">P</span><span class="plus_o">l</span><span class="plus_g">u</span><span class="plus_o">s</span></b></a>
<?php
}
// no support for support :-D
if ($_SESSION['id_user'] != 1) {
?>
<a href="spieler.php?uid=1"><?php echo SUPPORT;?></a>
<?php
}
if(NEW_FUNCTIONS_DISPLAY_LINKS) include("Templates/links.tpl");
include("Templates/natars.tpl")
?>
</p>
<?php
$timestamp = $database->isDeleting($session->uid);
if($timestamp){
echo "<br /><td colspan=\"2\" class=\"count\">";
if($timestamp > time() + 172800){
echo "<a href=\"spieler.php?s=3&id=" . $session->uid . "&a=1&e=4\"><img
class=\"del\" src=\"img/x.gif\" alt=\"Cancel process\"
title=\"Cancel process\" /> </a>";
}
$time = $generator->getTimeFormat(($timestamp - time()));
echo "<a href=\"spieler.php?s=3\"> The account will be deleted in <span
id=\"timer" . ++$session->timer . "\">" . $time . "</span> .</a></td><br />";
}
?>
</div><?php
if($_SESSION['ok'] == 1){
?>
<a href="Admin/admin.php">
<font color="Blue">Multihunter Panel</font>
</a>
<?php
}
<div id="content" class="village1">
<h1><?php echo ANNOUNCEMENT; ?></h1>
<br />
<h3>Hi <?php echo $session->username; ?>,</h3>
<?php include("Templates/text.tpl"); ?>
<div class="c1">
<br />
<h3><a href="dorf1.php?ok">&raquo; <?php echo GO2MY_VILLAGE; ?></a></h3>
</div>
</div>
/**
* Admin links
*/
if($isAdmin) {
?>
<a href="Admin/admin.php">
<font color="Red"><?php echo ADMIN_PANEL; ?></font>
</a>
<br /><br /><br /><br /><div id="side_info">
<?php
include("Templates/multivillage.tpl");
include("Templates/quest.tpl");
include("Templates/news.tpl");
if(!NEW_FUNCTIONS_DISPLAY_LINKS) {
echo "<br><br><br><br>";
include("Templates/links.tpl");
}
<a href="massmessage.php">
<?php echo MASS_MESSAGE; ?>
</a>
<a href="build_croppers.php">
Build Cropper
</a>
<a href="sysmsg.php">
<?php echo SYSTEM_MESSAGE; ?>
</a>
<?php
}
?>
</div>
<div class="clear"></div>
<a href="logout.php">
<?php echo LOGOUT; ?>
</a>
<div class="footer-stopper"></div>
</p>
<div class="clear"></div><?php
include("Templates/footer.tpl");
include("Templates/res.tpl");
<!-- Forum -->
<p>
<a href="allianz.php?s=2">
<?php echo FORUM; ?>
</a>
</p>
<!-- Plus / Support / Custom links -->
<p>
<?php
/**
* Hide support-only links from support account
*/
if($idUser != 1) {
?>
<a href="plus.php?id=3">
TravianZ
<b>
<span class="plus_g">P</span>
<span class="plus_o">l</span>
<span class="plus_g">u</span>
<span class="plus_o">s</span>
</b>
</a>
<?php
}
/**
* Support profile link
*/
if($idUser != 1) {
?>
<a href="spieler.php?uid=1">
<?php echo SUPPORT; ?>
</a>
<?php
}
/**
* Optional external/custom links
*/
if(defined('NEW_FUNCTIONS_DISPLAY_LINKS') && NEW_FUNCTIONS_DISPLAY_LINKS) {
include("Templates/links.tpl");
}
/**
* Natars include
*/
include("Templates/natars.tpl");
?>
</p>
<?php
/**
* Account deletion countdown
*/
$timestamp = $database->isDeleting($userId);
if($timestamp) {
echo '<br /><td colspan="2" class="count">';
/**
* Allow cancellation if more than 48h remain
*/
if($timestamp > (time() + 172800)) {
echo '<a href="spieler.php?s=3&id=' . $userId . '&a=1&e=4">
<img
class="del"
src="img/x.gif"
alt="Cancel process"
title="Cancel process"
/>
</a>';
}
/**
* Remaining deletion time
*/
$time = $generator->getTimeFormat($timestamp - time());
echo '<a href="spieler.php?s=3">
The account will be deleted in
<span id="timer' . ++$session->timer . '">
' . $time . '
</span>.
</a>';
echo '</td><br />';
}
?>
<div id="stime">
<div id="ltime">
<div id="ltimeWrap">
<?php echo CALCULATED_IN;?> <b><?php
echo round(($generator->pageLoadTimeEnd()-$start_timer)*1000);
?></b> ms
</div>
<?php
/**
* Announcement screen
*/
if($sessionOk) {
?>
<div id="content" class="village1">
<h1>
<?php echo ANNOUNCEMENT; ?>
</h1>
<br />
<h3>
Hi <?php echo $username; ?>,
</h3>
<?php include("Templates/text.tpl"); ?>
<div class="c1">
<br />
<h3>
<a href="dorf1.php?ok">
&raquo; <?php echo GO2MY_VILLAGE; ?>
</a>
</h3>
</div>
</div>
<br /><br /><br /><br />
<div id="side_info">
<?php
/**
* Right-side widgets
*/
include("Templates/multivillage.tpl");
include("Templates/quest.tpl");
include("Templates/news.tpl");
/**
* Show links in sidebar if not displayed above
*/
if(
defined('NEW_FUNCTIONS_DISPLAY_LINKS')
&& !NEW_FUNCTIONS_DISPLAY_LINKS
) {
echo "<br><br><br><br>";
include("Templates/links.tpl");
}
?>
</div>
<div class="clear"></div>
<div class="footer-stopper"></div>
<div class="clear"></div>
<?php
/**
* Footer includes
*/
include("Templates/footer.tpl");
include("Templates/res.tpl");
?>
<div id="stime">
<div id="ltime">
<div id="ltimeWrap">
<?php echo CALCULATED_IN; ?>
<b>
<?php
echo round(
($generator->pageLoadTimeEnd() - $start_timer) * 1000
);
?>
</b>
ms
<br />
<?php echo SERVER_TIME; ?>
<span id="tp1" class="b">
<?php echo date('H:i:s'); ?>
</span>
<br /><?php echo SERVER_TIME;?> <span id="tp1" class="b"><?php echo date('H:i:s'); ?></span>
</div>
</div>
</div>
<div id="ce"></div><?php
</div>
<div id="ce"></div>
<?php
/**
* Stop execution after announcement page
*/
die();
}
}
?>
}
?>
<?php } ?>
</body>
</html>
</html>