xinyin025/TravianZ
1
0
Fork 0
mirror of https://github.com/Shadowss/TravianZ.git synced 2026-07-15 09:06:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Incremental Refactor Templates 3

Browse Source 
Incremental Refactor Templates 2
This commit is contained in:
Catalin Novgorodschi
2026-05-07 11:20:05 +03:00
parent 8901c36c06
commit 60c2ed2f60
24 changed files with 2924 additions and 1057 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Templates/quest.tpl
+86 -21
View File
@@ -1,37 +1,102 @@
<?php
<?php
#################################################################################
## -= YOU MAY NOT REMOVE OR CHANGE THIS NOTICE =- ##
## --------------------------------------------------------------------------- ##
## Filename quest.tpl ##
## Developed by: Dzoki ##
## Rework by: ronix ##
## Refactored by: Shadow Incremental Refactor ##
## License: TravianZ Project ##
## Copyright: TravianZ (c) 2010-2013. All rights reserved. ##
## Copyright: TravianZ (c) 2010-2026. All rights reserved. ##
## ##
## Incremental Refactor Notes: ##
## - Preserved original quest logic ##
## - Improved readability and indentation ##
## - Added safety checks for session values ##
## - Reduced repeated session access ##
## - Compatible with PHP 7+ ##
## ##
#################################################################################
/**
* ---------------------------------------------------------
* Initialize quest type in session
* ---------------------------------------------------------
*/
$_SESSION['qtyp'] = QTYPE;
if ($_SESSION['id_user'] != 1 && (($_SESSION['qst'] < 38 && QTYPE == 37 && QUEST == true) || ($_SESSION['qst'] < 31 && QTYPE == 25 && QUEST == true) || ($_SESSION['qst'] >= 90 && QUEST == true))) {?>
/**
* ---------------------------------------------------------
* Basic session safety
* ---------------------------------------------------------
*/
$userId = isset($_SESSION['id_user']) ? (int)$_SESSION['id_user'] : 0;
$qst = isset($_SESSION['qst']) ? (int)$_SESSION['qst'] : 0;
$qstNew = isset($_SESSION['qstnew']) ? (int)$_SESSION['qstnew'] : 0;
$tribe = isset($session->userinfo['tribe']) ? $session->userinfo['tribe'] : 0;
/**
* ---------------------------------------------------------
* Quest display conditions (preserved logic)
* ---------------------------------------------------------
*/
$showQuest =
$userId != 1 &&
(
($qst < 38 && QTYPE == 37 && QUEST == true) ||
($qst < 31 && QTYPE == 25 && QUEST == true) ||
($qst >= 90 && QUEST == true)
);
if ($showQuest) {
?>
<div id="anm" style="width:120px; height:140px; visibility:hidden;"></div>
<div id="qge">
<?php if ($_SESSION['qst'] == 0 or (isset($_SESSION['qstnew']) && $_SESSION['qstnew']==1)){ ?>
<img onclick="qst_handle();" src="<?php echo GP_LOCATE; ?>img/q/l<?php echo $session->userinfo['tribe'];?>g.jpg" title="To the task" style="height:174px" alt="To the task" />
<?php }else{?>
<img onclick="qst_handle();" src="<?php echo GP_LOCATE; ?>img/q/l<?php echo $session->userinfo['tribe'];?>.jpg" title="To the task" style="height:174px" alt="To the task" />
<?php if ($qst == 0 || $qstNew == 1) { ?>
<img
onclick="qst_handle();"
src="<?php echo GP_LOCATE; ?>img/q/l<?php echo $tribe; ?>g.jpg"
title="To the task"
style="height:174px"
alt="To the task"
/>
<?php } else { ?>
<img
onclick="qst_handle();"
src="<?php echo GP_LOCATE; ?>img/q/l<?php echo $tribe; ?>.jpg"
title="To the task"
style="height:174px"
alt="To the task"
/>
<?php } ?>
</div>
<script type="text/javascript">
<?php if ($_SESSION['qst']==0){ ?>
quest.number=null;
<?php }else{ ?>
quest.number=0;
<?php } if ($_SESSION['qst']<38 && QTYPE==37){?>
quest.last = 37;
<?php } else {?>
quest.last = 30;
<?php }?>
cache_preload = new Image();
cache_preload.src = "img/x.gif";
cache_preload.className = "wood";
</script>
<?php if ($qst == 0) { ?>
quest.number = null;
<?php } else { ?>
quest.number = 0;
<?php } ?>
<?php if ($qst < 38 && QTYPE == 37) { ?>
quest.last = 37;
<?php } else { ?>
quest.last = 30;
<?php } ?>
cache_preload = new Image();
cache_preload.src = "img/x.gif";
cache_preload.className = "wood";
</script>
<?php
}
?>