xinyin025/TravianZ
1
0
Fork 0
mirror of https://github.com/Shadowss/TravianZ.git synced 2026-07-09 14:16:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: wrong user ID being selected via getNotice2() & getNotice3()

Browse Source 
#313
This commit is contained in:
Martin Ambrus
2017-11-17 23:15:12 +01:00
parent ffeeac3173
commit 8f979deba9
2 changed files with 61 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
GameEngine/Database.php
+6 -19
View File
@@ -1576,30 +1576,17 @@ class MYSQLi_DB implements IDbConnection {
}
function getVillageID($uid, $use_cache = true) {
list($uid) = $this->escape_input((int) $uid);
// first of all, check if we should be using cache and whether the field
// required is already cached
if ($use_cache && ($cachedValue = self::returnCachedContent(self::$villageIDsCache, $uid)) && !is_null($cachedValue)) {
return $cachedValue[0];
}
$q = "SELECT wref FROM " . TB_PREFIX . "vdata WHERE owner = $uid";
$result = mysqli_query($this->dblink,$q);
$dbarray = mysqli_fetch_array($result);
self::$villageIDsCache[$uid] = [$dbarray]['wref'];
return self::$villageIDsCache[$uid][0];
// load cached value
return $this->getVillagesID($uid, $use_cache)[0];
}
function getVillagesID($uid, $use_cache = true) {
list($uid) = $this->escape_input((int) $uid);
// first of all, check if we should be using cache and whether the field
// required is already cached
if ($use_cache && ($cachedValue = self::returnCachedContent(self::$villageIDsCache, $uid)) && !is_null($cachedValue)) {
return $cachedValue[0]['wref'];
return $cachedValue;
}
$q = "SELECT wref from " . TB_PREFIX . "vdata where owner = $uid order by capital DESC,pop DESC";
@@ -3829,8 +3816,8 @@ class MYSQLi_DB implements IDbConnection {
$result = mysqli_query($this->dblink,$q);
$dbarray = mysqli_fetch_array($result);
self::$noticesCacheById[$id] = $dbarray[$field];
return self::$noticesCacheById[$id];
self::$noticesCacheById[$id] = $dbarray;
return self::$noticesCacheById[$id][$field];
}
function getNotice3($uid, $use_cache = true) {
@@ -3839,7 +3826,7 @@ class MYSQLi_DB implements IDbConnection {
// first of all, check if we should be using cache and whether the field
// required is already cached
if ($use_cache && ($cachedValue = self::returnCachedContent(self::$noticesCacheByUId, $uid)) && !is_null($cachedValue)) {
return $cachedValue[$field];
return $cachedValue;
}
$q = "SELECT * FROM " . TB_PREFIX . "ndata where uid = $uid ORDER BY time DESC";