fix: Upgrade Error Handling in common/gin.go: Wrap and contextualize errors.

- Updated error handling in `common/gin.go` to provide better context for debugging
- Wrapped errors with additional information to improve error messages
- Modified `UnmarshalBodyReusable` function to return errors with extra context and reset request body after processing
This commit is contained in:
Laisky.Cai 2024-03-19 03:41:16 +00:00
parent a50c0e9385
commit 2bcd21a3d5

View File

@ -7,6 +7,7 @@ import (
"strings" "strings"
"github.com/gin-gonic/gin" "github.com/gin-gonic/gin"
"github.com/pkg/errors"
) )
const KeyRequestBody = "key_request_body" const KeyRequestBody = "key_request_body"
@ -18,7 +19,7 @@ func GetRequestBody(c *gin.Context) ([]byte, error) {
} }
requestBody, err := io.ReadAll(c.Request.Body) requestBody, err := io.ReadAll(c.Request.Body)
if err != nil { if err != nil {
return nil, err return nil, errors.Wrap(err, "read request body failed")
} }
_ = c.Request.Body.Close() _ = c.Request.Body.Close()
c.Set(KeyRequestBody, requestBody) c.Set(KeyRequestBody, requestBody)
@ -28,18 +29,18 @@ func GetRequestBody(c *gin.Context) ([]byte, error) {
func UnmarshalBodyReusable(c *gin.Context, v any) error { func UnmarshalBodyReusable(c *gin.Context, v any) error {
requestBody, err := GetRequestBody(c) requestBody, err := GetRequestBody(c)
if err != nil { if err != nil {
return err return errors.Wrap(err, "get request body failed")
} }
contentType := c.Request.Header.Get("Content-Type") contentType := c.Request.Header.Get("Content-Type")
if strings.HasPrefix(contentType, "application/json") { if strings.HasPrefix(contentType, "application/json") {
err = json.Unmarshal(requestBody, &v) if err = json.Unmarshal(requestBody, &v); err != nil {
return errors.Wrap(err, "unmarshal request body failed")
}
} else { } else {
// skip for now // skip for now
// TODO: someday non json request have variant model, we will need to implementation this // TODO: someday non json request have variant model, we will need to implementation this
} }
if err != nil {
return err
}
// Reset request body // Reset request body
c.Request.Body = io.NopCloser(bytes.NewBuffer(requestBody)) c.Request.Body = io.NopCloser(bytes.NewBuffer(requestBody))
return nil return nil