xinyin025/3x-ui
1
0
Fork 0
mirror of https://github.com/MHSanaei/3x-ui.git synced 2026-07-16 01:26:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(settings): detect a wildcard listen collision between the web and sub ports

Browse Source 
The web/sub same-port check compared the two listen addresses as raw strings, so
binding both on all interfaces with different spellings (webListen 0.0.0.0 vs an
empty subListen) slipped past validation and only failed at startup with an
opaque bind error. Treat any wildcard listen ('', 0.0.0.0, ::) as overlapping so
the clash is reported up front, while still allowing two distinct specific
addresses to share a port.
This commit is contained in:
MHSanaei
2026-07-15 03:48:05 +02:00
parent f2f11bc042
commit 06cd75abe0
2 changed files with 36 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/web/entity/check_valid_test.go
+14
View File
@@ -27,3 +27,17 @@ func TestCheckValidSmtpFrom(t *testing.T) {
}
}
}
func TestCheckValidWildcardListenPortConflict(t *testing.T) {
// Same port, both bind all interfaces but spelled differently -> conflict.
s := &AllSetting{WebPort: 2053, SubPort: 2053, WebListen: "0.0.0.0", SubListen: ""}
if err := s.CheckValid(); err == nil {
t.Error("CheckValid must reject the same port bound on 0.0.0.0 and \"\" (both wildcard)")
}
// Same port on two distinct specific addresses can coexist and must be allowed.
ok := &AllSetting{WebPort: 2053, SubPort: 2053, WebListen: "127.0.0.1", SubListen: "192.168.1.1"}
if err := ok.CheckValid(); err != nil {
t.Errorf("distinct specific listens on the same port should be allowed: %v", err)
}
}