refactor(ci): add an adversarial pass and name the analyst briefing

REVIEW.md told the reviewer which repository rules to check but never to try
breaking the change, so the conditions this panel actually meets went
unexamined. "Try to break it" adds six, each tied to a mechanism here rather
than to a generic checklist: an upgrade over an operator's existing rows and
the rollback that reads them again, a restart that drops in-memory state under
the cron jobs, a sub-node racing the master on the same row, an operation
applied twice, an inbound or client at the empty and the thousand end, and a
dependency that is down. It closes with the gate that running a case is not
reporting it - each one still has to clear the verification bar below it, so
the section cannot become a licence for hypotheticals.

repo-context.md said nothing about which bot reads it. Only the issue analyst
does, since the review job's briefing moved inline in acf3603d, so it becomes
issue-analyst-context.md and its title names the analyst instead of "the Claude
bot". bot_context_test.go pins that path in a constant, so the rename carries
through the constant, the four test names and the two comments that named the
old file - one of which still said "the bot prompts", plural.

Backticks come off mtg-multi in the new section: the same test file reads any
hyphenated backticked token in REVIEW.md as a CI job name, and fails on one
ci.yml does not define.
This commit is contained in:
Sanaei
2026-09-08 21:29:21 +02:00
parent acf3603dc8
commit 20d7f91c65
4 changed files with 58 additions and 26 deletions
@@ -1,4 +1,4 @@
# Repository context for the Claude bot
# Repository context for the issue analyst
Briefing for the issue analyst in `.github/workflows/claude-issue-analyst.yml`.
It exists so these facts live in ONE place next to the code instead of being
+1 -1
View File
@@ -79,7 +79,7 @@ jobs:
needs, and no deeper.
REPOSITORY CONTEXT
Read `.github/claude/repo-context.md` in the checkout before you answer
Read `.github/claude/issue-analyst-context.md` in the checkout before you answer
anything. It carries the stack, the repository map, the hard rules, what CI
runs, and the support facts reporters most often get wrong - the random
generated credentials, the distro-dependent service environment file, the