xinyin025/3x-ui
1
0
Fork 0
mirror of https://github.com/MHSanaei/3x-ui.git synced 2026-09-05 01:47:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(qr): hide QR for post-quantum links on client QR page

Browse Source 
Opening the client sublinks/QR modal crashed when a link used
post-quantum keys (ML-DSA-65 / ML-KEM-768): the encoded URL exceeds
the antd QRCode capacity and the component throws. The client QR modal
rendered the QRCode unconditionally, so it took down the page.

The names don't appear verbatim in a share link — mldsa65Verify rides
inside pqv=<base64> and ML-KEM-768 inside encryption=mlkem768x25519plus.
The QR modal and inbound QR modal used a literal-substring guard that
missed those encoded forms, leaving the QR (and the crash) in place.

Consolidate detection into a single isPostQuantumLink() helper in
inbound-link.ts and reuse it across the client QR, inbound QR, client
info, and sub surfaces. The copy/download link still works; only the
QR image is suppressed for oversized post-quantum links.

Closes #4656
This commit is contained in:
MHSanaei
2026-05-29 17:04:30 +02:00
parent 90a64a1b22
commit 5d0081a3b9
5 changed files with 19 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/pages/clients/ClientInfoModal.tsx
+1 -14
View File
@@ -6,6 +6,7 @@ import { CopyOutlined, QrcodeOutlined } from '@ant-design/icons';
import { ClipboardManager, HttpUtil, IntlUtil, SizeFormatter } from '@/utils';
import { useDatepicker } from '@/hooks/useDatepicker';
import type { ClientRecord, InboundOption } from '@/hooks/useClients';
import { isPostQuantumLink } from '@/lib/xray/inbound-link';
import QrPanel from '@/pages/inbounds/QrPanel';
import './ClientInfoModal.css';
@@ -33,20 +34,6 @@ const INBOUND_PROTOCOL_COLORS: Record<string, string> = {
const INBOUND_CHIP_LIMIT = 1;
// Post-quantum keys blow up the encoded URL past what a single QR can
// hold. In VLESS share links the algorithm names don't appear as plain
// text — they ride inside query params:
// - mldsa65Verify becomes `pqv=<base64>` (sub/subService.go:841)
// - ML-KEM-768 becomes `encryption=mlkem768x25519plus.<...>`
// We also keep the literal substrings so configs that DO embed them
// directly (e.g. wireguard config text) still match.
function isPostQuantumLink(link: string): boolean {
if (/[?&]pqv=/.test(link)) return true;
if (link.includes('mlkem768') || link.includes('mldsa65')) return true;
if (link.includes('ML-KEM-768')) return true;
return false;
}
// 3x-ui's genRemark concatenates inbound remark + client email (and an
// optional extra) using a configurable separator. The email half is
// redundant in the row title — the modal already names the client by