xinyin025/3x-ui
1
0
Fork 0
mirror of https://github.com/MHSanaei/3x-ui.git synced 2026-07-20 19:46:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(reality): load dest as target alias so existing inbounds aren't wiped (#5295)

Browse Source 
xray-core accepts both `target` and `dest` for the REALITY destination
(infra/conf/transport_internet.go: REALITYConfig has json:"target" and
json:"dest"). The frontend schema only knows `target`, so an inbound whose
realitySettings use `dest` — older panel builds, external tools, or the
panel's own /panel/api/inbounds API — loads with an empty (required) Target
field even though xray is running fine. Re-saving then serializes the blank
`target` and drops the working `dest`, breaking REALITY on the next restart.

Normalize `dest` -> `target` on parse (z.preprocess) when `target` is
absent/empty, matching xray-core's alias behavior. Add unit tests covering
the schema directly and through the security discriminated union.

Co-authored-by: Volov <volovdata@google.com>
This commit is contained in:
Volov Vyacheslav
2026-06-15 01:25:10 +03:00
committed by GitHub
parent dab0add191
commit 66a9a788fc
2 changed files with 77 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/schemas/protocols/security/reality.ts
+41 -18
View File
@@ -14,28 +14,51 @@ export const RealityClientSettingsSchema = z.object({
});
export type RealityClientSettings = z.infer<typeof RealityClientSettingsSchema>;
// xray-core accepts both `target` and `dest` as the REALITY destination —
// they are aliases (infra/conf/transport_internet.go: REALITYConfig has
// `json:"target"` and `json:"dest"`). The panel writes `target`, but configs
// produced by older panel builds, external tools, or the panel's own
// `/panel/api/inbounds` API commonly use `dest`. Map `dest` -> `target` on
// parse when `target` is absent/empty: otherwise such an inbound loads with
// an empty (required) Target field even though it runs fine, and re-saving
// it serializes the blank `target` and drops the working `dest` — silently
// breaking REALITY on the next xray restart.
const aliasRealityDest = (value: unknown): unknown => {
if (value && typeof value === 'object' && !Array.isArray(value)) {
const obj = value as Record<string, unknown>;
const hasTarget = typeof obj.target === 'string' && obj.target !== '';
if (!hasTarget && typeof obj.dest === 'string' && obj.dest !== '') {
return { ...obj, target: obj.dest };
}
}
return value;
};
// Reality stream payload. `serverNames` and `shortIds` are stored as
// comma-joined strings in the panel class but ship as string[] on the wire
// — fixtures round-trip through the array form. `target` is the dest host
// Reality piggybacks on; the panel auto-generates random target+SNI when
// blank.
export const RealityStreamSettingsSchema = z.object({
show: z.boolean().default(false),
xver: z.number().int().min(0).default(0),
target: z.string().default(''),
serverNames: z.array(z.string()).default([]),
privateKey: z.string().default(''),
minClientVer: z.string().default(''),
maxClientVer: z.string().default(''),
maxTimediff: z.number().int().min(0).default(0),
shortIds: z.array(z.string()).default([]),
mldsa65Seed: z.string().default(''),
settings: RealityClientSettingsSchema.default({
publicKey: '',
fingerprint: 'chrome',
serverName: '',
spiderX: '/',
mldsa65Verify: '',
export const RealityStreamSettingsSchema = z.preprocess(
aliasRealityDest,
z.object({
show: z.boolean().default(false),
xver: z.number().int().min(0).default(0),
target: z.string().default(''),
serverNames: z.array(z.string()).default([]),
privateKey: z.string().default(''),
minClientVer: z.string().default(''),
maxClientVer: z.string().default(''),
maxTimediff: z.number().int().min(0).default(0),
shortIds: z.array(z.string()).default([]),
mldsa65Seed: z.string().default(''),
settings: RealityClientSettingsSchema.default({
publicKey: '',
fingerprint: 'chrome',
serverName: '',
spiderX: '/',
mldsa65Verify: '',
}),
}),
});
);
export type RealityStreamSettings = z.infer<typeof RealityStreamSettingsSchema>;