mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-08-29 22:47:14 +00:00
fix(sub): stop appending the node name to subscription remarks (#5231)
The #5035 change tagged node-hosted entries with the node name to disambiguate multi-node subscriptions, but the node name is panel-internal and leaked into the profile names end users see in their client apps. Drop the suffix entirely — remarks are the admin-set inbound remark again.
This commit is contained in:
@@ -26,6 +26,21 @@ func TestSubscriptionExpiryFromClient(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// The name an admin gives a node is panel-internal and must not leak into
|
||||
// the remarks end users see in their client apps (#5231) — not even for
|
||||
// node-hosted inbounds, which briefly carried a node-name suffix (#5035).
|
||||
func TestGenRemarkOmitsNodeName(t *testing.T) {
|
||||
nodeID := 7
|
||||
s := &SubService{
|
||||
remarkModel: "-ieo",
|
||||
nodesByID: map[int]*model.Node{7: {Id: 7, Name: "Berlin", Address: "node7.example.com"}},
|
||||
}
|
||||
ib := &model.Inbound{Remark: "vless-tcp", NodeID: &nodeID}
|
||||
if got := s.genRemark(ib, "", ""); got != "vless-tcp" {
|
||||
t.Fatalf("remark = %q, want %q (node name must not leak into client-visible remarks)", got, "vless-tcp")
|
||||
}
|
||||
}
|
||||
|
||||
func TestFindClientIndex(t *testing.T) {
|
||||
clients := []model.Client{
|
||||
{Email: "a@example.com"},
|
||||
|
||||
Reference in New Issue
Block a user