mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-08-30 15:07:14 +00:00
chore(frontend): update dependencies and adapt to oxlint 1.79
npm install was failing with ERESOLVE: the lockfile pinned storybook 10.5.7 and vitest 4.1.10 as peers while package.json asked for ^10.5.9 and ^4.1.11, and npm would not move either. Neither npm update, a targeted install, nor --package-lock-only broke the cycle, so node_modules and package-lock.json were regenerated from scratch (601 packages, 0 vulnerabilities). oxlint 1.79.0 then promoted five React Compiler rules into the correctness category, flagging 101 pre-existing sites. 1.78.0 exits 0 on the same tree, so nothing in our code changed - the rule set grew. They are fixed rather than suppressed: - refs (31): latest-value ref writes moved out of render into an effect. onlineClientsRef turned out to be write-only and is gone; expireDiffRef and trafficDiffRef were replaced by reading the values directly. - set-state-in-effect (55): reset-on-open modals now adjust state during render; where an effect mixed a synchronous reset with an async fetch, the reset moved to render and the effect kept only the request. useMediaQuery became useSyncExternalStore. - preserve-manual-memoization (11): optional-chained deps the compiler cannot match, hoisted to locals or dropped where the memo wrapped a string concat. - purity (3): Date.now() in render replaced by a state-backed clock, which also refreshes the expiry tag every 60s instead of freezing it until the next unrelated re-render. - immutability (1): applyClientStatsEvent merged websocket traffic into DBInbound rows in place; it now rebuilds only the rows it touches. Two things fell out of that. clientCount is derived with useMemo instead of an imperative rebuildClientCount() called from five sites, which also fixes a staleness bug where changing the expiry or traffic threshold left the counts alone until some later rebuild. statsVersion existed only to force a re-render after an in-place mutation, is meaningless now that rows are replaced, and nothing read it, so it is removed. Also adds a lint:fix script - oxlint --fix was previously only reachable through the lint-staged hook.
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
import { useEffect, useMemo, useState } from 'react';
|
||||
import { useMemo, useState } from 'react';
|
||||
import { useTranslation } from 'react-i18next';
|
||||
import { Alert, Input, Modal, Select, Space, Table, Tag, Typography, message } from 'antd';
|
||||
import type { ColumnsType } from 'antd/es/table';
|
||||
@@ -57,14 +57,20 @@ export default function AttachClientsModal({
|
||||
const [selectedEmails, setSelectedEmails] = useState<string[]>([]);
|
||||
const [search, setSearch] = useState('');
|
||||
|
||||
useEffect(() => {
|
||||
if (!open) return;
|
||||
const rows = source ? readClientRows(source.settings) : [];
|
||||
setClientRows(rows);
|
||||
setSelectedEmails(rows.map((r) => r.email));
|
||||
setTargetIds([]);
|
||||
setSearch('');
|
||||
}, [open, source]);
|
||||
// React resets this during render rather than in an effect so the modal's
|
||||
// first open frame already shows cleared fields.
|
||||
const openSource = open ? source : null;
|
||||
const [syncedSource, setSyncedSource] = useState(openSource);
|
||||
if (openSource !== syncedSource) {
|
||||
setSyncedSource(openSource);
|
||||
if (openSource) {
|
||||
const rows = readClientRows(openSource.settings);
|
||||
setClientRows(rows);
|
||||
setSelectedEmails(rows.map((r) => r.email));
|
||||
setTargetIds([]);
|
||||
setSearch('');
|
||||
}
|
||||
}
|
||||
|
||||
const targetOptions = useMemo(() => {
|
||||
if (!source) return [];
|
||||
|
||||
@@ -49,12 +49,21 @@ export default function AttachExistingClientsModal({
|
||||
const [search, setSearch] = useState('');
|
||||
const [groupFilter, setGroupFilter] = useState<string | undefined>(undefined);
|
||||
|
||||
// Reset during render, not in an effect, so the first frame is already clean.
|
||||
const openTarget = open ? target : null;
|
||||
const [syncedTarget, setSyncedTarget] = useState(openTarget);
|
||||
if (openTarget !== syncedTarget) {
|
||||
setSyncedTarget(openTarget);
|
||||
if (openTarget) {
|
||||
setLoading(true);
|
||||
setSearch('');
|
||||
setGroupFilter(undefined);
|
||||
}
|
||||
}
|
||||
|
||||
useEffect(() => {
|
||||
if (!open || !target) return;
|
||||
let cancelled = false;
|
||||
setLoading(true);
|
||||
setSearch('');
|
||||
setGroupFilter(undefined);
|
||||
HttpUtil.get('/panel/api/clients/list', undefined, { silent: true })
|
||||
.then((msg) => {
|
||||
if (cancelled) return;
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { useEffect, useMemo, useState } from 'react';
|
||||
import { useMemo, useState } from 'react';
|
||||
import { useTranslation } from 'react-i18next';
|
||||
import { Input, Modal, Space, Table, Tag, Typography, message } from 'antd';
|
||||
import type { ColumnsType } from 'antd/es/table';
|
||||
@@ -52,13 +52,17 @@ export default function DetachClientsModal({
|
||||
const [selectedEmails, setSelectedEmails] = useState<string[]>([]);
|
||||
const [search, setSearch] = useState('');
|
||||
|
||||
useEffect(() => {
|
||||
if (!open) return;
|
||||
const rows = source ? readClientRows(source.settings) : [];
|
||||
setClientRows(rows);
|
||||
setSelectedEmails([]);
|
||||
setSearch('');
|
||||
}, [open, source]);
|
||||
// Reset during render, not in an effect, so the first frame is already clean.
|
||||
const openSource = open ? source : null;
|
||||
const [syncedSource, setSyncedSource] = useState(openSource);
|
||||
if (openSource !== syncedSource) {
|
||||
setSyncedSource(openSource);
|
||||
if (openSource) {
|
||||
setClientRows(readClientRows(openSource.settings));
|
||||
setSelectedEmails([]);
|
||||
setSearch('');
|
||||
}
|
||||
}
|
||||
|
||||
const filteredRows = useMemo(() => {
|
||||
const q = search.trim().toLowerCase();
|
||||
|
||||
Reference in New Issue
Block a user