mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-08-21 10:27:14 +00:00
feat(xray): browse geosite/geoip categories from routing rules (#6165)
* feat(xray): browse geosite/geoip categories from routing rules Routing rules made you type category names from memory: nothing showed which categories a database actually contains, what is inside one, or whether a name resolves at all — a typo only surfaced when Xray refused the config. The panel now reads Xray's .dat databases itself and exposes them over four endpoints: databases in the asset folder, a database's categories, one page of a category's rules, and validation of the tokens already in a rule. The reader walks the protobuf wire format directly rather than decoding into Go structs, because a 10 MB geosite.dat holds well over a million domains and materialising them costs ~284 MB where streaming costs ~19 MB. Only the category index is cached, entry pages are scanned on demand, and scans are serialised, so twenty concurrent requests peak at 87 MB instead of 1 GB. A database's type is decided by its contents, not its file name, since custom .dat files are named freely. In the rule form, the source-IP, IP and domain fields gain a database button opening the browser: search over categories, a preview of what a category holds, and a multi-select that merges into the field. Plain domains, CIDRs and categories the panel does not know are left untouched; categories already present come back ticked, and unticking one removes it from the rule. * fix(xray): read geo databases through os.Root and match codes verbatim CodeQL flagged the database read as a path built from a user-supplied value, and it was right about the shape of it. The file name arrives in a request; resolve() rejects traversal and stats the file through an os.Root, but the read itself went through a joined path with os.ReadFile. That left the symlink defence incomplete: the stat could pass while the read followed a link planted — or swapped in — afterwards. Reads now go through the same root, so a request-supplied name never becomes a path this code resolves on its own, and the size limit is applied to the opened file rather than to a separate stat of it. Lookup no longer trims the category code either. It backs the routing-token validator, and the core matches codes verbatim: "geosite: cn" will not start Xray, so repairing that space here hid exactly the typo the validator exists to report. * fix(xray): address review findings on the geo category browser Asset folder. The browser read config.GetBinFolderPath() unconditionally, but the core honours a preset XRAY_LOCATION_ASSET and only falls back to the bin folder (ensureXrayAssetLocation). On an install pointing at a shared asset directory the panel listed an empty folder and reported perfectly valid geosite:/geoip: tokens as missing — the validator warning about a correct config. The directory is now resolved with the core's precedence. Paging. Serving one page read and rescanned the whole database, so walking category-ads-all re-read it per page. The index now records each category's byte range and a page reads only that record through the os.Root handle, with the current category's records held for the duration of a paging session. Profiling that also showed the real cost was not the read but the slice of payload pointers built per call — a category holds a hundred thousand of them — so records are now walked with a callback instead. Ten pages over category-ads-all: 239 MB allocated, now 4.3 MB. Cached failures. Any error from reading a file was latched under the file's size+mtime, so a transient ENOMEM or EMFILE marked a healthy database as damaged until it changed on disk. Only deterministic failures are cached. Wrong kind. A geoip: token typed into a domain field parsed as a plain domain and was waved through, though the core cannot resolve it as one. It is now reported, with its own reason and wording. Frontend. The category filter fed the query key on every keystroke, so each character triggered a request that re-scanned the database; it is debounced now. GeoTokenInput accepts and forwards a ref, so React Hook Form can focus these three fields on a validation error again. A failed validation shows that it failed instead of rendering the same empty state as "no issues". Also drops an unreachable branch in the token-count guard and corrects the categories endpoint docs, where limit is unbounded by default. --------- Co-authored-by: STRENCH0 <17428017+STRENCH0@users.noreply.github.com>
This commit is contained in:
@@ -1446,6 +1446,35 @@
|
||||
"routing": {
|
||||
"dragToReorder": "Kéo để sắp xếp lại"
|
||||
},
|
||||
"geoBrowser": {
|
||||
"title": "Danh mục geo",
|
||||
"openTooltip": "Duyệt danh mục geo",
|
||||
"database": "Cơ sở dữ liệu",
|
||||
"searchCategory": "Tìm danh mục",
|
||||
"searchEntries": "Lọc trong danh mục",
|
||||
"selectFound": "Chọn các kết quả",
|
||||
"selected": "Đã chọn {count}",
|
||||
"clearAll": "Xóa tất cả",
|
||||
"apply": "Áp dụng",
|
||||
"emptySelection": "Đánh dấu danh mục — chúng sẽ trở thành token của quy tắc",
|
||||
"pickCategory": "Chọn một danh mục ở bên trái để xem nội dung",
|
||||
"noMatches": "Không tìm thấy gì",
|
||||
"noFiles": "Không có cơ sở dữ liệu geo trong thư mục Xray",
|
||||
"noFilesHint": "Chúng sẽ xuất hiện sau khi Xray tải geosite.dat và geoip.dat",
|
||||
"fileMeta": "{count} danh mục · {size} · cập nhật {date}",
|
||||
"entriesCount": "{count} mục",
|
||||
"subnetsCount": "{count} dải mạng",
|
||||
"shownRange": "Hiển thị {from}–{to} trong {total}",
|
||||
"loadFailed": "Không thể tải cơ sở dữ liệu geo",
|
||||
"checkFailed": "Không thể kiểm tra các giá trị này với cơ sở dữ liệu geo",
|
||||
"parseFailed": "Tệp bị hỏng hoặc không phải cơ sở dữ liệu geosite/geoip",
|
||||
"tooLarge": "Tệp quá lớn để duyệt",
|
||||
"unknownCategories": "Không có trong cơ sở dữ liệu: {tokens}",
|
||||
"missingDatabase": "Không tìm thấy tệp cơ sở dữ liệu: {tokens} — hãy thêm trong mục Geodata",
|
||||
"unknownAttribute": "Không tìm thấy thuộc tính, quy tắc sẽ không khớp với bất kỳ thứ gì: {tokens}",
|
||||
"invalidToken": "Xray sẽ không chấp nhận mục này: {tokens}",
|
||||
"wrongKind": "Sai loại cơ sở dữ liệu cho trường này: {tokens}"
|
||||
},
|
||||
"ruleForm": {
|
||||
"sourceIps": "IP nguồn",
|
||||
"sourcePort": "Cổng nguồn",
|
||||
|
||||
Reference in New Issue
Block a user