mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-07-24 21:46:07 +00:00
2b1308ca29
Problem: a flaky outbound produces hundreds of false-positive "outbound down" notifications overnight — each fires the moment xray's observatory reports a single failed probe, and the next successful probe fires an "up". applyObservatory forwarded every raw alive:true->false transition straight to EventOutboundDown; xray's observatory has effectively no hysteresis, and nothing on the panel side debounced it (the email/Telegram subscribers are pure formatters). Fix: debounce per outbound. outbound.down now fires only after outboundDownThreshold consecutive FAILED probes (new setting, default 3); outbound.up fires immediately on the first successful probe and only when a down was actually notified. The threshold gates the event itself, so email and Telegram share one knob (exposed next to the outbound.down toggle). The streak counts genuinely new probes (last_try_time advancing), not sampler polls — the sampler runs every 2s but the observatory re-probes per its probeInterval, so counting samples would trip the threshold instantly. outboundDownThreshold=1 reproduces the legacy notify-on-first-failure behaviour. Tuning the observatory's probe interval/timeout is not a workaround: those probes also drive the load balancer's outbound selection, so loosening them to quiet notifications would slow real failover away from a genuinely dead outbound. Notifications don't need observatory-grade latency, so the tolerance belongs at the notification layer, leaving the observatory (and balancer) untouched. Adds TestApplyObservatoryDebounce covering the threshold, probe-vs-sample counting, single-blip suppression and the legacy path. Co-authored-by: Yuriy Khachaturian <y.khachaturian@souzmult.ru> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
302 lines
8.2 KiB
Go
302 lines
8.2 KiB
Go
package service
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"regexp"
|
|
"sort"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/mhsanaei/3x-ui/v3/internal/eventbus"
|
|
"github.com/mhsanaei/3x-ui/v3/internal/logger"
|
|
)
|
|
|
|
type xrayMetricsState struct {
|
|
Enabled bool `json:"enabled"`
|
|
Listen string `json:"listen"`
|
|
Reason string `json:"reason,omitempty"`
|
|
}
|
|
|
|
type ObsTagSnapshot struct {
|
|
Tag string `json:"tag"`
|
|
Alive bool `json:"alive"`
|
|
Delay int64 `json:"delay"`
|
|
LastSeenTime int64 `json:"lastSeenTime"`
|
|
LastTryTime int64 `json:"lastTryTime"`
|
|
UpdatedAt int64 `json:"updatedAt"`
|
|
}
|
|
|
|
// eventBus is the shared bus for publishing observatory state-change events.
|
|
// Set once during startup via SetEventBus; nil when no bus is configured.
|
|
var eventBus *eventbus.Bus
|
|
|
|
// SetEventBus assigns the global event bus used by applyObservatory to publish
|
|
// outbound health transitions. Must be called once during startup before any
|
|
// Sample tick runs.
|
|
func SetEventBus(b *eventbus.Bus) { eventBus = b }
|
|
|
|
type XrayMetricsService struct {
|
|
settingService SettingService
|
|
|
|
mu sync.RWMutex
|
|
state xrayMetricsState
|
|
client *http.Client
|
|
obsByTag map[string]ObsTagSnapshot
|
|
health map[string]outboundHealth
|
|
}
|
|
|
|
// outboundHealth debounces observatory flapping. Xray flips an outbound's
|
|
// alive flag on a single failed probe, so raw transitions produce a storm of
|
|
// down/up notifications on a flaky link. We instead require failStreak to reach
|
|
// the configured threshold (consecutive FAILED probes, tracked per new probe
|
|
// via lastTry) before publishing outbound.down, and only publish outbound.up
|
|
// once a down has actually been notified.
|
|
type outboundHealth struct {
|
|
lastTry int64
|
|
failStreak int
|
|
notified bool
|
|
}
|
|
|
|
var validObsTag = regexp.MustCompile(`^[a-zA-Z0-9._\-]+$`)
|
|
|
|
func obsHistoryKey(tag string) string {
|
|
return "xrObs." + tag + ".delay"
|
|
}
|
|
|
|
func newXrayMetricsClient() *http.Client {
|
|
return &http.Client{Timeout: 1500 * time.Millisecond}
|
|
}
|
|
|
|
func (s *XrayMetricsService) getClient() *http.Client {
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
if s.client == nil {
|
|
s.client = newXrayMetricsClient()
|
|
}
|
|
return s.client
|
|
}
|
|
|
|
func (s *XrayMetricsService) State() xrayMetricsState {
|
|
s.mu.RLock()
|
|
defer s.mu.RUnlock()
|
|
return s.state
|
|
}
|
|
|
|
func (s *XrayMetricsService) AggregateMetric(metric string, bucketSeconds, maxPoints int) []map[string]any {
|
|
return xrayMetrics.aggregate(metric, bucketSeconds, maxPoints)
|
|
}
|
|
|
|
func (s *XrayMetricsService) ObservatorySnapshot() []ObsTagSnapshot {
|
|
s.mu.RLock()
|
|
defer s.mu.RUnlock()
|
|
out := make([]ObsTagSnapshot, 0, len(s.obsByTag))
|
|
for _, v := range s.obsByTag {
|
|
out = append(out, v)
|
|
}
|
|
sort.Slice(out, func(i, j int) bool { return out[i].Tag < out[j].Tag })
|
|
return out
|
|
}
|
|
|
|
func (s *XrayMetricsService) HasObservatoryTag(tag string) bool {
|
|
if !validObsTag.MatchString(tag) {
|
|
return false
|
|
}
|
|
s.mu.RLock()
|
|
defer s.mu.RUnlock()
|
|
_, ok := s.obsByTag[tag]
|
|
return ok
|
|
}
|
|
|
|
func (s *XrayMetricsService) AggregateObservatory(tag string, bucketSeconds, maxPoints int) []map[string]any {
|
|
if !validObsTag.MatchString(tag) {
|
|
return []map[string]any{}
|
|
}
|
|
return xrayMetrics.aggregate(obsHistoryKey(tag), bucketSeconds, maxPoints)
|
|
}
|
|
|
|
func (s *XrayMetricsService) discoverListen() (string, error) {
|
|
tmpl, err := s.settingService.GetXrayConfigTemplate()
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
var parsed struct {
|
|
Metrics *struct {
|
|
Listen string `json:"listen"`
|
|
} `json:"metrics"`
|
|
}
|
|
if err := json.Unmarshal([]byte(tmpl), &parsed); err != nil {
|
|
return "", err
|
|
}
|
|
if parsed.Metrics == nil || strings.TrimSpace(parsed.Metrics.Listen) == "" {
|
|
return "", nil
|
|
}
|
|
return strings.TrimSpace(parsed.Metrics.Listen), nil
|
|
}
|
|
|
|
type rawObsEntry struct {
|
|
Alive bool `json:"alive"`
|
|
Delay int64 `json:"delay"`
|
|
LastSeenTime int64 `json:"last_seen_time"`
|
|
LastTryTime int64 `json:"last_try_time"`
|
|
OutboundTag string `json:"outbound_tag"`
|
|
}
|
|
|
|
func (s *XrayMetricsService) Sample(t time.Time) {
|
|
listen, err := s.discoverListen()
|
|
if err != nil {
|
|
s.setState(xrayMetricsState{Reason: err.Error()})
|
|
return
|
|
}
|
|
if listen == "" {
|
|
s.setState(xrayMetricsState{Reason: "metrics block not configured in xray template"})
|
|
return
|
|
}
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), 1500*time.Millisecond)
|
|
defer cancel()
|
|
url := fmt.Sprintf("http://%s/debug/vars", listen)
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
|
|
if err != nil {
|
|
s.setState(xrayMetricsState{Listen: listen, Reason: err.Error()})
|
|
return
|
|
}
|
|
resp, err := s.getClient().Do(req)
|
|
if err != nil {
|
|
s.setState(xrayMetricsState{Listen: listen, Reason: err.Error()})
|
|
return
|
|
}
|
|
defer resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
s.setState(xrayMetricsState{Listen: listen, Reason: fmt.Sprintf("HTTP %d", resp.StatusCode)})
|
|
return
|
|
}
|
|
|
|
var payload struct {
|
|
MemStats struct {
|
|
HeapAlloc uint64 `json:"HeapAlloc"`
|
|
Sys uint64 `json:"Sys"`
|
|
HeapObjects uint64 `json:"HeapObjects"`
|
|
NumGC uint32 `json:"NumGC"`
|
|
PauseNs [256]uint64 `json:"PauseNs"`
|
|
} `json:"memstats"`
|
|
Observatory map[string]rawObsEntry `json:"observatory"`
|
|
}
|
|
if err := json.NewDecoder(resp.Body).Decode(&payload); err != nil {
|
|
s.setState(xrayMetricsState{Listen: listen, Reason: err.Error()})
|
|
return
|
|
}
|
|
|
|
xrayMetrics.append("xrAlloc", t, float64(payload.MemStats.HeapAlloc))
|
|
xrayMetrics.append("xrSys", t, float64(payload.MemStats.Sys))
|
|
xrayMetrics.append("xrHeapObjects", t, float64(payload.MemStats.HeapObjects))
|
|
xrayMetrics.append("xrNumGC", t, float64(payload.MemStats.NumGC))
|
|
var lastPause uint64
|
|
if payload.MemStats.NumGC > 0 {
|
|
idx := (payload.MemStats.NumGC + 255) % 256
|
|
lastPause = payload.MemStats.PauseNs[idx]
|
|
}
|
|
xrayMetrics.append("xrPauseNs", t, float64(lastPause))
|
|
|
|
s.applyObservatory(t, payload.Observatory)
|
|
s.setState(xrayMetricsState{Enabled: true, Listen: listen})
|
|
}
|
|
|
|
func (s *XrayMetricsService) applyObservatory(t time.Time, entries map[string]rawObsEntry) {
|
|
next := make(map[string]ObsTagSnapshot, len(entries))
|
|
for key, e := range entries {
|
|
tag := e.OutboundTag
|
|
if tag == "" {
|
|
tag = key
|
|
}
|
|
if !validObsTag.MatchString(tag) {
|
|
continue
|
|
}
|
|
snap := ObsTagSnapshot{
|
|
Tag: tag,
|
|
Alive: e.Alive,
|
|
Delay: e.Delay,
|
|
LastSeenTime: e.LastSeenTime,
|
|
LastTryTime: e.LastTryTime,
|
|
UpdatedAt: t.Unix(),
|
|
}
|
|
next[tag] = snap
|
|
xrayMetrics.append(obsHistoryKey(tag), t, float64(e.Delay))
|
|
}
|
|
|
|
threshold := 3
|
|
if v, err := s.settingService.GetOutboundDownThreshold(); err == nil && v > 0 {
|
|
threshold = v
|
|
}
|
|
|
|
s.mu.Lock()
|
|
// Debounce observatory flapping into stable down/up notifications.
|
|
if eventBus != nil {
|
|
if s.health == nil {
|
|
s.health = make(map[string]outboundHealth, len(next))
|
|
}
|
|
for tag, cur := range next {
|
|
// React only to a genuinely new probe attempt (lastTry advanced).
|
|
// The sampler polls far more often than xray probes, so counting
|
|
// samples instead of probes would trip the threshold instantly.
|
|
h := s.health[tag]
|
|
if cur.LastTryTime == 0 || cur.LastTryTime == h.lastTry {
|
|
continue
|
|
}
|
|
h.lastTry = cur.LastTryTime
|
|
if cur.Alive {
|
|
if h.notified {
|
|
eventBus.Publish(eventbus.Event{
|
|
Type: eventbus.EventOutboundUp,
|
|
Source: tag,
|
|
Data: &eventbus.OutboundHealthData{Delay: cur.Delay},
|
|
})
|
|
}
|
|
h.failStreak = 0
|
|
h.notified = false
|
|
} else {
|
|
h.failStreak++
|
|
if h.failStreak >= threshold && !h.notified {
|
|
errMsg := ""
|
|
if cur.Delay < 0 {
|
|
errMsg = "probe failed"
|
|
}
|
|
eventBus.Publish(eventbus.Event{
|
|
Type: eventbus.EventOutboundDown,
|
|
Source: tag,
|
|
Data: &eventbus.OutboundHealthData{Delay: cur.Delay, Error: errMsg},
|
|
})
|
|
h.notified = true
|
|
}
|
|
}
|
|
s.health[tag] = h
|
|
}
|
|
// Forget tags that vanished from the observatory.
|
|
for tag := range s.health {
|
|
if _, ok := next[tag]; !ok {
|
|
delete(s.health, tag)
|
|
}
|
|
}
|
|
}
|
|
|
|
for tag := range s.obsByTag {
|
|
if _, kept := next[tag]; !kept {
|
|
xrayMetrics.drop(obsHistoryKey(tag))
|
|
}
|
|
}
|
|
s.obsByTag = next
|
|
s.mu.Unlock()
|
|
}
|
|
|
|
func (s *XrayMetricsService) setState(st xrayMetricsState) {
|
|
s.mu.Lock()
|
|
s.state = st
|
|
s.mu.Unlock()
|
|
if !st.Enabled && st.Reason != "" {
|
|
logger.Debugf("xray metrics unavailable: %s", st.Reason)
|
|
}
|
|
}
|