mirror of https://github.com/MHSanaei/3x-ui.git synced 2026-08-21 18:37:14 +00:00

Files

T

Sanaei 58669f6146 refactor(ci): replace the in-house review lanes with the official code-review skill

The four pull_request_target review jobs in claude-bot.yml (Senior
Developer / QA / Tester / Arbiter and their shared rubric) are replaced by
a single review job running the official code-review plugin - the same
skill behind Anthropic's hosted Code Review and the review workflow
/install-github-app generates. The hosted service needs a Team/Enterprise
organisation, so the plugin runs in CI on the maintainer's subscription
instead: inline findings on PR open and ready-for-review, plus manual
(re-)review when the owner or a collaborator comments "@claude review".

The official example triggers on pull_request, but GitHub withholds
secrets from fork runs and essentially every 3x-ui pull request is from a
fork, so the job keeps the lanes' pull_request_target posture: the
workspace is the base revision and nothing from the pull request is
checked out or executed.

What the lanes uniquely knew is distilled into REVIEW.md, handed to the
skill via --append-system-prompt and pinned by bot_context_test.go the way
repo-context.md is: the runtime.Runtime dispatch rule, migration and
upgrade safety, the four-step route contract chain including the unchecked
docs copy, the i18n rule, the three link implementations, and the
wire-format verification bar. The mention job now ignores "@claude
review" comments on pull requests so the review trigger does not also
wake the generic bot, and the lane-only rubric file goes with the lanes.

The remaining prompts also lose their tone micro-rules (no emoji, no
exclamation marks, no filler) and the workflow's comment banners are
removed.

2026-08-20 15:09:48 +02:00

3.8 KiB

Raw Blame History

Review instructions

3x-ui is a Go (Gin + GORM) web panel that generates configuration, share links and subscriptions for other programs — Xray-core, mihomo, sing-box, mtg-multi — and is deployed by operators who upgrade in place. Judge findings by what breaks for those consumers and operators, not by style.

What a blocking finding means here

Reserve blocking severity for:

Security on the exposed surfaces: internal/web/controller/, session and middleware code, the PUBLIC internal/sub/ subscription server, and Xray config generation in internal/xray/.
A state-changing inbound or client operation that bypasses runtime.Runtime (internal/web/runtime/) and calls internal/xray/api.go directly, or dispatches from a controller or cron job. It passes every local test and silently breaks every multi-node deployment.
A schema or model change without a matching hand-written migration in internal/database/db.go, one that behaves differently on SQLite and PostgreSQL, or one that loses or overwrites operator data on upgrade or rollback. There are no migration files and no down-migrations.
A change to what the panel emits on the wire — Xray config JSON, share links, subscription/Clash YAML, mtg-multi TOML — that a downstream client would reject or read differently, or that makes the three independent link implementations (Go internal/util/link/ + internal/sub/, TS frontend/src/lib/xray/, TS docs/lib/xray/) diverge from one another.
Any edit to .github/workflows/: this repository runs workflows with secrets against a public fork stream. Untrusted expression interpolation into run: blocks, broadened permissions, weakened guards, or a job that executes pull-request code is blocking.

Style, naming and refactoring suggestions are nits at most.

Always check

A new g.POST/g.GET in internal/web/controller/ needs the whole chain: an entry in frontend/src/pages/api-docs/endpoints.ts, regenerated artefacts (make gen), any new API-boundary struct added to StructAllow in tools/openapigen/main.go, and frontend/public/openapi.json copied to docs/public/openapi.json with the docs MDX regenerated (cd docs && pnpm gen:api). CI checks the first three; the docs copy is checked by nothing — a missed copy is blocking, not a nit.
A new i18n key exists in ALL 13 locale files in internal/web/translation/ and is referenced from frontend/src or Go in the same PR.
A bug fix carries a test that would fail without the fix. A test that passes either way, asserts only err != nil or len(x) > 0, or was made green by regenerating golden fixtures or Vitest snapshots is a real finding.

Do not report

Anything CI already enforces: golangci-lint and gofumpt, oxlint, format and typecheck, npm audit, govulncheck.
The contents of generated files (frontend/src/generated/, frontend/public/openapi.json, docs/public/openapi.json) or lock files. Those files being STALE after a source change is reportable; their style is not.
Missing tests for getters, constants, renames or pure map lookups — CLAUDE.md rejects such tests outright.

Verification bar

A claim about behaviour needs a file:line citation from this repository, not an inference from a name.
A claim that a downstream client rejects or requires a wire-format detail — a config key, JSON tag, URI query parameter, YAML or TOML key, an encoding or hash choice — must name the upstream symbol that decides it (repository, file, identifier). If you cannot verify it, keep the finding but say explicitly that it is unverified instead of asserting it.

Cap the nits

Report at most five nits per review and say "plus N similar" in the summary for the rest. Lead the summary with "No blocking issues" when everything found is a nit. After the first review of a PR, report blocking findings only.

3.8 KiB Raw Blame History