BlindMaster24
ac3fc12077
fix(ports): refuse an inbound on a port an AmneziaWG peer forwards ( #6554 )
...
* fix(ports): refuse an inbound on a port an AmneziaWG peer forwards
checkForwardedPortsConflict only ever ran from the AmneziaWG save path, and only
in one direction: an AmneziaWG client's forwardedPorts were checked against the
ports other inbounds already hold, while the reverse -- an ordinary inbound
saved onto a port some peer forwards -- had no guard at all. The forward
listener binds that port on every interface in both directions
(amneziawgnet/portfwd.go's attachTCP/attachUDP), so the two listeners want the
same socket: the loser either leaves the peer's forward silently dead or fails
the inbound's listen.
checkPortConflictTx now resolves that owner the same way the relay-slot checks
do -- same host, peers derived from the stored settings with the shared
InstanceFromInbound -- and names the peer in the refusal. Sitting inside
checkPortConflictTx covers both the save and the enable path added in #6549 .
TestAddInboundRefusesAPortAnAmneziaWGPeerForwards fails without this -- watched
red, the create is allowed -- and its node-row companion pins the scoping that
keeps a node row legal on a locally forwarded port.
* fix(ports): name only a peer that binds as the owner of a forwarded port
The owner lookup read instance.Peers and ForwardedPortsInclude directly, so a
peer the forward supervisor skips (no email, or no address the tunnel routes
to) was reported as holding a port nothing binds -- refusing a create that is
legal with a message naming a row whose own port is its WireGuard one. It also
repeated the candidate's listen address as the forward's location, though the
forward binds :port on every interface.
Share the supervisor's own gate through amneziawgnet.ForwardedPortOwner, report
the wildcard bind, and propagate a failed owner query instead of reading it as
"no conflict", matching the sibling checks in the same file.
* style(ports): keep the forwarded-key doc block within the 2-line cap
The reworded desiredPortForwardKeys doc ran to three lines, against the rule
this repo sets for committed Go comments.
2026-09-15 16:58:21 +03:00
..
2026-09-13 19:47:49 +02:00
2026-09-09 00:51:44 +02:00
2026-09-02 20:20:10 +02:00
2026-09-14 21:18:31 +03:00
2026-09-15 15:42:30 +03:00
2026-09-13 19:57:46 +02:00
2026-07-17 00:33:06 +02:00
2026-08-15 16:50:20 +02:00
2026-06-27 12:08:20 +02:00
2026-07-05 02:06:58 +02:00
2026-07-17 00:33:06 +02:00
2026-08-18 12:46:00 +02:00
2026-08-18 12:46:00 +02:00
2026-07-05 21:17:25 +02:00
2026-08-24 02:41:15 +02:00
2026-08-24 02:41:15 +02:00
2026-07-17 00:33:06 +02:00
2026-08-24 02:41:15 +02:00
2026-09-10 16:24:48 +02:00
2026-09-10 16:24:48 +02:00
2026-09-10 16:24:48 +02:00
2026-09-10 21:07:49 +02:00
2026-07-08 20:53:42 +02:00
2026-09-15 15:39:40 +03:00
2026-09-04 01:01:20 +02:00
2026-07-11 22:48:51 +02:00
2026-08-24 02:41:15 +02:00
2026-09-12 11:13:42 +02:00
2026-07-11 22:48:57 +02:00
2026-07-07 15:05:22 +02:00
2026-07-05 20:28:26 +02:00
2026-09-09 00:17:54 +02:00
2026-09-15 15:39:40 +03:00
2026-09-07 01:51:18 +02:00
2026-06-24 13:02:42 +02:00
2026-06-10 15:19:22 +02:00
2026-08-23 21:57:03 +02:00
2026-08-18 13:55:04 +02:00
2026-09-12 11:13:19 +02:00
2026-08-14 19:50:06 +02:00
2026-08-23 23:17:56 +02:00
2026-07-02 09:17:47 +02:00
2026-08-14 19:50:06 +02:00
2026-09-12 11:13:22 +02:00
2026-09-12 11:13:22 +02:00
2026-08-20 04:09:57 +02:00
2026-08-24 02:41:15 +02:00
2026-09-15 15:39:40 +03:00
2026-08-24 13:27:40 +02:00
2026-08-20 04:09:57 +02:00
2026-09-12 11:13:42 +02:00
2026-07-17 00:33:06 +02:00
2026-08-23 23:17:56 +02:00
2026-07-28 22:38:44 +02:00
2026-09-10 21:07:49 +02:00
2026-09-07 14:24:14 +02:00
2026-07-30 02:49:32 +02:00
2026-09-04 15:23:41 +02:00
2026-09-12 11:13:42 +02:00
2026-09-12 11:13:42 +02:00
2026-08-15 16:50:20 +02:00
2026-07-07 12:00:43 +02:00
2026-06-10 15:19:22 +02:00
2026-08-23 23:17:56 +02:00
2026-08-01 15:19:08 +02:00
2026-08-23 21:57:03 +02:00
2026-08-18 13:08:44 +02:00
2026-09-10 21:07:49 +02:00
2026-08-24 02:41:15 +02:00
2026-08-15 16:50:20 +02:00
2026-09-07 14:24:14 +02:00
2026-09-10 22:32:42 +02:00
2026-08-15 16:50:20 +02:00
2026-08-15 16:50:20 +02:00
2026-09-09 00:30:02 +02:00
2026-07-05 20:28:26 +02:00
2026-08-24 02:41:15 +02:00
2026-09-10 22:32:42 +02:00
2026-09-12 11:13:42 +02:00
2026-09-14 12:08:38 +02:00
2026-09-14 12:08:38 +02:00
2026-07-05 20:28:26 +02:00
2026-08-18 15:24:59 +02:00
2026-06-27 15:42:22 +02:00
2026-07-28 14:43:55 +02:00
2026-08-15 17:12:59 +02:00
2026-08-14 19:42:09 +02:00
2026-07-30 03:14:22 +02:00
2026-09-13 12:44:55 +02:00
2026-09-13 12:44:55 +02:00
2026-09-13 12:44:55 +02:00
2026-09-13 12:44:55 +02:00
2026-07-08 23:35:20 +02:00
2026-07-23 18:52:42 +02:00
2026-08-18 15:24:59 +02:00
2026-09-15 13:31:07 +03:00
2026-09-09 00:42:52 +02:00
2026-09-15 13:31:07 +03:00
2026-09-12 11:06:47 +02:00
2026-08-22 23:12:33 +02:00
2026-08-18 11:53:11 +02:00
2026-08-14 19:42:09 +02:00
2026-09-02 20:39:03 +02:00
2026-08-14 19:42:09 +02:00
2026-06-10 15:19:22 +02:00
2026-08-24 13:27:40 +02:00
2026-07-23 15:34:42 +02:00
2026-07-02 16:24:18 +02:00
2026-09-12 11:12:13 +02:00
2026-09-12 10:15:48 +02:00
2026-09-12 11:12:13 +02:00
2026-08-18 11:48:40 +02:00
2026-08-15 23:09:16 +02:00
2026-08-14 19:42:09 +02:00
2026-09-08 18:08:24 +02:00
2026-09-15 15:29:32 +03:00
2026-08-01 15:19:08 +02:00
2026-07-17 00:33:06 +02:00
2026-07-28 13:14:06 +02:00
2026-06-24 13:02:42 +02:00
2026-08-15 23:09:16 +02:00
2026-08-22 23:11:42 +02:00
2026-09-08 15:36:57 +02:00
2026-07-21 15:57:55 +02:00
2026-08-14 20:10:39 +02:00
2026-08-15 23:09:16 +02:00
2026-07-07 01:13:24 +02:00
2026-07-07 01:13:24 +02:00
2026-08-01 15:19:08 +02:00
2026-07-06 17:55:57 +02:00
2026-07-17 00:33:06 +02:00
2026-08-01 15:19:08 +02:00
2026-06-22 20:20:55 +02:00
2026-08-24 13:27:40 +02:00
2026-09-09 00:24:01 +02:00
2026-09-13 22:44:50 +02:00
2026-08-23 23:17:56 +02:00
2026-09-13 22:44:50 +02:00
2026-07-03 01:12:32 +02:00
2026-08-24 02:41:15 +02:00
2026-08-24 02:41:15 +02:00
2026-07-08 20:31:00 +02:00
2026-08-20 04:09:57 +02:00
2026-09-12 11:14:53 +02:00
2026-06-27 11:22:45 +02:00
2026-09-12 11:14:53 +02:00
2026-07-05 20:18:59 +02:00
2026-09-08 18:08:24 +02:00
2026-09-12 10:15:48 +02:00
2026-07-27 14:21:56 +02:00
2026-07-28 23:27:09 +02:00
2026-09-12 11:06:47 +02:00
2026-09-12 10:15:48 +02:00
2026-09-08 15:36:57 +02:00
2026-09-12 11:14:53 +02:00
2026-09-12 11:14:53 +02:00
2026-09-15 15:29:32 +03:00
2026-07-17 00:33:06 +02:00
2026-06-26 00:10:30 +02:00
2026-07-25 16:08:09 +02:00
2026-07-07 01:13:24 +02:00
2026-09-10 16:24:48 +02:00
2026-07-08 22:12:28 +02:00
2026-08-23 23:17:56 +02:00
2026-07-07 15:05:23 +02:00
2026-08-23 23:17:56 +02:00
2026-07-23 15:35:11 +02:00
2026-07-23 15:35:11 +02:00
2026-06-20 01:09:53 +02:00
2026-08-23 23:17:56 +02:00
2026-09-03 18:06:35 +02:00
2026-08-23 23:17:56 +02:00
2026-09-07 14:24:14 +02:00
2026-08-15 16:03:42 +02:00
2026-08-15 21:31:31 +02:00
2026-06-16 12:19:33 +02:00
2026-08-23 23:17:56 +02:00
2026-09-08 14:12:13 +02:00
2026-08-01 15:19:08 +02:00
2026-06-22 20:20:55 +02:00
2026-08-23 23:17:56 +02:00
2026-08-20 04:09:57 +02:00
2026-08-23 23:17:56 +02:00
2026-08-14 20:01:35 +02:00
2026-08-15 16:48:50 +02:00
2026-07-08 22:12:28 +02:00
2026-07-23 15:35:11 +02:00
2026-09-13 22:44:50 +02:00
2026-07-23 15:34:42 +02:00
2026-09-11 15:32:04 +02:00
2026-09-11 15:32:04 +02:00
2026-09-15 16:58:21 +03:00
2026-09-15 11:49:18 +03:00
2026-09-15 16:58:21 +03:00
2026-09-13 14:48:28 +02:00
2026-09-13 14:48:28 +02:00
2026-07-17 00:33:06 +02:00
2026-07-08 22:10:54 +02:00
2026-09-13 20:02:43 +02:00
2026-07-12 20:14:22 +02:00
2026-07-12 20:14:22 +02:00
2026-07-06 09:24:18 +02:00
2026-06-24 21:22:42 +02:00
2026-06-20 00:37:35 +02:00
2026-09-15 15:27:28 +03:00
2026-07-14 13:01:40 +02:00
2026-09-13 14:04:53 +02:00
2026-09-13 12:44:55 +02:00
2026-08-15 21:31:31 +02:00
2026-08-23 21:57:03 +02:00
2026-08-15 21:31:31 +02:00
2026-09-10 17:05:54 +02:00
2026-09-15 15:42:30 +03:00
2026-07-28 22:12:52 +02:00
2026-09-08 17:14:01 +02:00
2026-09-13 11:51:56 +02:00
2026-09-15 15:42:30 +03:00
2026-06-17 14:11:35 +02:00
2026-07-12 00:30:47 +02:00
2026-08-23 22:34:20 +02:00
2026-09-02 20:21:27 +02:00
2026-09-02 20:21:27 +02:00
2026-06-10 15:19:22 +02:00
2026-09-10 16:24:48 +02:00
2026-07-17 00:33:06 +02:00
2026-07-02 16:12:46 +02:00
2026-08-14 19:42:09 +02:00
2026-06-10 15:19:22 +02:00
2026-06-17 15:55:47 +02:00
2026-08-24 13:27:40 +02:00
2026-08-24 13:27:40 +02:00
2026-07-02 16:12:46 +02:00
2026-09-15 08:23:18 +03:00
2026-09-10 14:50:48 +02:00
2026-09-15 15:27:28 +03:00
2026-09-15 15:27:28 +03:00
2026-07-27 14:37:57 +02:00
2026-08-24 02:41:15 +02:00
2026-07-02 16:12:46 +02:00
2026-09-15 15:39:40 +03:00
2026-07-29 21:00:29 +02:00
2026-09-03 18:06:15 +02:00
2026-07-23 15:34:42 +02:00
2026-07-23 15:34:42 +02:00
2026-07-17 00:33:06 +02:00
2026-07-23 15:34:42 +02:00
2026-07-23 15:34:42 +02:00
2026-09-14 21:18:31 +03:00
2026-09-14 21:18:31 +03:00
2026-07-21 15:51:46 +02:00
2026-09-10 14:50:48 +02:00
2026-06-15 00:43:49 +02:00
2026-09-10 22:32:42 +02:00
2026-06-23 17:38:16 +02:00
2026-09-15 15:39:40 +03:00