Files
3x-ui/internal/sub/external_subscription_test.go
T
mrchatam bd9ccde1f4 feat(sub): make external subscription fetch User-Agent configurable (#6613)
* feat(sub): make external subscription fetch User-Agent configurable

Some providers reject fetches that do not send a known client User-Agent.
Expose externalSubUserAgent as a panel setting (default v2rayNG/1.8.5)
and use it when fetching client external subscription URLs.

Fixes #6383

* ci: retrigger frontend after npm registry maintenance

The frontend job failed solely on `npm audit` while registry.npmjs.org
returned 503 (Service Under Maintenance). Lint, typecheck, vitest, vite
build, and storybook all passed. Local `npm audit --omit=dev
--audit-level=high` now reports 0 vulnerabilities.

* fix(sub): fall back to the default UA when the DB is not initialised

externalSubUserAgent read the setting through SettingService.getSetting,
which calls Model() on database.GetDB() and panics on a nil *gorm.DB.
The fetch path's other DB read, service.ExternalSubscriptionHwid, already
treats a nil DB as unreachable and sends no header; the new UA lookup
did not, so any fetch before InitDB panicked instead of sending the
historical v2rayNG/1.8.5.

Production initialises the DB before the sub server starts, but the
internal/sub fetch tests run without one: under make test-go's
-shuffle=on, whenever one of them ran before the first InitDB test the
panic aborted the whole package. Reproduced deterministically with
go test -run '^TestDoFetchSubscriptionLinks_RejectsOversizedBody$'.

---------

Co-authored-by: mrchatam <mrchatam@users.noreply.github.com>
Co-authored-by: MHSanaei <ho3ein.sanaei@gmail.com>
2026-09-26 23:36:33 +02:00

356 lines
10 KiB
Go

package sub
import (
"errors"
"net/http"
"net/http/httptest"
"path/filepath"
"strconv"
"strings"
"sync"
"sync/atomic"
"testing"
"time"
"github.com/mhsanaei/3x-ui/v3/internal/database"
"github.com/mhsanaei/3x-ui/v3/internal/database/model"
)
func resetSubscriptionCache(t *testing.T) {
t.Helper()
subscriptionCache.Lock()
previousEntries := subscriptionCache.m
previousInflight := subscriptionCache.inflight
subscriptionCache.m = make(map[string]subscriptionCacheEntry)
subscriptionCache.inflight = make(map[string]*subscriptionFetch)
subscriptionCache.Unlock()
t.Cleanup(func() {
subscriptionCache.Lock()
subscriptionCache.m = previousEntries
subscriptionCache.inflight = previousInflight
subscriptionCache.Unlock()
})
}
func TestFetchSubscriptionLinksSharesConcurrentRefresh(t *testing.T) {
resetSubscriptionCache(t)
var requests atomic.Int32
release := make(chan struct{})
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requests.Add(1)
<-release
_, _ = w.Write([]byte("vless://uuid@example.com:443"))
}))
defer srv.Close()
const callers = 16
results := make(chan []string, callers)
var wg sync.WaitGroup
for range callers {
wg.Go(func() {
results <- fetchSubscriptionLinks(srv.URL).links
})
}
time.Sleep(100 * time.Millisecond)
close(release)
wg.Wait()
close(results)
for links := range results {
if len(links) != 1 || links[0] != "vless://uuid@example.com:443" {
t.Fatalf("links = %#v", links)
}
}
if got := requests.Load(); got != 1 {
t.Fatalf("requests = %d, want 1", got)
}
}
func TestFetchSubscriptionLinksBoundsCacheSize(t *testing.T) {
resetSubscriptionCache(t)
var requests atomic.Int32
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requests.Add(1)
_, _ = w.Write([]byte("vless://uuid@example.com:443"))
}))
defer srv.Close()
for i := range subscriptionCacheCapacity + 1 {
links := fetchSubscriptionLinks(srv.URL + "?id=" + strconv.Itoa(i)).links
if len(links) != 1 {
t.Fatalf("links at %d = %#v", i, links)
}
}
subscriptionCache.Lock()
entries := len(subscriptionCache.m)
subscriptionCache.Unlock()
if entries != subscriptionCacheCapacity {
t.Fatalf("cache entries = %d, want %d", entries, subscriptionCacheCapacity)
}
if got := requests.Load(); got != subscriptionCacheCapacity+1 {
t.Fatalf("requests = %d, want %d", got, subscriptionCacheCapacity+1)
}
}
func TestFetchSubscriptionLinksSharesStaleResultAfterRefreshFailure(t *testing.T) {
resetSubscriptionCache(t)
stale := []string{"vless://stale@example.com:443"}
release := make(chan struct{})
var staleRequests atomic.Int32
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.URL.Path == "/stale" {
staleRequests.Add(1)
<-release
w.WriteHeader(http.StatusBadGateway)
return
}
_, _ = w.Write([]byte("vless://fresh@example.com:443"))
}))
defer srv.Close()
staleURL := srv.URL + "/stale"
subscriptionCache.Lock()
subscriptionCache.m[staleURL] = subscriptionCacheEntry{
links: stale,
fetchedAt: time.Now().Add(-subscriptionCacheTTL),
}
for i := range subscriptionCacheCapacity - 1 {
subscriptionCache.m["cached-"+strconv.Itoa(i)] = subscriptionCacheEntry{fetchedAt: time.Now()}
}
subscriptionCache.Unlock()
const callers = 16
results := make(chan []string, callers)
var wg sync.WaitGroup
for range callers {
wg.Go(func() {
results <- fetchSubscriptionLinks(staleURL).links
})
}
time.Sleep(100 * time.Millisecond)
if links := fetchSubscriptionLinks(srv.URL + "/fresh").links; len(links) != 1 || links[0] != "vless://fresh@example.com:443" {
t.Fatalf("fresh links = %#v", links)
}
close(release)
wg.Wait()
close(results)
for links := range results {
if len(links) != 1 || links[0] != stale[0] {
t.Fatalf("links = %#v, want %#v", links, stale)
}
}
if got := staleRequests.Load(); got != 1 {
t.Fatalf("requests = %d, want 1", got)
}
}
func TestDoFetchSubscriptionLinks_RejectsOversizedBody(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
_, _ = w.Write([]byte(strings.Repeat("a", subscriptionMaxBytes+1)))
}))
defer srv.Close()
links, err := doFetchSubscriptionLinks(srv.URL)
if !errors.Is(err, errSubscriptionBodyTooLarge) {
t.Fatalf("err = %v, want errSubscriptionBodyTooLarge", err)
}
if links != nil {
t.Fatalf("links = %v, want nil", links)
}
}
func TestDoFetchSubscriptionLinks_AcceptsBodyAtLimit(t *testing.T) {
link := "vless://example"
body := link + "\n" + strings.Repeat("#", subscriptionMaxBytes-len(link)-1)
if len(body) != subscriptionMaxBytes {
t.Fatalf("fixture size = %d, want %d", len(body), subscriptionMaxBytes)
}
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
_, _ = w.Write([]byte(body))
}))
defer srv.Close()
links, err := doFetchSubscriptionLinks(srv.URL)
if err != nil {
t.Fatalf("unexpected err: %v", err)
}
if len(links) != 1 || links[0] != link {
t.Fatalf("links = %v, want [%q]", links, link)
}
}
func TestRecordExternalSubscriptionFetchStampsEveryRowForTheURL(t *testing.T) {
initMutDB(t)
resetSubscriptionCache(t)
db := database.GetDB()
var failing atomic.Bool
failing.Store(true)
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if failing.Load() {
w.WriteHeader(http.StatusBadGateway)
return
}
_, _ = w.Write([]byte("vless://uuid@example.com:443#Node"))
}))
defer srv.Close()
owners := []model.ClientRecord{
{Email: "one@example.com", SubID: "sub-fetch", UUID: "uuid-1", Enable: true},
{Email: "two@example.com", SubID: "sub-fetch", UUID: "uuid-2", Enable: true},
}
for i := range owners {
if err := db.Create(&owners[i]).Error; err != nil {
t.Fatalf("seed client %d: %v", i, err)
}
row := model.ClientExternalLink{
ClientId: owners[i].Id,
Kind: model.ExternalLinkKindSubscription,
Value: srv.URL,
}
if err := db.Create(&row).Error; err != nil {
t.Fatalf("seed external link %d: %v", i, err)
}
}
svc := NewSubService("")
entries, err := svc.getClientExternalLinksBySubId("sub-fetch")
if err != nil {
t.Fatalf("getClientExternalLinksBySubId: %v", err)
}
if len(entries) != 2 {
t.Fatalf("entries = %d, want 2", len(entries))
}
for _, e := range entries {
expandEntry(e)
}
var rows []model.ClientExternalLink
if err := db.Where("value = ?", srv.URL).Find(&rows).Error; err != nil {
t.Fatalf("read rows: %v", err)
}
if len(rows) != 2 {
t.Fatalf("rows = %d, want 2", len(rows))
}
for _, row := range rows {
if row.LastFetchAt <= 0 {
t.Fatalf("row %d lastFetchAt = %d, want a stamped timestamp", row.Id, row.LastFetchAt)
}
if row.LastFetchError != errBadStatus.Error() {
t.Fatalf("row %d lastFetchError = %q, want %q", row.Id, row.LastFetchError, errBadStatus)
}
}
failing.Store(false)
resetSubscriptionCache(t)
for _, e := range entries {
expandEntry(e)
}
if err := db.Where("value = ?", srv.URL).Find(&rows).Error; err != nil {
t.Fatalf("re-read rows: %v", err)
}
for _, row := range rows {
if row.LastFetchError != "" {
t.Fatalf("row %d lastFetchError = %q, want cleared after a good fetch", row.Id, row.LastFetchError)
}
if row.LastFetchAt <= 0 {
t.Fatalf("row %d lastFetchAt = %d, want a stamped timestamp", row.Id, row.LastFetchAt)
}
}
}
func TestExpandEntryCacheHitWritesNothing(t *testing.T) {
initMutDB(t)
resetSubscriptionCache(t)
db := database.GetDB()
const subURL = "https://provider.example/cached"
rec := model.ClientRecord{Email: "cached@example.com", SubID: "sub-cached", UUID: "uuid", Enable: true}
if err := db.Create(&rec).Error; err != nil {
t.Fatalf("seed client: %v", err)
}
row := model.ClientExternalLink{ClientId: rec.Id, Kind: model.ExternalLinkKindSubscription, Value: subURL}
if err := db.Create(&row).Error; err != nil {
t.Fatalf("seed external link: %v", err)
}
subscriptionCache.Lock()
subscriptionCache.m[subURL] = subscriptionCacheEntry{
links: []string{"vless://uuid@example.com:443#Node"},
fetchedAt: time.Now(),
}
subscriptionCache.Unlock()
if got := expandEntry(externalLinkEntry{Kind: model.ExternalLinkKindSubscription, Value: subURL}); len(got) != 1 {
t.Fatalf("expandEntry = %#v, want the cached link", got)
}
var after model.ClientExternalLink
if err := db.First(&after, row.Id).Error; err != nil {
t.Fatalf("read row: %v", err)
}
if after.LastFetchAt != 0 || after.LastFetchError != "" {
t.Fatalf("cache hit wrote fetch status: %#v", after)
}
}
func TestFetchUsesConfiguredExternalSubUserAgent(t *testing.T) {
resetSubscriptionCache(t)
if err := database.InitDB(filepath.Join(t.TempDir(), "ua.db")); err != nil {
t.Fatalf("InitDB: %v", err)
}
t.Cleanup(func() { _ = database.CloseDB() })
const customUA = "Happ/4.2.1"
if err := database.GetDB().Create(&model.Setting{
Key: "externalSubUserAgent",
Value: customUA,
}).Error; err != nil {
t.Fatalf("save setting: %v", err)
}
var gotUA string
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
gotUA = r.Header.Get("User-Agent")
_, _ = w.Write([]byte("vless://uuid@host:443?security=none#x"))
}))
defer srv.Close()
res := fetchSubscriptionLinks(srv.URL)
if res.err != nil {
t.Fatalf("fetch: %v", res.err)
}
if gotUA != customUA {
t.Fatalf("User-Agent = %q, want %q", gotUA, customUA)
}
}
func TestFetchFallsBackToDefaultExternalSubUserAgent(t *testing.T) {
resetSubscriptionCache(t)
if err := database.InitDB(filepath.Join(t.TempDir(), "ua-default.db")); err != nil {
t.Fatalf("InitDB: %v", err)
}
t.Cleanup(func() { _ = database.CloseDB() })
var gotUA string
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
gotUA = r.Header.Get("User-Agent")
_, _ = w.Write([]byte("vless://uuid@host:443?security=none#x"))
}))
defer srv.Close()
res := fetchSubscriptionLinks(srv.URL)
if res.err != nil {
t.Fatalf("fetch: %v", res.err)
}
if gotUA != "v2rayNG/1.8.5" {
t.Fatalf("User-Agent = %q, want default v2rayNG/1.8.5", gotUA)
}
}