Files
3x-ui/frontend/src/hooks/useServerDraft.ts
T
Sanaei b9eda09da9 chore(frontend): update dependencies and adapt to oxlint 1.79
npm install was failing with ERESOLVE: the lockfile pinned storybook 10.5.7
and vitest 4.1.10 as peers while package.json asked for ^10.5.9 and ^4.1.11,
and npm would not move either. Neither npm update, a targeted install, nor
--package-lock-only broke the cycle, so node_modules and package-lock.json
were regenerated from scratch (601 packages, 0 vulnerabilities).

oxlint 1.79.0 then promoted five React Compiler rules into the correctness
category, flagging 101 pre-existing sites. 1.78.0 exits 0 on the same tree,
so nothing in our code changed - the rule set grew. They are fixed rather
than suppressed:

- refs (31): latest-value ref writes moved out of render into an effect.
  onlineClientsRef turned out to be write-only and is gone; expireDiffRef
  and trafficDiffRef were replaced by reading the values directly.
- set-state-in-effect (55): reset-on-open modals now adjust state during
  render; where an effect mixed a synchronous reset with an async fetch, the
  reset moved to render and the effect kept only the request. useMediaQuery
  became useSyncExternalStore.
- preserve-manual-memoization (11): optional-chained deps the compiler cannot
  match, hoisted to locals or dropped where the memo wrapped a string concat.
- purity (3): Date.now() in render replaced by a state-backed clock, which
  also refreshes the expiry tag every 60s instead of freezing it until the
  next unrelated re-render.
- immutability (1): applyClientStatsEvent merged websocket traffic into
  DBInbound rows in place; it now rebuilds only the rows it touches.

Two things fell out of that. clientCount is derived with useMemo instead of
an imperative rebuildClientCount() called from five sites, which also fixes a
staleness bug where changing the expiry or traffic threshold left the counts
alone until some later rebuild. statsVersion existed only to force a
re-render after an in-place mutation, is meaningless now that rows are
replaced, and nothing read it, so it is removed.

Also adds a lint:fix script - oxlint --fix was previously only reachable
through the lint-staged hook.
2026-08-19 17:48:28 +02:00

36 lines
1.1 KiB
TypeScript

import { useCallback, useEffect, useRef, useState } from 'react';
export function useServerDraft<T>(
server: T | undefined,
clone: (value: T) => T,
equals: (left: T, right: T) => boolean,
) {
const cloneRef = useRef(clone);
useEffect(() => {
cloneRef.current = clone;
});
const [draft, setDraft] = useState<T | undefined>();
const [baseline, setBaseline] = useState<T | undefined>();
const [syncedServer, setSyncedServer] = useState<T | undefined>();
const isDirty = draft !== undefined && (baseline === undefined || !equals(draft, baseline));
// Adopting the server value during render (not in an effect) keeps the
// returned draft and isDirty consistent within the very first render.
if (server !== syncedServer) {
setSyncedServer(server);
if (server !== undefined) {
setBaseline(server);
const keepLocalEdits = isDirty && !equals(draft as T, server);
if (!keepLocalEdits) setDraft(clone(server));
}
}
const markSaved = useCallback((value: T) => {
setBaseline(cloneRef.current(value));
}, []);
return { draft, setDraft, isDirty, markSaved };
}