3x-ui/internal/web/service/discord/gateway_test.go

package discord

import (
	"context"
	"encoding/json"
	"io"
	"net"
	"net/http"
	"net/http/httptest"
	"strings"
	"sync"
	"testing"
	"time"

	"github.com/gorilla/websocket"

	"github.com/mhsanaei/3x-ui/v3/internal/database/model"
	"github.com/mhsanaei/3x-ui/v3/internal/web/service"
	"github.com/mhsanaei/3x-ui/v3/internal/xray"
)

type mockXrayRestart struct {
	restarted bool
	err       error
}

func (m *mockXrayRestart) RestartXray(force bool) error {
	m.restarted = true
	return m.err
}

func TestGatewayClient_EndToEndCommands(t *testing.T) {
	settingService := setupTestDB(t)
	_ = settingService.SetDiscordBotEnable(true)
	_ = settingService.SetDiscordBotToken("test-gw-token")
	_ = settingService.SetDiscordChannelId("ch-12345")
	_ = settingService.SetDiscordAdminIds("u1")

	var sentMessages []MessagePayload
	var mu sync.Mutex

	restServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		var p MessagePayload
		_ = json.NewDecoder(r.Body).Decode(&p)
		mu.Lock()
		sentMessages = append(sentMessages, p)
		mu.Unlock()
		w.WriteHeader(http.StatusOK)
		_, _ = w.Write([]byte(`{"id": "msg-sent"}`))
	}))
	defer restServer.Close()

	discordSvc := NewDiscordService(settingService)
	discordSvc.SetBaseURL(restServer.URL)
	discordSvc.SetHTTPClient(restServer.Client())

	upgrader := websocket.Upgrader{}
	wsConnected := make(chan struct{})

	wsServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		conn, err := upgrader.Upgrade(w, r, nil)
		if err != nil {
			return
		}
		defer conn.Close()

		// 1. Send Op 10 Hello
		hello := GatewayPayload{
			Op: opHello,
			D:  []byte(`{"heartbeat_interval": 500}`),
		}
		_ = conn.WriteJSON(hello)

		// 2. Read Op 2 Identify
		var ident GatewayPayload
		_ = conn.ReadJSON(&ident)

		close(wsConnected)

		// 3. Send !help message
		helpMsg := MessageCreateData{
			ID:        "m1",
			ChannelID: "ch-12345",
			Content:   "!help",
			Author: struct {
				ID       string `json:"id"`
				Username string `json:"username"`
				Bot      bool   `json:"bot"`
			}{ID: "u1", Username: "Alice", Bot: false},
		}
		helpBytes, _ := json.Marshal(helpMsg)
		_ = conn.WriteJSON(GatewayPayload{
			Op: opDispatch,
			T:  "MESSAGE_CREATE",
			D:  helpBytes,
		})

		time.Sleep(50 * time.Millisecond)

		// 4. Send !status message
		statusMsg := MessageCreateData{
			ID:        "m2",
			ChannelID: "ch-12345",
			Content:   "!status",
			Author: struct {
				ID       string `json:"id"`
				Username string `json:"username"`
				Bot      bool   `json:"bot"`
			}{ID: "u1", Username: "Alice", Bot: false},
		}
		statusBytes, _ := json.Marshal(statusMsg)
		_ = conn.WriteJSON(GatewayPayload{
			Op: opDispatch,
			T:  "MESSAGE_CREATE",
			D:  statusBytes,
		})

		time.Sleep(50 * time.Millisecond)

		// 5. Send message from a bot (must be ignored)
		botMsg := MessageCreateData{
			ID:        "m3",
			ChannelID: "ch-12345",
			Content:   "!status",
			Author: struct {
				ID       string `json:"id"`
				Username string `json:"username"`
				Bot      bool   `json:"bot"`
			}{ID: "u2", Username: "OtherBot", Bot: true},
		}
		botBytes, _ := json.Marshal(botMsg)
		_ = conn.WriteJSON(GatewayPayload{
			Op: opDispatch,
			T:  "MESSAGE_CREATE",
			D:  botBytes,
		})

		time.Sleep(50 * time.Millisecond)

		// 6. Send !usage for existing client
		usageMsg := MessageCreateData{
			ID:        "m4",
			ChannelID: "ch-12345",
			Content:   "!usage client@test.com",
			Author: struct {
				ID       string `json:"id"`
				Username string `json:"username"`
				Bot      bool   `json:"bot"`
			}{ID: "u1", Username: "Alice", Bot: false},
		}
		usageBytes, _ := json.Marshal(usageMsg)
		_ = conn.WriteJSON(GatewayPayload{
			Op: opDispatch,
			T:  "MESSAGE_CREATE",
			D:  usageBytes,
		})

		time.Sleep(50 * time.Millisecond)

		// 7. Send !restart command
		restartMsg := MessageCreateData{
			ID:        "m5",
			ChannelID: "ch-12345",
			Content:   "!restart",
			Author: struct {
				ID       string `json:"id"`
				Username string `json:"username"`
				Bot      bool   `json:"bot"`
			}{ID: "u1", Username: "Alice", Bot: false},
		}
		restartBytes, _ := json.Marshal(restartMsg)
		_ = conn.WriteJSON(GatewayPayload{
			Op: opDispatch,
			T:  "MESSAGE_CREATE",
			D:  restartBytes,
		})

		// Keep connection alive until closed
		for {
			var p GatewayPayload
			if err := conn.ReadJSON(&p); err != nil {
				break
			}
		}
	}))
	defer wsServer.Close()

	mockServer := &mockServerProvider{
		status: &service.Status{
			Uptime:   10000,
			Loads:    []float64{0.1, 0.2, 0.3},
			TcpCount: 5,
			UdpCount: 2,
		},
	}
	mockInbound := &mockInboundProvider{
		inbounds: []*model.Inbound{
			{
				Id:       1,
				Remark:   "VLESS-Test",
				Port:     8443,
				Protocol: "vless",
				Enable:   true,
				ClientStats: []xray.ClientTraffic{
					{
						Email:  "client@test.com",
						Enable: true,
						Up:     1024,
						Down:   2048,
						Total:  10485760,
					},
				},
			},
		},
	}
	mockXray := &mockXrayRestart{}

	wsURL := "ws" + strings.TrimPrefix(wsServer.URL, "http")

	gw := NewGatewayClient(discordSvc, settingService, mockServer, mockInbound, mockXray)
	gw.SetGatewayURL(wsURL)

	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	if err := gw.Start(ctx); err != nil {
		t.Fatalf("gw.Start failed: %v", err)
	}

	select {
	case <-wsConnected:
	case <-time.After(3 * time.Second):
		t.Fatal("timed out waiting for WS connection")
	}

	// Wait for dispatches to be processed
	time.Sleep(300 * time.Millisecond)

	gw.Stop()

	if gw.IsRunning() {
		t.Error("expected gateway not to be running after Stop")
	}

	mu.Lock()
	msgs := make([]MessagePayload, len(sentMessages))
	copy(msgs, sentMessages)
	mu.Unlock()

	// We expect:
	// 1. !help response embed
	// 2. !status response embed
	// (bot message ignored)
	// 3. !usage response embed
	// 4. !restart "Restarting..." and "Restarted successfully"
	if len(msgs) < 4 {
		t.Fatalf("expected at least 4 message responses, got %d: %+v", len(msgs), msgs)
	}

	foundHelp := false
	foundStatus := false
	foundUsage := false
	for _, m := range msgs {
		for _, e := range m.Embeds {
			if strings.Contains(e.Title, "Discord Bot Commands") {
				foundHelp = true
			}
			if strings.Contains(e.Title, "Server Status") {
				foundStatus = true
			}
			if strings.Contains(e.Title, "Client Usage: client@test.com") {
				foundUsage = true
			}
		}
	}

	if !foundHelp {
		t.Error("expected help embed to be sent")
	}
	if !foundStatus {
		t.Error("expected status embed to be sent")
	}
	if !foundUsage {
		t.Error("expected usage embed to be sent")
	}
	if !mockXray.restarted {
		t.Error("expected Xray core to be restarted")
	}
}

func TestGatewayRequestedHeartbeatDoesNotRaceTicker(t *testing.T) {
	settingService := setupTestDB(t)
	_ = settingService.SetDiscordBotEnable(true)
	_ = settingService.SetDiscordBotToken("test-gw-token")

	var once sync.Once
	flooded := make(chan struct{})
	upgrader := websocket.Upgrader{}
	wsServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		conn, err := upgrader.Upgrade(w, r, nil)
		if err != nil {
			return
		}
		defer conn.Close()
		// 10ms, not 1ms: Discord answers every heartbeat and the client now drops a
		// socket it hears nothing back on, so the ACK needs room to arrive.
		_ = conn.WriteJSON(GatewayPayload{Op: opHello, D: []byte(`{"heartbeat_interval": 10}`)})

		// Two server goroutines write, so they share one writer: gorilla panics on
		// concurrent writes, and this test is about the CLIENT's two writers.
		var writeMu sync.Mutex
		writeJSON := func(v any) error {
			writeMu.Lock()
			defer writeMu.Unlock()
			return conn.WriteJSON(v)
		}

		readErr := make(chan error, 1)
		go func() {
			for {
				var payload GatewayPayload
				if err := conn.ReadJSON(&payload); err != nil {
					readErr <- err
					return
				}
				// Discord answers every heartbeat; without this the zombie check
				// closes the socket a millisecond into the flood below.
				if payload.Op == opHeartbeat {
					if err := writeJSON(GatewayPayload{Op: opHeartbeatACK}); err != nil {
						readErr <- err
						return
					}
				}
			}
		}()
		// Op 1 from the server makes the read loop write while the ticker writes too.
		for deadline := time.Now().Add(time.Second); time.Now().Before(deadline); {
			if err := writeJSON(GatewayPayload{Op: opHeartbeat}); err != nil {
				break
			}
			// Leave the client room to drain the flood and answer: a saturated
			// socket delays the ACK this test now depends on.
			time.Sleep(time.Millisecond)
		}
		select {
		case err := <-readErr:
			t.Errorf("server read a broken client frame during the flood: %v", err)
		default:
		}
		once.Do(func() { close(flooded) })
	}))
	defer wsServer.Close()

	gw := NewGatewayClient(NewDiscordService(settingService), settingService, nil, nil, nil)
	gw.SetGatewayURL("ws" + strings.TrimPrefix(wsServer.URL, "http"))
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
	if err := gw.Start(ctx); err != nil {
		t.Fatalf("gw.Start failed: %v", err)
	}
	defer gw.Stop()

	select {
	case <-flooded:
	case <-time.After(5 * time.Second):
		t.Fatal("timed out waiting for the heartbeat flood to finish")
	}
}

func TestGatewayStopsOnNonReconnectableCloseCode(t *testing.T) {
	settingService := setupTestDB(t)
	_ = settingService.SetDiscordBotEnable(true)
	_ = settingService.SetDiscordBotToken("test-gw-token")

	var mu sync.Mutex
	dials := 0
	upgrader := websocket.Upgrader{}
	wsServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		conn, err := upgrader.Upgrade(w, r, nil)
		if err != nil {
			return
		}
		defer conn.Close()
		mu.Lock()
		dials++
		mu.Unlock()
		_ = conn.WriteJSON(GatewayPayload{Op: opHello, D: []byte(`{"heartbeat_interval": 45000}`)})
		var ident GatewayPayload
		_ = conn.ReadJSON(&ident)
		closeMsg := websocket.FormatCloseMessage(4014, "Disallowed intent(s).")
		_ = conn.WriteControl(websocket.CloseMessage, closeMsg, time.Now().Add(time.Second))
	}))
	defer wsServer.Close()

	gw := NewGatewayClient(NewDiscordService(settingService), settingService, nil, nil, nil)
	gw.SetGatewayURL("ws" + strings.TrimPrefix(wsServer.URL, "http"))
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
	if err := gw.Start(ctx); err != nil {
		t.Fatalf("gw.Start failed: %v", err)
	}
	defer gw.Stop()

	for deadline := time.Now().Add(2 * time.Second); gw.IsRunning() && time.Now().Before(deadline); {
		time.Sleep(20 * time.Millisecond)
	}
	if gw.IsRunning() {
		t.Fatal("gateway still running after close code 4014, which Discord marks non-reconnectable")
	}
	mu.Lock()
	defer mu.Unlock()
	if dials != 1 {
		t.Fatalf("gateway dialed %d times, want 1", dials)
	}
}

func TestGatewayDialsThroughPanelEgressProxy(t *testing.T) {
	settingService := setupTestDB(t)
	_ = settingService.SetDiscordBotEnable(true)
	_ = settingService.SetDiscordBotToken("test-gw-token")

	identified := make(chan struct{}, 1)
	upgrader := websocket.Upgrader{}
	wsServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		conn, err := upgrader.Upgrade(w, r, nil)
		if err != nil {
			return
		}
		defer conn.Close()
		_ = conn.WriteJSON(GatewayPayload{Op: opHello, D: []byte(`{"heartbeat_interval": 45000}`)})
		var ident GatewayPayload
		if conn.ReadJSON(&ident) == nil {
			select {
			case identified <- struct{}{}:
			default:
			}
		}
		for {
			if _, _, err := conn.ReadMessage(); err != nil {
				return
			}
		}
	}))
	defer wsServer.Close()

	var mu sync.Mutex
	tunneledTo := ""
	proxy := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		if r.Method != http.MethodConnect {
			http.Error(w, "CONNECT only", http.StatusMethodNotAllowed)
			return
		}
		mu.Lock()
		tunneledTo = r.Host
		mu.Unlock()
		upstream, err := net.Dial("tcp", r.Host)
		if err != nil {
			http.Error(w, err.Error(), http.StatusBadGateway)
			return
		}
		defer upstream.Close()
		client, _, err := w.(http.Hijacker).Hijack()
		if err != nil {
			return
		}
		defer client.Close()
		_, _ = client.Write([]byte("HTTP/1.1 200 Connection established\r\n\r\n"))
		go func() { _, _ = io.Copy(upstream, client) }()
		_, _ = io.Copy(client, upstream)
	}))
	defer proxy.Close()

	gw := NewGatewayClient(NewDiscordService(settingService), settingService, nil, nil, nil)
	gw.SetGatewayURL("ws" + strings.TrimPrefix(wsServer.URL, "http"))
	gw.egressProxyURL = func() string { return proxy.URL }
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
	if err := gw.Start(ctx); err != nil {
		t.Fatalf("gw.Start failed: %v", err)
	}
	defer gw.Stop()

	select {
	case <-identified:
	case <-time.After(3 * time.Second):
		t.Fatal("timed out waiting for the gateway to identify")
	}
	mu.Lock()
	defer mu.Unlock()
	if want := strings.TrimPrefix(wsServer.URL, "http://"); tunneledTo != want {
		t.Fatalf("gateway tunneled to %q through the panel egress proxy, want %q", tunneledTo, want)
	}
}

func TestGatewayCommandsRequireListedAdmin(t *testing.T) {
	cases := []struct {
		name        string
		adminIDs    string
		author      string
		wantRestart bool
	}{
		{"listed admin", "111, 222", "222", true},
		{"unlisted member", "111", "999", false},
		{"empty list allows nobody", "", "111", false},
	}
	for _, tc := range cases {
		t.Run(tc.name, func(t *testing.T) {
			settingService := setupTestDB(t)
			_ = settingService.SetDiscordBotToken("token")
			_ = settingService.SetDiscordChannelId("ch-1")
			_ = settingService.SetDiscordAdminIds(tc.adminIDs)

			server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
				w.WriteHeader(http.StatusOK)
			}))
			defer server.Close()
			svc := NewDiscordService(settingService)
			svc.SetBaseURL(server.URL)
			svc.SetHTTPClient(server.Client())

			restarter := &mockXrayRestart{}
			msg := MessageCreateData{ChannelID: "ch-1", Content: "!restart"}
			msg.Author.ID = tc.author
			NewGatewayClient(svc, settingService, nil, nil, restarter).handleMessage(context.Background(), msg)

			if restarter.restarted != tc.wantRestart {
				t.Fatalf("author %q with admin list %q: restarted = %v, want %v", tc.author, tc.adminIDs, restarter.restarted, tc.wantRestart)
			}
		})
	}
}