Files
3x-ui/internal/xray/geodata/token.go
T
Grigoriy d7698ec7aa feat(xray): browse geosite/geoip categories from routing rules (#6165)
* feat(xray): browse geosite/geoip categories from routing rules

Routing rules made you type category names from memory: nothing showed which
categories a database actually contains, what is inside one, or whether a
name resolves at all — a typo only surfaced when Xray refused the config.

The panel now reads Xray's .dat databases itself and exposes them over four
endpoints: databases in the asset folder, a database's categories, one page
of a category's rules, and validation of the tokens already in a rule. The
reader walks the protobuf wire format directly rather than decoding into Go
structs, because a 10 MB geosite.dat holds well over a million domains and
materialising them costs ~284 MB where streaming costs ~19 MB. Only the
category index is cached, entry pages are scanned on demand, and scans are
serialised, so twenty concurrent requests peak at 87 MB instead of 1 GB.
A database's type is decided by its contents, not its file name, since
custom .dat files are named freely.

In the rule form, the source-IP, IP and domain fields gain a database button
opening the browser: search over categories, a preview of what a category
holds, and a multi-select that merges into the field. Plain domains, CIDRs
and categories the panel does not know are left untouched; categories already
present come back ticked, and unticking one removes it from the rule.

* fix(xray): read geo databases through os.Root and match codes verbatim

CodeQL flagged the database read as a path built from a user-supplied value,
and it was right about the shape of it. The file name arrives in a request;
resolve() rejects traversal and stats the file through an os.Root, but the
read itself went through a joined path with os.ReadFile. That left the
symlink defence incomplete: the stat could pass while the read followed a
link planted — or swapped in — afterwards.

Reads now go through the same root, so a request-supplied name never becomes
a path this code resolves on its own, and the size limit is applied to the
opened file rather than to a separate stat of it.

Lookup no longer trims the category code either. It backs the routing-token
validator, and the core matches codes verbatim: "geosite: cn" will not start
Xray, so repairing that space here hid exactly the typo the validator exists
to report.

* fix(xray): address review findings on the geo category browser

Asset folder. The browser read config.GetBinFolderPath() unconditionally,
but the core honours a preset XRAY_LOCATION_ASSET and only falls back to the
bin folder (ensureXrayAssetLocation). On an install pointing at a shared
asset directory the panel listed an empty folder and reported perfectly
valid geosite:/geoip: tokens as missing — the validator warning about a
correct config. The directory is now resolved with the core's precedence.

Paging. Serving one page read and rescanned the whole database, so walking
category-ads-all re-read it per page. The index now records each category's
byte range and a page reads only that record through the os.Root handle,
with the current category's records held for the duration of a paging
session. Profiling that also showed the real cost was not the read but the
slice of payload pointers built per call — a category holds a hundred
thousand of them — so records are now walked with a callback instead.
Ten pages over category-ads-all: 239 MB allocated, now 4.3 MB.

Cached failures. Any error from reading a file was latched under the file's
size+mtime, so a transient ENOMEM or EMFILE marked a healthy database as
damaged until it changed on disk. Only deterministic failures are cached.

Wrong kind. A geoip: token typed into a domain field parsed as a plain
domain and was waved through, though the core cannot resolve it as one. It
is now reported, with its own reason and wording.

Frontend. The category filter fed the query key on every keystroke, so each
character triggered a request that re-scanned the database; it is debounced
now. GeoTokenInput accepts and forwards a ref, so React Hook Form can focus
these three fields on a validation error again. A failed validation shows
that it failed instead of rendering the same empty state as "no issues".

Also drops an unreachable branch in the token-count guard and corrects the
categories endpoint docs, where limit is unbounded by default.

---------

Co-authored-by: STRENCH0 <17428017+STRENCH0@users.noreply.github.com>
2026-08-15 17:12:59 +02:00

144 lines
4.3 KiB
Go

package geodata
import (
"errors"
"strings"
xraygeodata "github.com/xtls/xray-core/common/geodata"
)
// DefaultSiteFile and DefaultIPFile are the databases the geosite: and geoip:
// shorthands expand to.
const (
DefaultSiteFile = xraygeodata.DefaultGeoSiteDat
DefaultIPFile = xraygeodata.DefaultGeoIPDat
)
var (
// ErrInvalidToken reports a routing token that names a database but does not
// resolve to a file and category.
ErrInvalidToken = errors.New("invalid geodata routing token")
// ErrWrongKind reports a token carrying the other rule kind's prefix, such
// as geoip: typed into a domain field.
ErrWrongKind = errors.New("geodata token belongs to the other rule kind")
)
var (
sitePrefixes = []string{"ext:", "ext-domain:", "ext-site:"}
ipPrefixes = []string{"ext:", "ext-ip:"}
)
// Reference is the database file and category a routing token points at.
// An empty File means a plain domain or CIDR, which needs no database.
type Reference struct {
File string
Code string
Attributes []string
Reverse bool
}
// ParseReference resolves a routing token the way xray-core does, expanding the
// geosite:/geoip: shorthands to their ext: form. The core's own parser is not
// reusable here: it opens the database from disk as part of parsing, which
// would both duplicate this package's cache and fail whenever the file is
// merely absent — exactly the case the panel needs to report.
func ParseReference(token string, kind GeoKind) (Reference, error) {
token = strings.TrimSpace(token)
if token == "" {
return Reference{}, ErrInvalidToken
}
var reference Reference
if kind == KindIP {
// The core strips one "!" before the prefix and another before the code,
// each flipping the match, so "!!geoip:cn" is an ordinary geoip:cn.
token, reference.Reverse = cutNegation(token)
}
shorthand, defaultFile, prefixes := "geosite:", DefaultSiteFile, sitePrefixes
if kind == KindIP {
shorthand, defaultFile, prefixes = "geoip:", DefaultIPFile, ipPrefixes
}
if rest, found := strings.CutPrefix(token, shorthand); found {
token = "ext:" + defaultFile + ":" + rest
}
// A geoip: token in a domain field (or the reverse) parses as a plain
// domain and would be waved through, yet the core cannot resolve it as one.
// The field knows its own kind, so say so instead.
if strings.HasPrefix(token, otherShorthand(kind)) {
return Reference{}, ErrWrongKind
}
rest, matched := "", false
for _, prefix := range prefixes {
if trimmed, found := strings.CutPrefix(token, prefix); found {
rest, matched = trimmed, true
break
}
}
if !matched {
return Reference{}, nil
}
if rest == "" {
return Reference{}, ErrInvalidToken
}
file, code, found := strings.Cut(rest, ":")
if !found || file == "" {
return Reference{}, ErrInvalidToken
}
if kind == KindIP {
var negated bool
code, negated = cutNegation(code)
reference.Reverse = reference.Reverse != negated
}
reference.File = file
// Attribute filters exist for domain rules only; in an ip rule the core
// treats "@" as part of the category code and fails to resolve it, so the
// panel must not quietly strip it either.
// Whitespace inside the token is significant: the core matches the code and
// the attributes verbatim, so "geosite: cn" and "geosite:cn@ ads" are its
// problems to report, not ours to silently repair. Only the case is folded,
// which the core does too.
if kind == KindSite {
parts := strings.Split(code, "@")
code = parts[0]
for _, attribute := range parts[1:] {
// The core rejects an empty attribute outright ("geosite:cn@"),
// so accepting it here would hide a config it will not start with.
if attribute == "" {
return Reference{}, ErrInvalidToken
}
reference.Attributes = append(reference.Attributes, strings.ToLower(attribute))
}
}
reference.Code = strings.ToLower(code)
if reference.Code == "" {
return Reference{}, ErrInvalidToken
}
return reference, nil
}
// cutNegation strips leading "!" markers, reporting whether an odd number of
// them was present — the core folds a double negation back into a plain match.
func cutNegation(value string) (string, bool) {
negated := false
for {
rest, found := strings.CutPrefix(value, "!")
if !found {
return value, negated
}
value = rest
negated = !negated
}
}
func otherShorthand(kind GeoKind) string {
if kind == KindIP {
return "geosite:"
}
return "geoip:"
}