mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-07-06 21:04:20 +00:00
MHSanaei
de70ecb026
pg_restore cannot read archives newer than itself, so importing a dump made by pg_dump from PostgreSQL 17+ into a panel with an older postgresql-client failed with a raw 'unsupported version (1.16) in file header' - and only after Xray had already been stopped for the restore. Probe the uploaded file with pg_restore --list first, which reads only the archive TOC without touching the database, so an unreadable dump is rejected before Xray is interrupted. When the failure is a dump-format version mismatch, translate it into a message naming the PostgreSQL version that produced the dump and the client version to install.
76 lines
3.0 KiB
Go
76 lines
3.0 KiB
Go
package service
|
|
|
|
import "testing"
|
|
|
|
func TestPgRestoreReadFailureError(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
probeOutput string
|
|
localVersion string
|
|
want string
|
|
}{
|
|
{
|
|
name: "dump from postgres 17 on older client",
|
|
probeOutput: "pg_restore: error: unsupported version (1.16) in file header",
|
|
localVersion: "16.4",
|
|
want: "This backup was created by pg_dump from PostgreSQL 17 or newer, but the server's pg_restore is version 16.4 and cannot read it; upgrade the postgresql-client package to version 17 or newer and retry the import",
|
|
},
|
|
{
|
|
name: "dump from postgres 16 on older client",
|
|
probeOutput: "pg_restore: error: unsupported version (1.15) in file header",
|
|
localVersion: "15.8",
|
|
want: "This backup was created by pg_dump from PostgreSQL 16 or newer, but the server's pg_restore is version 15.8 and cannot read it; upgrade the postgresql-client package to version 16 or newer and retry the import",
|
|
},
|
|
{
|
|
name: "archive version newer than any known mapping",
|
|
probeOutput: "pg_restore: error: unsupported version (1.17) in file header",
|
|
localVersion: "17.2",
|
|
want: "This backup was created by a newer pg_dump than the server's pg_restore (version 17.2) can read; upgrade the postgresql-client package and retry the import",
|
|
},
|
|
{
|
|
name: "local version could not be determined",
|
|
probeOutput: "pg_restore: error: unsupported version (1.16) in file header",
|
|
localVersion: "",
|
|
want: "This backup was created by pg_dump from PostgreSQL 17 or newer, but the server's pg_restore is version unknown and cannot read it; upgrade the postgresql-client package to version 17 or newer and retry the import",
|
|
},
|
|
{
|
|
name: "unrelated read failure passes through",
|
|
probeOutput: "pg_restore: error: could not read from input file: end of file",
|
|
localVersion: "16.4",
|
|
want: "pg_restore cannot read this dump file: pg_restore: error: could not read from input file: end of file",
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
err := pgRestoreReadFailureError(tc.probeOutput, tc.localVersion)
|
|
if err == nil {
|
|
t.Fatal("pgRestoreReadFailureError returned nil, want error")
|
|
}
|
|
if err.Error() != tc.want {
|
|
t.Errorf("pgRestoreReadFailureError(%q, %q) = %q, want %q", tc.probeOutput, tc.localVersion, err.Error(), tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParsePgToolVersion(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
in string
|
|
want string
|
|
}{
|
|
{"plain", "pg_restore (PostgreSQL) 17.2\n", "17.2"},
|
|
{"debian packaging suffix", "pg_restore (PostgreSQL) 16.10 (Debian 16.10-1.pgdg120+1)\n", "16.10"},
|
|
{"three component version", "pg_restore (PostgreSQL) 9.6.24\n", "9.6.24"},
|
|
{"no version present", "pg_restore malfunction\n", ""},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
got := parsePgToolVersion(tc.in)
|
|
if got != tc.want {
|
|
t.Errorf("parsePgToolVersion(%q) = %q, want %q", tc.in, got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|