mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-07-05 04:14:21 +00:00
eec030f86f
* feat(notifications): event bus architecture with Telegram and SMTP subscribers
- Event bus core with buffered channel, fan-out, panic recovery
- Telegram subscriber with HTML formatting and rate limiting
- Email subscriber with SMTP/TLS/STARTTLS support and stage diagnostics
- 5 event types: outbound.down/up, xray.crash, cpu.high, login.attempt
- CPU threshold checks per subscriber (tgCpu for TG, smtpCpu for Email)
- SystemMetricData struct for raw metric values in events
- i18n keys for en-US, ru-RU, and English defaults for other locales
* fix
* fix(notifications): repair crash/CPU alerts, harden secrets, add node alerts
Bug fixes:
- Xray crash notifications were permanently suppressed after the first crash:
XrayStateTracker latched state="down" with no reset and no recovery event,
so only the first crash per process lifetime ever notified. Removed the
tracker; the existing 1/min rate limiter already dedupes crash-loop spam.
- Email CPU alerts could never fire unless Telegram was also enabled, because
the CPU job was registered only inside the tgbot block. Register it whenever
either Telegram or SMTP wants cpu.high (new cpuAlarmWanted gate) and relax
the cadence to @every 1m (cpu.Percent already samples over a full minute).
- SMTP password (and, pre-existing, all other secrets) were shipped to the
browser in plaintext: GetAllSettingView was dead code and /setting/all
returned the raw model. Wire getAllSetting -> GetAllSettingView, redact
smtpPassword with a hasSmtpPassword presence flag, and preserve it on blank
save. Closes the leak for tgBotToken/ldapPassword/2FA token too.
Polish:
- email Send: use nil SMTP auth when no credentials (Go refuses PlainAuth over
the unencrypted "none" transport).
- Remove unused EventClientDepleted; fix inaccurate bus.go doc comments; drop
stale tgBotLoginNotify from the frontend schema; gofmt alignment.
Feature - node online/offline alerts:
- Emit node.down/node.up from the heartbeat job on a real status transition
(with a startup-spam guard), reusing NodeHealthData. Formatted by both the
Telegram and email subscribers and selectable in the settings UI.
Regenerated frontend types (hasSmtpPassword). New i18n keys added to en-US;
other locales fall back to English (bundle default) until translated.
* fix(settings): use antd Space orientation instead of deprecated direction
Ant Design 6 deprecated Space's `direction` prop in favor of `orientation`,
which logged a console warning from the Telegram/Email notification tabs. Brings
these two tabs in line with the rest of the codebase, which already uses
`orientation`.
* i18n(notifications): translate the notification feature into all locales
The notifications PR shipped ~99 new strings (SMTP settings, event labels,
Telegram/email message templates) as English placeholders in every non-English
locale. Translate them — plus the node-alert keys added during this review —
into all 12 locales: Arabic, Spanish, Persian, Indonesian, Japanese,
Portuguese-BR, Russian, Turkish, Ukrainian, Vietnamese, and Simplified/
Traditional Chinese.
Go-template placeholders ({{ .Tag }}, {{ .Name }}, etc.) are preserved exactly;
tgbot message values carry no leading status emoji (the bot/email code adds
those, so an emoji in the value would duplicate it); product/protocol names
(SMTP, STARTTLS, TLS, CPU, Xray, Telegram) are kept as-is.
---------
Co-authored-by: Sanaei <ho3ein.sanaei@gmail.com>
124 lines
2.9 KiB
Go
124 lines
2.9 KiB
Go
package eventbus
|
|
|
|
import (
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/mhsanaei/3x-ui/v3/internal/logger"
|
|
)
|
|
|
|
// DefaultBufferSize is the number of events the bus can hold before Publish starts dropping.
|
|
const DefaultBufferSize = 256
|
|
|
|
// subscriber pairs an ID with its event handler.
|
|
type subscriber struct {
|
|
id string
|
|
handler func(Event)
|
|
}
|
|
|
|
// Bus is a minimal in-process pub/sub event bus backed by a buffered channel.
|
|
// Producers call Publish (non-blocking) and every event is fanned out to all
|
|
// subscribers; per-event filtering is the subscriber's responsibility.
|
|
type Bus struct {
|
|
ch chan Event
|
|
subs []subscriber
|
|
mu sync.RWMutex
|
|
done chan struct{}
|
|
wg sync.WaitGroup
|
|
}
|
|
|
|
// New creates a Bus with the given buffer size. Use 0 for DefaultBufferSize.
|
|
func New(bufSize int) *Bus {
|
|
if bufSize <= 0 {
|
|
bufSize = DefaultBufferSize
|
|
}
|
|
b := &Bus{
|
|
ch: make(chan Event, bufSize),
|
|
done: make(chan struct{}),
|
|
}
|
|
b.wg.Add(1)
|
|
go b.dispatch()
|
|
return b
|
|
}
|
|
|
|
// Subscribe registers a handler that receives every published event.
|
|
// The id is used for Unsubscribe; it must be unique across active subscribers.
|
|
// Subscribing with an already-registered id replaces the previous handler.
|
|
func (b *Bus) Subscribe(id string, handler func(Event)) {
|
|
b.mu.Lock()
|
|
defer b.mu.Unlock()
|
|
for i, s := range b.subs {
|
|
if s.id == id {
|
|
b.subs[i].handler = handler
|
|
return
|
|
}
|
|
}
|
|
b.subs = append(b.subs, subscriber{id: id, handler: handler})
|
|
}
|
|
|
|
// Unsubscribe removes a subscriber by id. Safe to call with unknown id.
|
|
func (b *Bus) Unsubscribe(id string) {
|
|
b.mu.Lock()
|
|
defer b.mu.Unlock()
|
|
for i, s := range b.subs {
|
|
if s.id == id {
|
|
b.subs = append(b.subs[:i], b.subs[i+1:]...)
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// Publish sends an event to all subscribers. Non-blocking — if the buffer is
|
|
// full the event is dropped and a warning is logged.
|
|
func (b *Bus) Publish(e Event) {
|
|
if e.Timestamp.IsZero() {
|
|
e.Timestamp = time.Now()
|
|
}
|
|
select {
|
|
case b.ch <- e:
|
|
default:
|
|
logger.Warning("eventbus: buffer full, dropping event ", e.Type)
|
|
}
|
|
}
|
|
|
|
// dispatch is the fan-out loop. It reads events from the channel and calls
|
|
// every subscriber's handler sequentially. Handlers run on the dispatch
|
|
// goroutine — they must not block.
|
|
func (b *Bus) dispatch() {
|
|
defer b.wg.Done()
|
|
for {
|
|
select {
|
|
case e, ok := <-b.ch:
|
|
if !ok {
|
|
return
|
|
}
|
|
b.mu.RLock()
|
|
subs := make([]subscriber, len(b.subs))
|
|
copy(subs, b.subs)
|
|
b.mu.RUnlock()
|
|
for _, s := range subs {
|
|
safeCall(s.handler, e)
|
|
}
|
|
case <-b.done:
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// safeCall invokes handler with panic recovery.
|
|
func safeCall(fn func(Event), e Event) {
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
logger.Errorf("eventbus: subscriber panicked on %s: %v", e.Type, r)
|
|
}
|
|
}()
|
|
fn(e)
|
|
}
|
|
|
|
// Stop shuts down the bus: the dispatch goroutine exits, in-flight handlers
|
|
// finish, and any events still buffered may be dropped. Safe to call once.
|
|
func (b *Bus) Stop() {
|
|
close(b.done)
|
|
b.wg.Wait()
|
|
}
|