Files
3x-ui/internal/web/service/global_traffic_test.go
T
Sanaei 679d2e1cca fix: resolve a batch of open bug-tagged issues (traffic accounting, share strategy, sub address, CPU) (#5477)
* fix(node): never re-add a node's full counter on reset/restart (#5456, #5476, #5390)

When a node's per-client counter dips below the master's stored baseline
(node reboot, xray restart, or a reset propagated to the node), the delta
accounting clamped delta to the node's whole current counter and re-added it
to the master total — double-counting a client's lifetime usage in a single
sync and often pushing them over quota. Treat a backward-moving counter as a
reset: add 0 and rebaseline to the reported value, so only genuine post-reset
usage accrues.

Resets also now clear the per-node NodeClientTraffic baseline (ResetClient
TrafficByEmail, resetClientTrafficLocked, BulkResetTraffic, resetAllClient
TrafficsLocked), mirroring the delete paths. Without this the node's pre-reset
cumulative — including traffic it had counted but not yet synced — leaks back
onto the master after a reset, which is the 'reset reverts after a while'
report. The next sync then takes the clean delta=0 + rebaseline path regardless
of node state.

Updates TestNodeCounterReset (was _Clamped, now _NoReAdd) to assert rebaseline
instead of re-add, and adds TestCentralResetClearsNodeBaseline_NoLeak.

* fix(inbound): keep persisted node share strategy on edit (#5375)

Opening the edit modal silently reverted shareAddrStrategy from 'node' to
'listen'. The downgrade effect fires before the form settles: availableNodes
is an empty placeholder until /nodes/list resolves, and Form.useWatch('protocol')
is briefly empty on the first edit render — both transiently make the node
option look unavailable, so the effect clobbered the saved value.

Gate the downgrade on availableNodesFetched (threaded from useNodesQuery through
InboundsPage) and on the protocol watch being settled, so a persisted strategy
is only downgraded when the node option is genuinely unavailable. Adds a
rerender-based regression test covering the nodes-loading race.

* <3

* perf(traffic): skip cross-panel quota subquery when no globals exist (#5392, #5389)

disableInvalidClients ran a correlated EXISTS against client_global_traffics
on the full client_traffics table every 5s. On a panel no master pushes to,
that table is empty so the subquery can never match — yet it forced a full
scan that pegged Postgres at 100% CPU on large client counts. Probe the table
first and drop the EXISTS branch when it's empty (the common case), and add an
idx_client_global_email index so the subquery is an index lookup when globals
are present. Cross-panel enforcement is unchanged (TestGlobalUsage_DisablesClient).

This also relieves #5389 ('traffic writer queue full' / panel freeze): the
heavy query runs inside the serialized traffic write, so a slow DB backs the
shared writer queue up until request handlers block.

* fix(sub): don't advertise a leaked client IP for local wildcard inbounds (#5425)

For a local inbound with no node, no custom share address, and a wildcard/blank
listen, resolveInboundAddress fell straight through to the subscriber's request
host. Behind NAT/proxy/CDN that Host can be the requesting client's own IP, so
the subscription wrote the client's address into the inbound instead of the
server's — while the panel's own share link (which doesn't use the request host)
stayed correct.

Prefer the admin's configured public host (Sub/Web domain) over the raw request
host for this last-resort fallback. With no configured host the request host
still stands, so existing single-domain setups are unaffected.
2026-06-22 00:22:28 +02:00

169 lines
5.9 KiB
Go

package service
import (
"testing"
"github.com/mhsanaei/3x-ui/v3/internal/database"
"github.com/mhsanaei/3x-ui/v3/internal/database/model"
"github.com/mhsanaei/3x-ui/v3/internal/xray"
)
func seedClientRow(t *testing.T, email string, inboundId int, up, down, total int64) {
t.Helper()
db := database.GetDB()
if err := db.Create(&xray.ClientTraffic{InboundId: inboundId, Email: email, Enable: true, Up: up, Down: down, Total: total}).Error; err != nil {
t.Fatalf("seed client_traffics %q: %v", email, err)
}
}
func TestAcceptGlobalTraffic_SideTableOnly(t *testing.T) {
db := initTrafficTestDB(t)
svc := &InboundService{}
seedClientRow(t, "alice", 1, 100, 100, 0)
err := svc.AcceptGlobalTraffic("master-a", []*xray.ClientTraffic{
{Email: "alice", Up: 900, Down: 800},
{Email: "ghost", Up: 5, Down: 5}, // not hosted here — must be dropped
})
if err != nil {
t.Fatalf("AcceptGlobalTraffic: %v", err)
}
local := readTraffic(t, db, "alice")
if local.Up != 100 || local.Down != 100 {
t.Errorf("local counters must stay pure, got up=%d down=%d", local.Up, local.Down)
}
var globals []model.ClientGlobalTraffic
if err := db.Find(&globals).Error; err != nil {
t.Fatalf("read globals: %v", err)
}
if len(globals) != 1 || globals[0].Email != "alice" || globals[0].Up != 900 || globals[0].Down != 800 {
t.Errorf("unexpected globals: %+v", globals)
}
}
func TestAcceptGlobalTraffic_OverwriteAndMultiMaster(t *testing.T) {
db := initTrafficTestDB(t)
svc := &InboundService{}
seedClientRow(t, "alice", 1, 0, 0, 0)
must := func(guid string, up, down int64) {
t.Helper()
if err := svc.AcceptGlobalTraffic(guid, []*xray.ClientTraffic{{Email: "alice", Up: up, Down: down}}); err != nil {
t.Fatalf("AcceptGlobalTraffic(%s): %v", guid, err)
}
}
must("master-a", 900, 900)
must("master-a", 50, 50) // a master-side reset propagates by overwrite
must("master-b", 500, 400)
rows := []*xray.ClientTraffic{{Email: "alice", Up: 10, Down: 10}}
overlayGlobalTraffic(db, rows)
if rows[0].Up != 500 || rows[0].Down != 400 {
t.Errorf("overlay should fold per-master max, got up=%d down=%d", rows[0].Up, rows[0].Down)
}
}
func TestDepletedCond_ProbeGuard(t *testing.T) {
db := initTrafficTestDB(t)
svc := &InboundService{}
// No global rows: the cross-panel EXISTS branch is skipped (#5392), but a
// client over its local quota is still disabled.
if got := depletedCond(db); got != depletedClientsCondLocal {
t.Fatalf("empty globals must use the local-only predicate")
}
seedClientRow(t, "local-cap", 1, 600, 600, 1000)
if _, count, _, err := svc.disableInvalidClients(db); err != nil {
t.Fatalf("disableInvalidClients: %v", err)
} else if count != 1 {
t.Fatalf("local over-quota client must be disabled, disabled %d", count)
}
// Once a master pushes a global row, the full predicate is used so combined
// quota is enforced.
if err := svc.AcceptGlobalTraffic("master-a", []*xray.ClientTraffic{{Email: "local-cap", Up: 1, Down: 1}}); err != nil {
t.Fatalf("AcceptGlobalTraffic: %v", err)
}
if got := depletedCond(db); got != depletedClientsCond {
t.Fatalf("with globals present the cross-panel predicate must be used")
}
}
func TestGlobalUsage_DisablesClient(t *testing.T) {
db := initTrafficTestDB(t)
svc := &InboundService{}
// 200 of 1000 used locally — local check alone would never trip.
seedClientRow(t, "cap", 1, 100, 100, 1000)
if err := svc.AcceptGlobalTraffic("master-a", []*xray.ClientTraffic{{Email: "cap", Up: 800, Down: 700}}); err != nil {
t.Fatalf("AcceptGlobalTraffic: %v", err)
}
if _, count, _, err := svc.disableInvalidClients(db); err != nil {
t.Fatalf("disableInvalidClients: %v", err)
} else if count != 1 {
t.Fatalf("expected 1 client disabled, got %d", count)
}
if got := readTraffic(t, db, "cap"); got.Enable {
t.Error("client should be disabled by global usage exceeding its quota")
}
}
func TestGlobalRows_ClearedOnReset(t *testing.T) {
db := initTrafficTestDB(t)
svc := &InboundService{}
seedClientRow(t, "alice", 1, 50, 50, 1000)
if err := svc.AcceptGlobalTraffic("master-a", []*xray.ClientTraffic{{Email: "alice", Up: 999, Down: 999}}); err != nil {
t.Fatalf("AcceptGlobalTraffic: %v", err)
}
if err := svc.ResetClientTrafficByEmail("alice"); err != nil {
t.Fatalf("ResetClientTrafficByEmail: %v", err)
}
var cnt int64
db.Model(&model.ClientGlobalTraffic{}).Count(&cnt)
if cnt != 0 {
t.Errorf("global rows should be cleared on reset, found %d", cnt)
}
}
// The full inbound list doubles as the traffic snapshot masters poll, so it
// must report pure local counters; the slim list only feeds this panel's UI,
// so it carries the cross-panel overlay.
func TestSnapshotListNotOverlaid_SlimOverlaid(t *testing.T) {
db := initTrafficTestDB(t)
svc := &InboundService{}
settings := `{"clients": [{"email": "alice", "enable": true}]}`
ib := &model.Inbound{UserId: 1, Tag: "in-a", Enable: true, Port: 42001, Protocol: model.VLESS, Settings: settings}
if err := db.Create(ib).Error; err != nil {
t.Fatalf("create inbound: %v", err)
}
seedClientRow(t, "alice", ib.Id, 100, 100, 0)
if err := svc.AcceptGlobalTraffic("master-a", []*xray.ClientTraffic{{Email: "alice", Up: 900, Down: 900}}); err != nil {
t.Fatalf("AcceptGlobalTraffic: %v", err)
}
full, err := svc.GetInbounds(1)
if err != nil {
t.Fatalf("GetInbounds: %v", err)
}
if len(full) != 1 || len(full[0].ClientStats) != 1 {
t.Fatalf("unexpected full list shape: %d inbounds", len(full))
}
if full[0].ClientStats[0].Up != 100 {
t.Errorf("full list (master snapshot) must stay un-overlaid, got up=%d", full[0].ClientStats[0].Up)
}
slim, err := svc.GetInboundsSlim(1)
if err != nil {
t.Fatalf("GetInboundsSlim: %v", err)
}
if len(slim) != 1 || len(slim[0].ClientStats) != 1 {
t.Fatalf("unexpected slim list shape: %d inbounds", len(slim))
}
if slim[0].ClientStats[0].Up != 900 {
t.Errorf("slim list should carry the global overlay, got up=%d", slim[0].ClientStats[0].Up)
}
}