Sanaei f072d0448d fix(clients): flag the restart a partly-applied edit or delete still needs ...

63b46cd6 made a multi-inbound client op apply its inbounds concurrently and
stop aborting at the first failure, so an error can now come back together
with needRestart=true: the inbounds that succeeded committed real changes and
their Xray still needs the restart. That commit taught the two callers it
converted — create and attach — to read the flag before the error check.

d34ec97f then routed Update, Delete, Detach and DeleteByEmail's record-less
fallback through the same fanout but touched no caller, so on a master with
several nodes a partly-applied edit or delete returned (true, err) into a
handler that returned on err first. Xray was never flagged for the work that
landed and notifyClientsChanged never fired, so the running config kept
serving the pre-edit client set and every open panel showed stale rows until
something else happened to trigger a restart.

Read needRestart before the error check in update, delete and detach, and
broadcast on needRestart || err == nil — the same shape create and attach have
had since 63b46cd6. The predicate is a strict superset of the old err == nil,
and needRestart is only ever assigned after a runSerializedTx commit, so it
firing genuinely means something landed.

The three handlers are pinned by a new controller test each: one client on two
inbounds, the second one's settings JSON corrupted so the op commits on one and
fails on the other, asserting both the success:false response and the restart
flag. All three fail without the change.

The API docs for update, del and detach now describe the partial-application
contract, as add and attach already did. Detach ends at the fanout so every one
of its errors carries the inbound prefix; update and delete write the client
record afterwards, and a failure there is reported without one.

2026-09-07 01:51:01 +02:00

..

CNAME

docs: vendor the documentation site into the monorepo

2026-07-07 23:07:14 +02:00

favicon.png

docs: vendor the documentation site into the monorepo

2026-07-07 23:07:14 +02:00

icon.png

docs: vendor the documentation site into the monorepo

2026-07-07 23:07:14 +02:00

logo-dark.png

docs: vendor the documentation site into the monorepo

2026-07-07 23:07:14 +02:00

logo-light.png

docs: vendor the documentation site into the monorepo

2026-07-07 23:07:14 +02:00

openapi.json

fix(clients): flag the restart a partly-applied edit or delete still needs

2026-09-07 01:51:01 +02:00