mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-06-28 00:24:19 +00:00
n0ctal
f63ed9f510
A panic in a goroutine without a recover takes the whole panel down. The per-node heartbeat and traffic-sync goroutines run remote network I/O for each node with no panic isolation, so one misbehaving node could crash the master. Add common.GoRecover(name, fn), which runs fn in a goroutine guarded by a recover that logs the panic with a stack trace instead of crashing, and use it for the per-node heartbeat, traffic-sync and global-push goroutines. The deferred WaitGroup/semaphore releases still run during panic unwind, so the group never stalls. Other background goroutines can adopt the same helper.
42 lines
854 B
Go
42 lines
854 B
Go
package common
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/mhsanaei/3x-ui/v3/internal/logger"
|
|
"github.com/op/go-logging"
|
|
)
|
|
|
|
func TestMain(m *testing.M) {
|
|
logger.InitLogger(logging.ERROR)
|
|
os.Exit(m.Run())
|
|
}
|
|
|
|
func TestGoRecover_RunsFn(t *testing.T) {
|
|
done := make(chan struct{})
|
|
GoRecover("test-run", func() { close(done) })
|
|
select {
|
|
case <-done:
|
|
case <-time.After(2 * time.Second):
|
|
t.Fatal("fn did not run")
|
|
}
|
|
}
|
|
|
|
func TestGoRecover_RecoversPanic(t *testing.T) {
|
|
done := make(chan struct{})
|
|
// If GoRecover did not recover, this panic would crash the test binary.
|
|
GoRecover("test-panic", func() {
|
|
defer close(done)
|
|
panic("boom")
|
|
})
|
|
select {
|
|
case <-done:
|
|
case <-time.After(2 * time.Second):
|
|
t.Fatal("goroutine did not complete")
|
|
}
|
|
// Let the deferred recover+log run before the test ends.
|
|
time.Sleep(50 * time.Millisecond)
|
|
}
|