mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-06-02 03:55:55 +00:00
Feat/test build (#2174)
* fix(ci): update unit-test workflow paths to match current source layout Replace stale pkg/** filter with src/langbot/** and add uv.lock. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs(tests): update README to reflect current test layout - Fix stale paths: tests/pipeline → tests/unit_tests/pipeline - Update CI Python versions: 3.11, 3.12, 3.13 - Add test directory structure for box, config, platform, plugin, provider, storage - Document pytest markers and uv commands - Mention planned E2E tests Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add shared test factories package Create tests/factories/ with reusable test factories: - FakeApp: mock application with all dependencies - Message chains: text_chain, mention_chain, image_chain - Query factories: text_query, group_text_query, command_query, etc. No test changes - maintains backward compatibility. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add fake provider factory Add tests/factories/provider.py with: - FakeProvider: deterministic fake LLM provider - Error simulation: timeout, auth, rate-limit, malformed - Request capture for assertions - fake_model: mock model with attached provider Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add fake platform factory Add tests/factories/platform.py with: - FakePlatform: simulated platform adapter - Inbound message construction: friend/group/image - Mention-bot flag simulation - Outbound message capture for assertions - Streaming output support simulation - Send failure simulation Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add comprehensive message/query factories Extend tests/factories/message.py with: - file_query: file attachment query - unsupported_query: unknown message segment - voice_query: audio/voice query - at_all_query: group @All mention - query_with_session: query with session object - query_with_config: query with custom pipeline config Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add fake message flow smoke test Create tests/smoke/test_fake_message_flow.py: - TestFakeMessageFlow: factory verification tests - TestMessageFlowIntegration: minimal flow smoke test - Tests FakeApp, FakeProvider, FakePlatform, query factories - Verifies LANGBOT_FAKE_PONG marker response - Captures outbound messages for assertions Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add developer test-quick command Add scripts/test-quick.sh and Makefile with: - test-quick: runs ruff check + unit tests + smoke tests - No real provider keys or platform accounts required - Suitable for local branch self-test Update tests/README.md: - Document test-quick command - Document test factories package - Add smoke tests and factories directory structure Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(test): make test-quick reliable as developer gate Fixes for D-001验收问题: 1. test-quick.sh: use set -euo pipefail, uv run ruff, no tail pipe 2. Remove unused imports in factories (app.py, platform.py, provider.py) 3. Fix unused variable in smoke test 4. Add noqa: E402 to test_n8nsvapi.py lazy imports 5. Update smoke test docs: "minimal fake flow" not full pipeline Now test-quick is a reliable gate: lint failures exit 1, test failures propagate. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(unit): add preproc and taskmgr unit tests U-001: Pipeline Preprocessor tests - Normal text message processing - Empty message handling - Image segment with/without vision model - Model selection and fallback - Variable extraction U-004: Core Task Manager tests (pattern-based) - Task creation and tracking patterns - Task cancellation patterns - Scope-based cancellation - Task type filtering - Pruning completed tasks - Wait all tasks Taskmgr tests use pattern-based approach to avoid circular import in source code (taskmgr → app → http_controller → migration → taskmgr). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(unit): add config loader unit tests U-005: Config Loader tests - Valid YAML config loading - Valid JSON config loading - Invalid YAML/JSON error behavior - Missing config file creation from template - Template completion for missing keys - ConfigManager load/dump operations - Exists check for both YAML and JSON All tests use tmp_path fixture, no real project config. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(unit): add chat and command handler pattern tests U-002: Chat Handler tests (pattern-based) - Normal message event emission pattern - prevent_default handling - User message alteration pattern - Runner selection pattern - Streaming/non-streaming response patterns - Exception handling modes (show-error, show-hint, hide) - Message history update pattern - Telemetry payload pattern U-003: Command Handler tests (pattern-based) - Command parsing and text extraction - Event creation pattern - Privilege/admin check pattern - Command result handling (text, error, image) - prevent_default handling - String truncation helper Uses pattern-based testing to avoid circular import issues in source code. Direct imports of handler modules trigger circular import chain. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * style: fix unused imports after ruff auto-fix Remove unused imports in test files: - test_config_loader.py: remove unused os - test_taskmgr.py: remove unused Mock - test_preproc.py: remove unused unsupported_query, image_chain Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(unit): improve taskmgr tests to test real classes U-004 improved: Tests now import and test actual classes: - TaskContext: new(), trace(), to_dict(), placeholder() - TaskWrapper: task creation, context, exception/result capture, cancel, to_dict - AsyncTaskManager: create_task, create_user_task, cancel_task, cancel_by_scope - Task pruning behavior Uses pre-mocking technique: - Mock langbot.pkg.core.app before import (breaks circular chain) - Mock langbot.pkg.core.entities with proper Enum All 24 tests now test real class behavior, not patterns. taskmgr.py coverage should improve significantly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(test): consolidate FakeApp and add sys.modules isolation utility - Extract tests/utils/import_isolation.py with isolated_sys_modules context manager - Extend tests/factories/app.py FakeApp with handler-specific attributes - Refactor test_chat_handler.py to use centralized FakeApp and cached imports - Refactor test_command_handler.py with mock_execute_factory fixture - Refactor test_smoke.py to move import-time sys.modules manipulation into fixture - Add SQLite migration integration tests (G-002) - Add HTTP API smoke integration tests (G-005) - Update CI workflow to call pytest for SQLite migrations (G-004) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add developer quality gate consolidation (G-007) - Add scripts/test-integration-fast.sh for fast integration tests - Add scripts/test-coverage.sh with 12% baseline threshold - Update Makefile with test-integration-fast, test-coverage, test-all-local - Update CI workflow with integration and coverage jobs - Add smoke marker to pytest.ini - Update tests/README.md with quality gate layers documentation - Add tests/integration/pipeline/ for pipeline stage-chain tests Quality gate layers: - Quick: ruff + unit + smoke (~2 min) - Fast Integration: SQLite/API/Pipeline (~3 min) - Coverage: 12% threshold gate (~8 min) - Full Local: all three combined Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add PostgreSQL migration slow integration tests (G-003) - Add tests/integration/persistence/test_migrations_postgres.py - All tests marked with @pytest.mark.slow - Tests skip when TEST_POSTGRES_URL is not set (no local PostgreSQL) - Database isolation via clean_tables and clean_alembic_version fixtures - Update CI workflow to use pytest instead of inline Python script - Remove TODO(G-003) comment - Update tests/README.md with PostgreSQL test documentation Covered scenarios: - Baseline stamp sets revision - Upgrade from baseline to head - Upgrade idempotent - Get current on unstamped DB returns None Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): Phase 1.5 coverage expansion - COV-001 to COV-013 Coverage baseline raised from 13.65% to 26% (+12.35%) Gate raised from 12% to 18% Tasks completed: - COV-001: Command system unit tests (100% coverage) - COV-002: API service unit tests batch 1 (user/apikey/model/provider) - COV-003: Provider model manager unit tests - COV-004: Pipeline remaining stage tests (aggregator/cntfilter/longtext/msgtrun) - COV-005: Storage and utils coverage pass - COV-006: Gate ratchet 12%→15% - COV-007: Gate ratchet 15%→18% - COV-008: API service batch 2 (bot/pipeline/webhook/space/maintenance/mcp) - COV-009: Blocked - API controller circular import issue documented - COV-010: Plugin runtime unit tests (+0.08%) - COV-011: RAG and vector unit tests (+0.68%) - COV-012: Core boot and migration unit tests - COV-013: Provider requester logic unit tests (+0.62%) Key additions: - tests/utils/import_isolation.py: sys.modules isolation for circular imports - Provider requester mock tests: proved HTTP-dependent code can be tested locally - Vector filter utilities: 100% coverage on pure functions - API services: fake persistence pattern for unit testing Blocked issue COV-009 documented in langbot-test-plan/1.5/issues/ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(phase1): add unit tests for telemetry, plugin, rag, persistence Add initial unit tests for Phase 1 of test coverage improvement: - telemetry: test initialization, payload sanitization, early returns (14.3% → 62.9%) - plugin: test _parse_plugin_id static method - rag: test _to_i18n_name static method - persistence: test serialize_model with datetime handling Overall core coverage: 41.9% → 42.2% Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(phase2): add unit tests for core, persistence, plugin, utils - Add test_handler_helpers.py for plugin handler helpers (7 tests) - Add test_mgr_methods.py for persistence manager (5 tests) - Add test_app_config_validation.py for core app config (12 tests) - Add test_knowledge_service.py for API knowledge service (22 tests) - Add test_kbmgr.py for RAG knowledge base manager (39 tests) - Add test_survey_manager.py for survey manager (22 tests) - Add test_connector_methods.py for plugin connector (24 tests) - Add test_funcschema.py for utils function schema (9 tests) - Add test_platform.py for utils platform detection (7 tests) - Add test_extract_deps.py for plugin deps extraction (7 tests) - Add test_database_decorator.py for persistence decorator (7 tests) - Add test_load_config.py for core config loading (19 tests) - Add COVERAGE_EXCLUSIONS.md documenting external adapter exclusions - Fix test_chat_session_limit.py path for portability Coverage: core 28% → 30%, persistence 24% → 24.4%, plugin 27% → 28% Total: 1082 tests passed, core module coverage 45.5% Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(integration): add API controller integration tests - Add test_pipelines.py (10 tests) covering pipelines CRUD operations - GET/POST/PUT/DELETE on /api/v1/pipelines - Extensions endpoint - Metadata endpoint - Coverage: pipelines controller 27% → 80% - Add test_providers.py (10 tests) covering provider/model management - Provider CRUD with model counts - LLM model CRUD - Coverage: providers controller 23% → 81%, models 29% → 45% Tests use Quart TestClient with mocked services for real HTTP behavior without external dependencies. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(integration): add knowledge, bots, and model endpoints tests - Add test_knowledge.py (10 tests) covering knowledge base management - CRUD operations on /api/v1/knowledge/bases - Files management endpoints - Retrieve endpoint with validation - Coverage: knowledge/base.py 26% → 91% - Add test_bots.py (9 tests) covering bot management - CRUD operations on /api/v1/platform/bots - Logs endpoint - Send message endpoint with validation - Coverage: platform/bots.py 24% → 87% - Extend test_providers.py (+4 tests) for embedding/rerank models - Embedding models CRUD - Rerank models CRUD - Coverage: provider/models.py 29% → 60% Total integration tests: 53 (smoke 12 + pipelines 10 + providers 14 + knowledge 10 + bots 9) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(integration): add embed and monitoring endpoint tests Add integration tests for embed widget and monitoring API endpoints: - test_embed.py: 15 tests for widget.js, logo, turnstile, messages, reset, feedback - test_monitoring.py: 15 tests for overview, messages, llm-calls, sessions, errors, export Coverage improvements: - embed.py: 17% → 56% - monitoring.py: 17% → 93% Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(e2e): add minimal startup E2E tests Add E2E tests for LangBot startup flow: - tests/e2e/utils/config_factory.py: minimal config generation - tests/e2e/utils/process_manager.py: LangBot subprocess management - tests/e2e/conftest.py: E2E fixtures (session-scoped process) - tests/e2e/test_startup.py: 12 tests for startup verification Tests verify: - boot.py + stages execution - database initialization (SQLite) - API availability - migrations applied Uses embedded databases (SQLite, Chroma) - no external dependencies. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(quality): fix fake tests and add missing coverage P0 fixes: - telemetry: rewrite fake tests with real behavior verification (25 tests) - config: delete copied-source tests, use proper imports (2 deleted) - persistence: fix try-except pass to verify specific errors P1 fixes: - pipeline: add real FixedWindowAlgo tests instead of mocks (12 tests) - provider: add SessionManager and ToolManager tests (25 tests) - storage: add S3StorageProvider tests with moto mock (16 tests) - plugin: add handler action tests for setting inheritance (15 tests) - rag: add file storage and ZIP processing tests (21 tests) - vector: add VDB filter conversion tests (30 tests) P2 fixes: - pipeline/msgtrun: strengthen assertions for exact message count - api: add response structure validation in integration tests New test files: - provider/test_session_manager.py - provider/test_tool_manager.py - storage/test_s3storage.py - plugin/test_handler_actions.py - rag/test_file_storage.py - vector/test_vdb_filter_conversion.py Source code bugs documented: - provider: TokenManager.next_token() ZeroDivisionError - telemetry: send_tasks class variable shared state - command: empty command IndexError, unused parameters - utils: funcschema KeyError - entity: vector.py independent declarative_base Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs(test): update coverage stats and test structure - Update coverage from 22% to 30% - Add new test files to structure: - provider: session_manager, tool_manager - storage: s3storage - plugin: handler_actions - rag: file_storage - vector: vdb_filter_conversion - telemetry: rewritten tests - Update module coverage percentages Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test: add 105 new unit tests for untested core functionality Add comprehensive tests for B-class issues (core functionality untested): Pipeline: - test_pool.py: QueryPool ID generation, caching, async context (12 tests) - test_ratelimit.py: Fixed timing-sensitive test tolerance - test_pipelinemgr.py: Use real Pydantic StageProcessResult instead of Mock Utils: - test_version.py: Version comparison functions (20 tests) - test_logcache.py: Log page management and retrieval (18 tests) - test_httpclient.py: HTTP session pool management (10 tests) - test_proxy.py: Proxy configuration from env and config (10 tests) - test_image.py: URL parsing and base64 extraction (12 tests) - test_pkgmgr.py: Pip command generation (8 tests) Discover: - test_engine.py: I18nString, Metadata, Component manifest (15 tests) Test count: 1193 → 1298 (+105 tests) Note: Some B-class issues cannot be tested due to circular import bugs filed as GitHub issues #2175 (pipeline) and #2176 (persistence). * test: tighten phase 1 coverage contracts * test: align ci integration isolation --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
huanghuoguoguo
201
tests/unit_tests/persistence/test_database_decorator.py
Normal file
201
tests/unit_tests/persistence/test_database_decorator.py
Normal file
@@ -0,0 +1,201 @@
|
||||
"""Unit tests for persistence database decorators.
|
||||
|
||||
Tests cover:
|
||||
- manager_class decorator registration
|
||||
- Class attribute setting
|
||||
- preregistered_managers list population
|
||||
|
||||
Note: Uses import isolation to break circular import chains.
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import sys
|
||||
from unittest.mock import Mock, MagicMock
|
||||
from contextlib import contextmanager
|
||||
from typing import Generator
|
||||
|
||||
|
||||
@contextmanager
|
||||
def isolated_database_import() -> Generator[None, None, None]:
|
||||
"""Context manager to isolate circular imports for database testing."""
|
||||
# Mock modules that cause circular imports
|
||||
mock_app = MagicMock()
|
||||
|
||||
mock_importutil = MagicMock()
|
||||
mock_importutil.import_modules_in_pkg = lambda pkg: None
|
||||
mock_importutil.import_modules_in_pkgs = lambda pkgs: None
|
||||
|
||||
mock_mgr = MagicMock()
|
||||
|
||||
mocks = {
|
||||
'langbot.pkg.core.app': mock_app,
|
||||
'langbot.pkg.utils.importutil': mock_importutil,
|
||||
'langbot.pkg.persistence.mgr': mock_mgr,
|
||||
}
|
||||
|
||||
# Save original state
|
||||
saved = {}
|
||||
for name in mocks:
|
||||
if name in sys.modules:
|
||||
saved[name] = sys.modules[name]
|
||||
|
||||
# Clear database module to force re-import
|
||||
database_name = 'langbot.pkg.persistence.database'
|
||||
if database_name in sys.modules:
|
||||
saved[database_name] = sys.modules[database_name]
|
||||
|
||||
# Also clear databases submodules
|
||||
for sub in ['sqlite', 'postgresql']:
|
||||
full_name = f'langbot.pkg.persistence.databases.{sub}'
|
||||
if full_name in sys.modules:
|
||||
saved[full_name] = sys.modules[full_name]
|
||||
|
||||
try:
|
||||
# Apply mocks
|
||||
for name, module in mocks.items():
|
||||
sys.modules[name] = module
|
||||
|
||||
# Clear database and submodules
|
||||
sys.modules.pop(database_name, None)
|
||||
for sub in ['sqlite', 'postgresql']:
|
||||
sys.modules.pop(f'langbot.pkg.persistence.databases.{sub}', None)
|
||||
|
||||
yield
|
||||
finally:
|
||||
# Restore
|
||||
for name in mocks:
|
||||
if name in saved:
|
||||
sys.modules[name] = saved[name]
|
||||
else:
|
||||
sys.modules.pop(name, None)
|
||||
|
||||
if database_name in saved:
|
||||
sys.modules[database_name] = saved[database_name]
|
||||
else:
|
||||
sys.modules.pop(database_name, None)
|
||||
|
||||
for sub in ['sqlite', 'postgresql']:
|
||||
full_name = f'langbot.pkg.persistence.databases.{sub}'
|
||||
if full_name in saved:
|
||||
sys.modules[full_name] = saved[full_name]
|
||||
else:
|
||||
sys.modules.pop(full_name, None)
|
||||
|
||||
|
||||
def get_database_module():
|
||||
"""Get database module with import isolation."""
|
||||
with isolated_database_import():
|
||||
from langbot.pkg.persistence import database
|
||||
return database
|
||||
|
||||
|
||||
class TestManagerClassDecorator:
|
||||
"""Tests for manager_class decorator."""
|
||||
|
||||
def test_decorator_sets_name_attribute(self):
|
||||
"""Test that decorator sets the 'name' attribute on class."""
|
||||
database = get_database_module()
|
||||
|
||||
# Clear preregistered_managers for this test
|
||||
database.preregistered_managers.clear()
|
||||
|
||||
@database.manager_class('test_db')
|
||||
class TestManager(database.BaseDatabaseManager):
|
||||
async def initialize(self):
|
||||
pass
|
||||
|
||||
assert TestManager.name == 'test_db'
|
||||
|
||||
def test_decorator_adds_to_preregistered_list(self):
|
||||
"""Test that decorator adds class to preregistered_managers."""
|
||||
database = get_database_module()
|
||||
|
||||
# Clear preregistered_managers for this test
|
||||
database.preregistered_managers.clear()
|
||||
|
||||
@database.manager_class('test_db2')
|
||||
class TestManager2(database.BaseDatabaseManager):
|
||||
async def initialize(self):
|
||||
pass
|
||||
|
||||
assert len(database.preregistered_managers) == 1
|
||||
assert database.preregistered_managers[0] == TestManager2
|
||||
|
||||
def test_decorator_returns_original_class(self):
|
||||
"""Test that decorator returns the same class."""
|
||||
database = get_database_module()
|
||||
|
||||
database.preregistered_managers.clear()
|
||||
|
||||
class OriginalClass(database.BaseDatabaseManager):
|
||||
async def initialize(self):
|
||||
pass
|
||||
|
||||
decorated = database.manager_class('test_db3')(OriginalClass)
|
||||
|
||||
assert decorated is OriginalClass
|
||||
|
||||
def test_multiple_decorators_register_separately(self):
|
||||
"""Test that multiple decorated classes register separately."""
|
||||
database = get_database_module()
|
||||
|
||||
database.preregistered_managers.clear()
|
||||
|
||||
@database.manager_class('db_a')
|
||||
class ManagerA(database.BaseDatabaseManager):
|
||||
async def initialize(self):
|
||||
pass
|
||||
|
||||
@database.manager_class('db_b')
|
||||
class ManagerB(database.BaseDatabaseManager):
|
||||
async def initialize(self):
|
||||
pass
|
||||
|
||||
assert len(database.preregistered_managers) == 2
|
||||
assert database.preregistered_managers[0].name == 'db_a'
|
||||
assert database.preregistered_managers[1].name == 'db_b'
|
||||
|
||||
def test_base_database_manager_has_name_annotation(self):
|
||||
"""Test that BaseDatabaseManager has name as class annotation."""
|
||||
database = get_database_module()
|
||||
|
||||
# BaseDatabaseManager has name annotation (type hint)
|
||||
# Check __annotations__ for the type hint
|
||||
assert 'name' in database.BaseDatabaseManager.__annotations__
|
||||
|
||||
def test_decorated_class_inherits_from_base(self):
|
||||
"""Test that decorated class properly inherits BaseDatabaseManager."""
|
||||
database = get_database_module()
|
||||
|
||||
database.preregistered_managers.clear()
|
||||
|
||||
@database.manager_class('test_inherit')
|
||||
class TestChild(database.BaseDatabaseManager):
|
||||
async def initialize(self):
|
||||
pass
|
||||
|
||||
assert issubclass(TestChild, database.BaseDatabaseManager)
|
||||
# Has abstract method requirement satisfied
|
||||
assert hasattr(TestChild, 'initialize')
|
||||
|
||||
def test_decorator_preserves_class_methods(self):
|
||||
"""Test that decorator preserves existing class methods."""
|
||||
database = get_database_module()
|
||||
|
||||
database.preregistered_managers.clear()
|
||||
|
||||
@database.manager_class('preserve_test')
|
||||
class ManagerWithMethods(database.BaseDatabaseManager):
|
||||
custom_attr = 'test_value'
|
||||
|
||||
async def initialize(self):
|
||||
pass
|
||||
|
||||
def custom_method(self):
|
||||
return self.custom_attr
|
||||
|
||||
assert ManagerWithMethods.custom_attr == 'test_value'
|
||||
# Create instance to test method (with mock app)
|
||||
mock_app = Mock()
|
||||
instance = ManagerWithMethods(mock_app)
|
||||
assert instance.custom_method() == 'test_value'
|
||||
155
tests/unit_tests/persistence/test_mgr_methods.py
Normal file
155
tests/unit_tests/persistence/test_mgr_methods.py
Normal file
@@ -0,0 +1,155 @@
|
||||
"""Unit tests for persistence manager methods.
|
||||
|
||||
Tests cover:
|
||||
- execute_async() with mock database
|
||||
- get_db_engine() with mock database manager
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import pytest
|
||||
from unittest.mock import Mock, AsyncMock, MagicMock
|
||||
from importlib import import_module
|
||||
import sqlalchemy
|
||||
|
||||
|
||||
def get_persistence_module():
|
||||
"""Lazy import to avoid circular import issues."""
|
||||
return import_module('langbot.pkg.persistence.mgr')
|
||||
|
||||
|
||||
class TestExecuteAsync:
|
||||
"""Tests for execute_async method."""
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_execute_async_calls_engine_execute(self):
|
||||
"""Test that execute_async calls engine execute."""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
mock_app = Mock()
|
||||
mock_app.persistence_mgr = None
|
||||
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
# Mock database manager with async engine
|
||||
mock_engine = MagicMock()
|
||||
mock_conn = AsyncMock()
|
||||
mock_conn.execute = AsyncMock(return_value=Mock())
|
||||
mock_conn.commit = AsyncMock()
|
||||
|
||||
# Setup the async context manager
|
||||
async_cm = AsyncMock()
|
||||
async_cm.__aenter__ = AsyncMock(return_value=mock_conn)
|
||||
async_cm.__aexit__ = AsyncMock(return_value=None)
|
||||
mock_engine.connect = Mock(return_value=async_cm)
|
||||
|
||||
mock_db = Mock()
|
||||
mock_db.get_engine = Mock(return_value=mock_engine)
|
||||
mgr.db = mock_db
|
||||
|
||||
# Execute a simple select
|
||||
await mgr.execute_async(sqlalchemy.select(1))
|
||||
|
||||
mock_conn.execute.assert_called_once()
|
||||
mock_conn.commit.assert_called_once()
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_execute_async_returns_result(self):
|
||||
"""Test that execute_async returns the result from execute.
|
||||
|
||||
NOTE: This test verifies the return value chain - that the result
|
||||
from conn.execute() is properly returned by execute_async().
|
||||
The mock verifies the value propagation, not the SQL execution.
|
||||
For real SQL execution tests, see integration tests.
|
||||
"""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
mock_app = Mock()
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
# Create a mock result with actual attributes to simulate real result
|
||||
mock_result = Mock(name='query_result')
|
||||
mock_result.scalar = Mock(return_value=1) # Simulate scalar() method
|
||||
mock_result.scalars = Mock() # Simulate scalars() method
|
||||
|
||||
mock_engine = MagicMock()
|
||||
mock_conn = AsyncMock()
|
||||
mock_conn.execute = AsyncMock(return_value=mock_result)
|
||||
mock_conn.commit = AsyncMock()
|
||||
|
||||
async_cm = AsyncMock()
|
||||
async_cm.__aenter__ = AsyncMock(return_value=mock_conn)
|
||||
async_cm.__aexit__ = AsyncMock(return_value=None)
|
||||
mock_engine.connect = Mock(return_value=async_cm)
|
||||
|
||||
mock_db = Mock()
|
||||
mock_db.get_engine = Mock(return_value=mock_engine)
|
||||
mgr.db = mock_db
|
||||
|
||||
result = await mgr.execute_async(sqlalchemy.text("SELECT 1"))
|
||||
|
||||
# Verify result is the same object returned by execute
|
||||
assert result is mock_result
|
||||
# Verify result has expected methods (simulating real Result object)
|
||||
assert hasattr(result, 'scalar')
|
||||
assert result.scalar() == 1
|
||||
|
||||
|
||||
class TestGetDbEngine:
|
||||
"""Tests for get_db_engine method."""
|
||||
|
||||
def test_get_db_engine_returns_engine_from_db_manager(self):
|
||||
"""Test that get_db_engine returns engine from db manager."""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
mock_app = Mock()
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
mock_engine = Mock(name='engine')
|
||||
mock_db = Mock()
|
||||
mock_db.get_engine = Mock(return_value=mock_engine)
|
||||
mgr.db = mock_db
|
||||
|
||||
engine = mgr.get_db_engine()
|
||||
|
||||
assert engine == mock_engine
|
||||
mock_db.get_engine.assert_called_once()
|
||||
|
||||
def test_get_db_engine_without_db_set_raises(self):
|
||||
"""Test that get_db_engine raises when db is not set."""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
mock_app = Mock()
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
# db is not initialized
|
||||
mgr.db = None
|
||||
|
||||
with pytest.raises(AttributeError):
|
||||
mgr.get_db_engine()
|
||||
|
||||
|
||||
class TestSerializeModelEdgeCases:
|
||||
"""Tests for serialize_model edge cases."""
|
||||
|
||||
def test_serialize_model_with_all_columns_masked(self):
|
||||
"""Test serialize_model when all columns are masked."""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
from sqlalchemy import Column, Integer, String
|
||||
from sqlalchemy.orm import declarative_base
|
||||
|
||||
Base = declarative_base()
|
||||
|
||||
class SimpleModel(Base):
|
||||
__tablename__ = 'simple'
|
||||
id = Column(Integer, primary_key=True)
|
||||
name = Column(String(50))
|
||||
|
||||
mock_app = Mock()
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
instance = SimpleModel(id=1, name='test')
|
||||
result = mgr.serialize_model(SimpleModel, instance, masked_columns=['id', 'name'])
|
||||
|
||||
# Result should be empty dict when all columns masked
|
||||
assert result == {}
|
||||
128
tests/unit_tests/persistence/test_serialize_model.py
Normal file
128
tests/unit_tests/persistence/test_serialize_model.py
Normal file
@@ -0,0 +1,128 @@
|
||||
"""Unit tests for persistence serialize_model function.
|
||||
|
||||
Tests cover:
|
||||
- serialize_model() with various column types
|
||||
- datetime conversion to isoformat
|
||||
- masked_columns exclusion
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import datetime
|
||||
from unittest.mock import Mock
|
||||
|
||||
from sqlalchemy import Column, Integer, String, DateTime
|
||||
from sqlalchemy.orm import declarative_base
|
||||
from importlib import import_module
|
||||
|
||||
|
||||
def get_persistence_module():
|
||||
"""Lazy import to avoid circular import issues."""
|
||||
return import_module('langbot.pkg.persistence.mgr')
|
||||
|
||||
|
||||
# Create a simple test model
|
||||
Base = declarative_base()
|
||||
|
||||
|
||||
class TestModel(Base):
|
||||
__tablename__ = 'test_model'
|
||||
id = Column(Integer, primary_key=True)
|
||||
name = Column(String(50))
|
||||
created_at = Column(DateTime)
|
||||
updated_at = Column(DateTime, nullable=True)
|
||||
|
||||
|
||||
class TestSerializeModel:
|
||||
"""Tests for serialize_model method."""
|
||||
|
||||
def test_serialize_string_and_int_columns(self):
|
||||
"""Test that string and int columns are serialized directly."""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
# Create a mock persistence manager
|
||||
mock_app = Mock()
|
||||
mock_app.persistence_mgr = None
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
# Create test model instance
|
||||
instance = TestModel(id=1, name='test_name', created_at=datetime.datetime(2024, 1, 15, 10, 30, 0))
|
||||
|
||||
result = mgr.serialize_model(TestModel, instance)
|
||||
|
||||
assert result['id'] == 1
|
||||
assert result['name'] == 'test_name'
|
||||
|
||||
def test_serialize_datetime_to_isoformat(self):
|
||||
"""Test that datetime columns are converted to isoformat string."""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
mock_app = Mock()
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
dt = datetime.datetime(2024, 1, 15, 10, 30, 45)
|
||||
instance = TestModel(id=1, name='test', created_at=dt)
|
||||
|
||||
result = mgr.serialize_model(TestModel, instance)
|
||||
|
||||
assert result['created_at'] == '2024-01-15T10:30:45'
|
||||
assert isinstance(result['created_at'], str)
|
||||
|
||||
def test_serialize_datetime_with_timezone(self):
|
||||
"""Test datetime with timezone conversion."""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
mock_app = Mock()
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
# datetime with timezone
|
||||
dt = datetime.datetime(2024, 1, 15, 10, 30, 45, tzinfo=datetime.timezone.utc)
|
||||
instance = TestModel(id=1, name='test', created_at=dt)
|
||||
|
||||
result = mgr.serialize_model(TestModel, instance)
|
||||
|
||||
assert '2024-01-15' in result['created_at']
|
||||
assert isinstance(result['created_at'], str)
|
||||
|
||||
def test_serialize_none_datetime(self):
|
||||
"""Test that None datetime column is serialized as None."""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
mock_app = Mock()
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
instance = TestModel(id=1, name='test', created_at=datetime.datetime.now(), updated_at=None)
|
||||
|
||||
result = mgr.serialize_model(TestModel, instance)
|
||||
|
||||
# None datetime should be None (not converted to isoformat)
|
||||
assert result['updated_at'] is None
|
||||
|
||||
def test_masked_columns_excluded(self):
|
||||
"""Test that masked columns are excluded from output."""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
mock_app = Mock()
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
instance = TestModel(id=1, name='secret_name', created_at=datetime.datetime.now())
|
||||
|
||||
result = mgr.serialize_model(TestModel, instance, masked_columns=['name'])
|
||||
|
||||
assert 'id' in result
|
||||
assert 'created_at' in result
|
||||
assert 'name' not in result
|
||||
|
||||
def test_masked_columns_multiple(self):
|
||||
"""Test that multiple masked columns are excluded."""
|
||||
persistence = get_persistence_module()
|
||||
|
||||
mock_app = Mock()
|
||||
mgr = persistence.PersistenceManager(mock_app)
|
||||
|
||||
instance = TestModel(id=1, name='secret', created_at=datetime.datetime.now())
|
||||
|
||||
result = mgr.serialize_model(TestModel, instance, masked_columns=['id', 'name'])
|
||||
|
||||
assert 'id' not in result
|
||||
assert 'name' not in result
|
||||
assert 'created_at' in result
|
||||
Reference in New Issue
Block a user