xinyin025/LangBot
1
0
Fork 0
mirror of https://github.com/langbot-app/LangBot.git synced 2026-08-13 06:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve code clarity and add documentation about in-place modification

Browse Source 
Co-authored-by: RockChinQ <45992437+RockChinQ@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-01-30 15:53:40 +00:00
parent 3fa7389ba9
commit 1e0275ee08
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/langbot/pkg/provider/modelmgr/requesters/geminichatcmpl.py
+7 -3
View File
@@ -25,6 +25,8 @@ class GeminiChatCompletions(chatcmpl.OpenAIChatCompletions):
Gemini API requires a thought_signature field in function call parts. Gemini API requires a thought_signature field in function call parts.
See: https://ai.google.dev/gemini-api/docs/thought-signatures See: https://ai.google.dev/gemini-api/docs/thought-signatures
Note: This function modifies the dictionaries in the messages list in place.
""" """
for msg in messages: for msg in messages:
if 'tool_calls' in msg and msg['tool_calls']: if 'tool_calls' in msg and msg['tool_calls']:
@@ -170,14 +172,16 @@ class GeminiChatCompletions(chatcmpl.OpenAIChatCompletions):
remove_think: bool = False, remove_think: bool = False,
) -> tuple[provider_message.Message, dict]: ) -> tuple[provider_message.Message, dict]:
"""Override _closure to add thought_signature to messages""" """Override _closure to add thought_signature to messages"""
# Make a shallow copy to avoid mutating the caller's list
messages = req_messages.copy()
# Add thought_signature to tool_calls for Gemini compatibility # Add thought_signature to tool_calls for Gemini compatibility
# Note: modifying in place is safe here as parent _closure will make a copy messages = self._add_thought_signature_to_messages(messages)
req_messages = self._add_thought_signature_to_messages(req_messages)
# Call parent implementation # Call parent implementation
return await super()._closure( return await super()._closure(
query=query, query=query,
req_messages=req_messages, req_messages=messages,
use_model=use_model, use_model=use_model,
use_funcs=use_funcs, use_funcs=use_funcs,
extra_args=extra_args, extra_args=extra_args,