xinyin025/LangBot
1
0
Fork 0
mirror of https://github.com/langbot-app/LangBot.git synced 2026-10-24 01:15:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(install-diagnostics): Sanitize plugin installation network diagnostics (LANG-132)

Browse Source
This commit is contained in:
Chin Rock
2026-10-20 07:53:56 +00:00
parent 1baba1b9f9
commit 40d40204cf
13 changed files with 165 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit_tests/api/service/test_pipeline_migration.py
+39
View File
@@ -962,3 +962,42 @@ async def test_missing_marketplace_release_has_specific_migration_result(env):
assert all(r['code'] == 'plugin_version_unavailable' for r in metadata['results'])
assert metadata['installations'][0]['code'] == 'plugin_version_unavailable'
assert 'private-token' not in str(metadata)
@pytest.mark.parametrize(
'kind', ['connect', 'connect_timeout', 'read_timeout', 'write_timeout', 'pool_timeout', 'truncated', 'http', 'other']
)
def test_network_diagnostic_is_allowlisted_and_credential_free(kind):
import httpx
from langbot.pkg.api.http.service.pipeline_migration import MigrationInstallContext
request = httpx.Request('GET', 'https://secret-user:[email protected]/package?token=private-token')
errors = {
'connect': httpx.ConnectError('private-token', request=request),
'connect_timeout': httpx.ConnectTimeout('private-token', request=request),
'read_timeout': httpx.ReadTimeout('private-token', request=request),
'write_timeout': httpx.WriteTimeout('private-token', request=request),
'pool_timeout': httpx.PoolTimeout('private-token', request=request),
'truncated': httpx.RemoteProtocolError('private-token', request=request),
'other': httpx.RequestError('private-token', request=request),
'http': httpx.HTTPStatusError(
'private-token', request=request, response=httpx.Response(503, request=request, text='private-token')
),
}
ctx = MigrationInstallContext({'author': 'team', 'name': 'Runner', 'version': '1'})
ctx.record_network_failure(errors[kind])
expected = {
'connect': 'connect_error',
'connect_timeout': 'connect_timeout',
'read_timeout': 'read_timeout',
'write_timeout': 'write_timeout',
'pool_timeout': 'pool_timeout',
'truncated': 'incomplete_response',
'http': 'http_status',
'other': 'network_error',
}
assert ctx.progress['diagnostic']['kind'] == expected[kind]
assert ctx.progress['diagnostic'].get('http_status') == (503 if kind == 'http' else None)
assert 'private-token' not in str(ctx.progress)
assert 'secret-' not in str(ctx.progress)
assert set(ctx.progress['diagnostic']) == ({'kind', 'http_status'} if kind == 'http' else {'kind'})