xinyin025/LangBot
1
0
Fork 0
mirror of https://github.com/langbot-app/LangBot.git synced 2026-08-09 04:40:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(runtime): bound tenant resource amplification

Browse Source
This commit is contained in:
Junyan Qin
2026-07-29 18:27:44 +08:00
parent e8d90c4259
commit 610915b9c5
32 changed files with 857 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit_tests/vector/test_valkey_search_filter.py
+50 -5
View File
@@ -268,9 +268,9 @@ class TestDeleteByFilterGuard:
backend.ap = type('Ap', (), {'logger': AsyncMock()})()
backend._ensure_client = AsyncMock(return_value=backend._client)
backend._index_exists = AsyncMock(return_value=True)
# _search_keys must never be reached for an unusable filter.
backend._search_keys = AsyncMock(
side_effect=AssertionError('_search_keys must not be called for an unusable filter')
# The deletion scan must never be reached for an unusable filter.
backend._delete_search_results = AsyncMock(
side_effect=AssertionError('_delete_search_results must not be called for an unusable filter')
)
# Filter references only a non-indexed field -> maps to no FT conditions.
@@ -285,12 +285,57 @@ class TestDeleteByFilterGuard:
backend.ap = type('Ap', (), {'logger': AsyncMock()})()
backend._ensure_client = AsyncMock(return_value=backend._client)
backend._index_exists = AsyncMock(return_value=True)
backend._search_keys = AsyncMock(return_value=['kb:col1:id1', 'kb:col1:id2'])
backend._delete_search_results = AsyncMock(return_value=2)
deleted = await backend.delete_by_filter('col1', {'file_id': 'f1'})
assert deleted == 2
backend._client.delete.assert_awaited_once_with(['kb:col1:id1', 'kb:col1:id2'])
backend._delete_search_results.assert_awaited_once_with(
backend._client,
backend._index_name('col1'),
'@file_id:{f1}',
)
class TestBatchedDelete:
async def test_matching_keys_are_deleted_in_fixed_pages(self, monkeypatch):
mod = get_valkey_module()
backend = make_backend()
client = AsyncMock()
search = AsyncMock(
side_effect=[
[3, {b'key-1': {}, b'key-2': {}}],
[1, {b'key-3': {}}],
]
)
monkeypatch.setattr(mod, '_DELETE_SCAN_BATCH', 2)
monkeypatch.setattr(mod, 'FtSearchLimit', lambda offset, limit: (offset, limit), raising=False)
monkeypatch.setattr(mod, 'FtSearchOptions', lambda **kwargs: kwargs, raising=False)
monkeypatch.setattr(mod, 'ft', type('FT', (), {'search': search})(), raising=False)
deleted = await backend._delete_search_results(client, 'idx:col1', '@file_id:{f1}')
assert deleted == 3
assert search.await_count == 2
assert [call.args[3]['limit'] for call in search.await_args_list] == [(0, 2), (0, 2)]
assert client.delete.await_args_list[0].args == (['key-1', 'key-2'],)
assert client.delete.await_args_list[1].args == (['key-3'],)
async def test_delete_rounds_have_a_hard_stop(self, monkeypatch):
mod = get_valkey_module()
backend = make_backend()
client = AsyncMock()
search = AsyncMock(return_value=[2, {b'key': {}}])
monkeypatch.setattr(mod, '_DELETE_SCAN_BATCH', 1)
monkeypatch.setattr(mod, '_MAX_DELETE_SCAN_ROUNDS', 2)
monkeypatch.setattr(mod, 'FtSearchLimit', lambda offset, limit: (offset, limit), raising=False)
monkeypatch.setattr(mod, 'FtSearchOptions', lambda **kwargs: kwargs, raising=False)
monkeypatch.setattr(mod, 'ft', type('FT', (), {'search': search})(), raising=False)
with pytest.raises(RuntimeError, match='exceeded 2 batches'):
await backend._delete_search_results(client, 'idx:col1', '@file_id:{f1}')
assert client.delete.await_count == 2
class TestClose: