fix(maintenance): guard media cache cleanup and annotate exception suppression

- Safely resolve media_cache via getattr in cleanup_expired_files to prevent AttributeError when storage_mgr is unset in cloud/test fixtures
- Only attach 'media_files' in cleanup return dictionary when media cache is active on singleton, preserving exact return contract for cloud maintenance tests
- Add explanatory comments to exception suppression in MediaCache.touch and cleanup loops to address code-quality review findings
This commit is contained in:
BiFangKNT
2026-09-15 20:30:34 +08:00
parent c16cd433e0
commit 7e239f1629
2 changed files with 13 additions and 6 deletions
@@ -91,25 +91,29 @@ class MaintenanceService:
0,
'storage.media_cache.max_size_mb',
)
media_cache = getattr(getattr(self.ap, 'storage_mgr', None), 'media_cache', None)
is_singleton = await self._is_oss_singleton(context)
media_cleanup = (
await self.ap.storage_mgr.media_cache.cleanup(
await media_cache.cleanup(
media_retention_days,
media_max_size_mb,
)
if hasattr(self.ap.storage_mgr, 'media_cache') and await self._is_oss_singleton(context)
if media_cache is not None and is_singleton
else {}
)
return {
result = {
'uploaded_files': await self._cleanup_expired_uploaded_files(context, upload_retention_days),
'log_files': await asyncio.to_thread(
self._cleanup_expired_log_files,
log_retention_days,
)
if await self._is_oss_singleton(context)
if is_singleton
else 0,
'media_files': media_cleanup.get('expired_deleted', 0) + media_cleanup.get('size_deleted', 0),
}
if media_cache is not None and is_singleton:
result['media_files'] = media_cleanup.get('expired_deleted', 0) + media_cleanup.get('size_deleted', 0)
return result
async def get_storage_analysis(self, context: TenantContext) -> dict[str, Any]:
require_workspace_uuid(context)