mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-08 20:30:59 +00:00
feat: report independent instance and workspace identities (#2394)
* feat: report independent instance and workspace identities * test: include workspace in OAuth callback fixture * ci: pin production cloud adapter to Space release * fix: preserve authenticated Workspace telemetry attribution * ci: pin production cloud adapter to final Space release --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
This commit is contained in:
@@ -3,6 +3,7 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
from datetime import datetime, timezone
|
||||
from types import SimpleNamespace
|
||||
|
||||
import pytest
|
||||
@@ -14,6 +15,12 @@ def get_heartbeat_module():
|
||||
return import_module('langbot.pkg.telemetry.heartbeat')
|
||||
|
||||
|
||||
def test_workspace_created_timestamp_treats_naive_database_values_as_utc():
|
||||
heartbeat = get_heartbeat_module()
|
||||
created_at = datetime(2026, 8, 4, 0, 0, 0)
|
||||
assert heartbeat._workspace_created_timestamp(created_at) == 1785801600
|
||||
|
||||
|
||||
def make_app():
|
||||
ap = Mock()
|
||||
ap.instance_config = Mock()
|
||||
@@ -57,15 +64,17 @@ def make_app():
|
||||
|
||||
class TestBuildHeartbeatPayload:
|
||||
@pytest.mark.asyncio
|
||||
async def test_payload_shape(self):
|
||||
async def test_payload_shape(self, monkeypatch):
|
||||
heartbeat = get_heartbeat_module()
|
||||
monkeypatch.setattr(heartbeat.constants, 'instance_id', 'instance-test')
|
||||
ap = make_app()
|
||||
payload = await heartbeat.build_heartbeat_payload(ap, workspace_uuid='workspace-a')
|
||||
|
||||
assert payload['event_type'] == 'instance_heartbeat'
|
||||
assert payload['query_id'] == ''
|
||||
assert payload['workspace_uuid'] == 'workspace-a'
|
||||
assert 'instance_id' not in payload
|
||||
assert payload['instance_id']
|
||||
assert payload['workspace_create_ts'] == 0
|
||||
assert 'instance_create_ts' in payload
|
||||
assert 'timestamp' in payload
|
||||
f = payload['features']
|
||||
@@ -100,8 +109,9 @@ class TestBuildHeartbeatPayload:
|
||||
assert payload['features']['pipeline_count'] == -1
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_cloud_counts_loaded_registries_without_tenant_sql(self):
|
||||
async def test_cloud_counts_loaded_registries_without_tenant_sql(self, monkeypatch):
|
||||
heartbeat = get_heartbeat_module()
|
||||
monkeypatch.setattr(heartbeat.constants, 'instance_id', 'instance-test')
|
||||
ap = make_app()
|
||||
ap.persistence_mgr.mode = SimpleNamespace(value='cloud_runtime')
|
||||
ap.persistence_mgr.execute_async = AsyncMock(
|
||||
@@ -140,7 +150,11 @@ class TestBuildHeartbeatPayload:
|
||||
ap.workspace_service.list_active_execution_bindings = AsyncMock(
|
||||
return_value=[
|
||||
SimpleNamespace(workspace_uuid='workspace-a', placement_generation=7),
|
||||
SimpleNamespace(workspace_uuid='workspace-b', placement_generation=9),
|
||||
SimpleNamespace(
|
||||
workspace_uuid='workspace-b',
|
||||
placement_generation=9,
|
||||
workspace_created_at=datetime(2026, 8, 4, tzinfo=timezone.utc),
|
||||
),
|
||||
],
|
||||
)
|
||||
ap.platform_mgr._bots_by_key[('instance-a', 'workspace-b', 'bot-b')] = SimpleNamespace(
|
||||
@@ -150,7 +164,9 @@ class TestBuildHeartbeatPayload:
|
||||
payloads = await heartbeat.build_heartbeat_payloads(ap)
|
||||
|
||||
assert [payload['workspace_uuid'] for payload in payloads] == ['workspace-a', 'workspace-b']
|
||||
assert all('instance_id' not in payload for payload in payloads)
|
||||
assert all(payload['instance_id'] for payload in payloads)
|
||||
assert payloads[0]['workspace_create_ts'] == 0
|
||||
assert payloads[1]['workspace_create_ts'] == 1785801600
|
||||
by_workspace = {payload['workspace_uuid']: payload['features'] for payload in payloads}
|
||||
assert by_workspace['workspace-a']['pipeline_count'] == 2
|
||||
assert by_workspace['workspace-a']['mcp_server_count'] == 3
|
||||
|
||||
@@ -596,6 +596,36 @@ class TestTelemetryManagedRuntimeAuthentication:
|
||||
assert captured['headers'] == {'X-LangBot-Telemetry-Token': 'managed-runtime-secret'}
|
||||
|
||||
|
||||
class TestAuthenticatedWorkspaceReporter:
|
||||
@pytest.mark.asyncio
|
||||
async def test_workspace_owner_access_token_is_sent_as_bearer(self):
|
||||
telemetry = get_telemetry_module()
|
||||
mock_app = Mock()
|
||||
mock_app.logger = Mock()
|
||||
mock_app.user_service = Mock()
|
||||
mock_app.user_service.get_workspace_owner = AsyncMock(
|
||||
return_value=Mock(user='owner@example.com', space_access_token='expired-token')
|
||||
)
|
||||
mock_app.space_service = Mock()
|
||||
mock_app.space_service.get_valid_access_token = AsyncMock(return_value='refreshed-workspace-owner-token')
|
||||
manager = telemetry.TelemetryManager(mock_app)
|
||||
manager.telemetry_config = {'url': 'https://example.com'}
|
||||
|
||||
response = Mock(status_code=200, text='')
|
||||
response.json = Mock(return_value={'code': 0})
|
||||
mock_client = Mock()
|
||||
mock_client.post = Mock(return_value=response)
|
||||
|
||||
with patch.object(httpx, 'AsyncClient', return_value=mock_client):
|
||||
await manager.send({'query_id': 'q-1', 'workspace_uuid': 'workspace-1'})
|
||||
|
||||
mock_app.user_service.get_workspace_owner.assert_awaited_once_with('workspace-1')
|
||||
mock_app.space_service.get_valid_access_token.assert_awaited_once_with('owner@example.com')
|
||||
assert mock_client.post.call_args.kwargs['headers'] == {
|
||||
'Authorization': 'Bearer refreshed-workspace-owner-token'
|
||||
}
|
||||
|
||||
|
||||
class TestStartSendTask:
|
||||
"""Tests for start_send_task() method."""
|
||||
|
||||
|
||||
@@ -7,25 +7,28 @@ from types import SimpleNamespace
|
||||
def test_standard_oss_instance_id_aligns_to_embedded_uuid():
|
||||
from langbot.pkg.workspace.identity import workspace_uuid_from_instance_id
|
||||
|
||||
instance_uuid = "a711d9e4-0953-443f-a0e9-7dd50193a79f"
|
||||
instance_uuid = 'a711d9e4-0953-443f-a0e9-7dd50193a79f'
|
||||
|
||||
assert workspace_uuid_from_instance_id(instance_uuid) == instance_uuid
|
||||
assert workspace_uuid_from_instance_id(f"instance_{instance_uuid}") == instance_uuid
|
||||
assert workspace_uuid_from_instance_id(f'instance_{instance_uuid}') == instance_uuid
|
||||
|
||||
|
||||
def test_custom_legacy_instance_id_maps_to_stable_valid_uuid():
|
||||
from langbot.pkg.workspace.identity import workspace_uuid_from_instance_id
|
||||
|
||||
first = workspace_uuid_from_instance_id("instance_migration_test")
|
||||
second = workspace_uuid_from_instance_id("instance_migration_test")
|
||||
first = workspace_uuid_from_instance_id('instance_migration_test')
|
||||
second = workspace_uuid_from_instance_id('instance_migration_test')
|
||||
|
||||
assert first == second
|
||||
assert str(uuid.UUID(first)) == first
|
||||
|
||||
|
||||
def test_query_telemetry_identity_uses_execution_workspace_only():
|
||||
def test_query_telemetry_identity_reports_instance_and_workspace():
|
||||
from langbot.pkg.telemetry.identity import workspace_identity
|
||||
|
||||
identity = workspace_identity(SimpleNamespace(workspace_uuid="workspace-a", instance_uuid="instance-a"))
|
||||
identity = workspace_identity(SimpleNamespace(workspace_uuid='workspace-a', instance_uuid='instance-a'))
|
||||
|
||||
assert identity == {"workspace_uuid": "workspace-a"}
|
||||
assert identity == {
|
||||
'instance_id': 'instance-a',
|
||||
'workspace_uuid': 'workspace-a',
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user