mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-09 12:40:59 +00:00
feat(tenancy): add Workspace multi-tenant foundation (#2353)
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
This commit is contained in:
RockChinQ
+132
-2
@@ -1,6 +1,9 @@
|
||||
import { expect, test } from '@playwright/test';
|
||||
|
||||
import { installLangBotApiMocks } from './fixtures/langbot-api';
|
||||
import {
|
||||
installLangBotApiMocks,
|
||||
makeWorkspaceEntry,
|
||||
} from './fixtures/langbot-api';
|
||||
|
||||
test('local account login reaches the authenticated home shell', async ({
|
||||
page,
|
||||
@@ -14,9 +17,136 @@ test('local account login reaches the authenticated home shell', async ({
|
||||
await page.getByPlaceholder('Enter password').fill('password');
|
||||
await page.getByRole('button', { name: 'Login with password' }).click();
|
||||
|
||||
await expect(page).toHaveURL(/\/home$/);
|
||||
await expect(page).toHaveURL(/\/home(?:\/monitoring)?$/);
|
||||
await expect(page.getByText('Home').first()).toBeVisible();
|
||||
await expect(page.getByRole('button', { name: 'Dashboard' })).toBeVisible();
|
||||
await expect(page.getByText('Total Messages').first()).toBeVisible();
|
||||
await expect(page.getByText('Unable to connect to server')).toHaveCount(0);
|
||||
});
|
||||
|
||||
test('an existing Account token bootstraps the singleton without a selector loop', async ({
|
||||
page,
|
||||
}) => {
|
||||
const bootstrapWorkspaceHeaders: Array<string | undefined> = [];
|
||||
page.on('request', (request) => {
|
||||
if (new URL(request.url()).pathname === '/api/v1/workspaces/bootstrap') {
|
||||
bootstrapWorkspaceHeaders.push(request.headers()['x-workspace-id']);
|
||||
}
|
||||
});
|
||||
|
||||
await installLangBotApiMocks(page, { authenticated: true });
|
||||
await page.goto('/login');
|
||||
|
||||
await expect(page).toHaveURL(/\/home(?:\/monitoring)?$/);
|
||||
await expect(page.getByRole('button', { name: 'Dashboard' })).toBeVisible();
|
||||
expect(bootstrapWorkspaceHeaders.length).toBeGreaterThan(0);
|
||||
expect(bootstrapWorkspaceHeaders.every((header) => !header)).toBe(true);
|
||||
});
|
||||
|
||||
test('multi-Workspace login waits for an explicit selection', async ({
|
||||
page,
|
||||
}) => {
|
||||
const accountScopedRequests: { path: string; workspace?: string }[] = [];
|
||||
const selectedWorkspaceHeaders: string[] = [];
|
||||
page.on('request', (request) => {
|
||||
const path = new URL(request.url()).pathname;
|
||||
const workspace = request.headers()['x-workspace-id'];
|
||||
if (
|
||||
path === '/api/v1/user/auth' ||
|
||||
path === '/api/v1/user/check-token' ||
|
||||
path === '/api/v1/workspaces/bootstrap'
|
||||
) {
|
||||
accountScopedRequests.push({ path, workspace });
|
||||
}
|
||||
if (path === '/api/v1/workspaces/current' && workspace) {
|
||||
selectedWorkspaceHeaders.push(workspace);
|
||||
}
|
||||
});
|
||||
|
||||
await installLangBotApiMocks(page, {
|
||||
storage: {
|
||||
langbot_active_workspace_uuid: 'workspace-from-another-account',
|
||||
},
|
||||
workspaces: [
|
||||
makeWorkspaceEntry('workspace-alpha', 'Alpha Workspace'),
|
||||
makeWorkspaceEntry('workspace-beta', 'Beta Workspace'),
|
||||
],
|
||||
});
|
||||
|
||||
await page.goto('/login');
|
||||
await page.getByPlaceholder('Enter email address').fill('admin@example.com');
|
||||
await page.getByPlaceholder('Enter password').fill('password');
|
||||
await page.getByRole('button', { name: 'Login with password' }).click();
|
||||
|
||||
await expect(page).toHaveURL(/\/workspaces\/select/);
|
||||
await expect(
|
||||
page.getByRole('heading', { name: 'Choose a Workspace' }),
|
||||
).toBeVisible();
|
||||
await expect(page.getByText('Alpha Workspace')).toBeVisible();
|
||||
await expect(page.getByText('Beta Workspace')).toBeVisible();
|
||||
|
||||
await page.getByRole('button', { name: /Beta Workspace/ }).click();
|
||||
|
||||
await expect(page).toHaveURL(/\/home(?:\/monitoring)?$/);
|
||||
const workspaceSwitcher = page
|
||||
.getByRole('button', {
|
||||
name: /Switch Workspace/,
|
||||
})
|
||||
.first();
|
||||
await expect(workspaceSwitcher).toBeVisible();
|
||||
await workspaceSwitcher.click();
|
||||
await expect(
|
||||
page.getByRole('menuitem', { name: 'Workspace Settings' }),
|
||||
).toBeVisible();
|
||||
expect(selectedWorkspaceHeaders).toContain('workspace-beta');
|
||||
expect(accountScopedRequests.length).toBeGreaterThan(0);
|
||||
expect(accountScopedRequests.every((request) => !request.workspace)).toBe(
|
||||
true,
|
||||
);
|
||||
});
|
||||
|
||||
test('Space OAuth bootstraps a singleton before entering home', async ({
|
||||
page,
|
||||
}) => {
|
||||
const selectedWorkspaceHeaders: string[] = [];
|
||||
page.on('request', (request) => {
|
||||
const path = new URL(request.url()).pathname;
|
||||
const workspace = request.headers()['x-workspace-id'];
|
||||
if (path === '/api/v1/workspaces/current' && workspace) {
|
||||
selectedWorkspaceHeaders.push(workspace);
|
||||
}
|
||||
});
|
||||
|
||||
await installLangBotApiMocks(page);
|
||||
await page.goto('/auth/space/callback?code=oauth-code&state=oauth-state');
|
||||
|
||||
await expect(page).toHaveURL(/\/home(?:\/monitoring)?$/, {
|
||||
timeout: 5_000,
|
||||
});
|
||||
expect(selectedWorkspaceHeaders).toContain('workspace-playwright');
|
||||
});
|
||||
|
||||
test('Space OAuth sends a multi-Workspace Account to the chooser', async ({
|
||||
page,
|
||||
}) => {
|
||||
const bootstrapWorkspaceHeaders: Array<string | undefined> = [];
|
||||
page.on('request', (request) => {
|
||||
if (new URL(request.url()).pathname === '/api/v1/workspaces/bootstrap') {
|
||||
bootstrapWorkspaceHeaders.push(request.headers()['x-workspace-id']);
|
||||
}
|
||||
});
|
||||
|
||||
await installLangBotApiMocks(page, {
|
||||
workspaces: [
|
||||
makeWorkspaceEntry('workspace-alpha', 'Alpha Workspace'),
|
||||
makeWorkspaceEntry('workspace-beta', 'Beta Workspace'),
|
||||
],
|
||||
});
|
||||
await page.goto('/auth/space/callback?code=oauth-code&state=oauth-state');
|
||||
|
||||
await expect(page).toHaveURL(/\/workspaces\/select/, { timeout: 5_000 });
|
||||
await expect(page.getByText('Alpha Workspace')).toBeVisible();
|
||||
await expect(page.getByText('Beta Workspace')).toBeVisible();
|
||||
expect(bootstrapWorkspaceHeaders.length).toBeGreaterThan(0);
|
||||
expect(bootstrapWorkspaceHeaders.every((header) => !header)).toBe(true);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user