xinyin025/LangBot
1
0
Fork 0
mirror of https://github.com/langbot-app/LangBot.git synced 2026-09-28 12:26:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): let the docked assistant button collapse again

Browse Source 
`shouldCollapseRail` was keyed on `!railExpanded`, mirroring the expand
helper instead of negating it. Once a hover revealed the button it could
never collapse back into the rail, so the collapse looked broken after the
first restore.

Key the predicate on `railExpanded` being true, restore the mirror
relationship with `shouldExpandRail`, and add regression coverage for the
expand -> leave -> collapse round trip. Also lengthen the rail strip.
This commit is contained in:
TyperBody
2026-09-25 13:22:18 +08:00
parent 88257fe0e2
commit e6e1958fc5
3 changed files with 38 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/src/app/home/components/WorkspaceAssistant.tsx
+1 -1
View File
@@ -505,7 +505,7 @@ function AssistantPanel({ storageKey }: { storageKey: string }) {
<span
role="presentation"
aria-hidden="true"
className={`pointer-events-none absolute top-1/2 h-6 -translate-y-1/2 rounded-full bg-[#3b82f6] shadow-md ${
className={`pointer-events-none absolute top-1/2 h-14 -translate-y-1/2 rounded-full bg-[#3b82f6] shadow-md ${
dockedEdge === 'right' ? 'right-0' : 'left-0'
}`}
style={{ width: ASSISTANT_RAIL_WIDTH }}
web/src/app/home/components/assistant-dock.ts
+15 -6
View File
@@ -55,25 +55,34 @@ export type AssistantHoverInput = {
dragging: boolean;
};
/** Hovering any part of the control must reveal the full button again. */
/** Distance to the viewport edge that snaps the button into the rail. */
/**
* Hovering any part of the control must reveal the full button again.
* Only a docked *and still collapsed* button needs to expand, so a pointer that
* merely jitters inside an already expanded button does no state churn.
*/
export function shouldExpandRail(input: AssistantHoverInput): boolean {
if (input.dragging) return false;
return !!input.dockedEdge && !input.railExpanded;
}
/**
* A docked button collapses to the strip only when it is idle and the pointer
* has left. The panel being open pins it, because the popover is anchored.
* A docked button collapses to the strip when the pointer leaves. This is the
* mirror of `shouldExpandRail` and is keyed on `railExpanded` being *true* —
* the earlier `!railExpanded` form made a revealed button impossible to
* re-collapse, which is the bug this guards against. The panel being open pins
* it, because the popover stays anchored to the button.
*/
export function shouldCollapseRail(input: AssistantHoverInput): boolean {
if (input.dragging) return false;
return !!input.dockedEdge && !input.railExpanded;
return !!input.dockedEdge && input.railExpanded;
}
/**
* After a drop the button always starts collapsed, even though the pointer is
* still over it. The next pointermove re-expands it, which avoids the
* "drops under the cursor and never comes back" race.
* still over it. The rail is then held collapsed until the pointer exits, which
* avoids the "drops under the cursor and never comes back" race.
*/
export function restingRailExpanded(): boolean {
return false;