mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-06-26 07:24:20 +00:00
test: format test suite
This commit is contained in:
@@ -2,4 +2,4 @@
|
||||
Persistence integration tests package.
|
||||
|
||||
Tests for database migrations and storage behavior.
|
||||
"""
|
||||
"""
|
||||
|
||||
@@ -26,8 +26,8 @@ pytestmark = pytest.mark.integration
|
||||
@pytest.fixture
|
||||
def sqlite_db_url(tmp_path):
|
||||
"""Create SQLite URL with temporary database file."""
|
||||
db_file = tmp_path / "test_migrations.db"
|
||||
return f"sqlite+aiosqlite:///{db_file}"
|
||||
db_file = tmp_path / 'test_migrations.db'
|
||||
return f'sqlite+aiosqlite:///{db_file}'
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
@@ -102,9 +102,9 @@ class TestSQLiteMigrationUpgrade:
|
||||
|
||||
# Verify revision
|
||||
rev = await get_alembic_current(sqlite_engine)
|
||||
assert rev is not None, "Expected a revision after upgrade"
|
||||
assert rev is not None, 'Expected a revision after upgrade'
|
||||
# Head should be the latest migration
|
||||
assert rev.startswith('0005'), f"Expected head to be 0005_*, got {rev}"
|
||||
assert rev.startswith('0005'), f'Expected head to be 0005_*, got {rev}'
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_upgrade_idempotent(self, sqlite_engine):
|
||||
@@ -131,7 +131,7 @@ class TestSQLiteMigrationUpgrade:
|
||||
await run_alembic_upgrade(sqlite_engine, 'head')
|
||||
|
||||
rev2 = await get_alembic_current(sqlite_engine)
|
||||
assert rev2 == rev1, f"Expected {rev1}, got {rev2}"
|
||||
assert rev2 == rev1, f'Expected {rev1}, got {rev2}'
|
||||
|
||||
|
||||
class TestSQLiteMigrationFreshDatabase:
|
||||
@@ -149,8 +149,8 @@ class TestSQLiteMigrationFreshDatabase:
|
||||
4. Verify revision
|
||||
"""
|
||||
# Use different DB file for fresh test
|
||||
fresh_db_file = tmp_path / "test_migrations_fresh.db"
|
||||
fresh_url = f"sqlite+aiosqlite:///{fresh_db_file}"
|
||||
fresh_db_file = tmp_path / 'test_migrations_fresh.db'
|
||||
fresh_url = f'sqlite+aiosqlite:///{fresh_db_file}'
|
||||
fresh_engine = create_async_engine(fresh_url)
|
||||
|
||||
# Create tables on fresh DB
|
||||
@@ -162,7 +162,7 @@ class TestSQLiteMigrationFreshDatabase:
|
||||
|
||||
# Verify revision
|
||||
rev = await get_alembic_current(fresh_engine)
|
||||
assert rev is not None, "Expected a revision on fresh DB"
|
||||
assert rev is not None, 'Expected a revision on fresh DB'
|
||||
|
||||
await fresh_engine.dispose()
|
||||
|
||||
@@ -181,8 +181,8 @@ class TestSQLiteMigrationFreshDatabase:
|
||||
IMPORTANT: This test verifies the ACTUAL behavior, not accepting
|
||||
any arbitrary failure with try-except pass.
|
||||
"""
|
||||
fresh_db_file = tmp_path / "test_empty_migrations.db"
|
||||
fresh_url = f"sqlite+aiosqlite:///{fresh_db_file}"
|
||||
fresh_db_file = tmp_path / 'test_empty_migrations.db'
|
||||
fresh_url = f'sqlite+aiosqlite:///{fresh_db_file}'
|
||||
fresh_engine = create_async_engine(fresh_url)
|
||||
|
||||
# Capture the actual behavior
|
||||
@@ -201,23 +201,23 @@ class TestSQLiteMigrationFreshDatabase:
|
||||
# Verify specific behavior - one of two outcomes is expected
|
||||
if actual_result is not None:
|
||||
# Migration succeeded - verify revision exists
|
||||
assert actual_result is not None, "Revision should exist after successful migration"
|
||||
assert actual_result is not None, 'Revision should exist after successful migration'
|
||||
else:
|
||||
# Migration failed - verify the error type is known
|
||||
# Alembic typically raises specific errors for missing tables
|
||||
assert actual_error is not None, "Error should be captured if migration failed"
|
||||
assert actual_error is not None, 'Error should be captured if migration failed'
|
||||
# Log the error type for documentation (don't silently pass)
|
||||
error_type = type(actual_error).__name__
|
||||
# Acceptable error types for empty DB scenarios
|
||||
acceptable_errors = [
|
||||
'OperationalError', # SQLite table not found
|
||||
'ProgrammingError', # SQLAlchemy errors
|
||||
'CommandError', # Alembic command errors
|
||||
'CommandError', # Alembic command errors
|
||||
]
|
||||
assert error_type in acceptable_errors, (
|
||||
f"Unexpected error type: {error_type}. "
|
||||
f"This may indicate a regression in migration behavior. "
|
||||
f"Error: {actual_error}"
|
||||
f'Unexpected error type: {error_type}. '
|
||||
f'This may indicate a regression in migration behavior. '
|
||||
f'Error: {actual_error}'
|
||||
)
|
||||
|
||||
|
||||
@@ -235,7 +235,7 @@ class TestSQLiteMigrationGetCurrent:
|
||||
|
||||
# No stamp - should return None
|
||||
rev = await get_alembic_current(sqlite_engine)
|
||||
assert rev is None, f"Expected None for unstamped DB, got {rev}"
|
||||
assert rev is None, f'Expected None for unstamped DB, got {rev}'
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_current_after_stamp_returns_revision(self, sqlite_engine):
|
||||
@@ -248,4 +248,4 @@ class TestSQLiteMigrationGetCurrent:
|
||||
await run_alembic_stamp(sqlite_engine, '0001_baseline')
|
||||
|
||||
rev = await get_alembic_current(sqlite_engine)
|
||||
assert rev == '0001_baseline'
|
||||
assert rev == '0001_baseline'
|
||||
|
||||
@@ -34,14 +34,14 @@ def postgres_url():
|
||||
"""Get PostgreSQL URL from environment."""
|
||||
url = os.environ.get('TEST_POSTGRES_URL')
|
||||
if not url:
|
||||
pytest.skip("TEST_POSTGRES_URL not set")
|
||||
pytest.skip('TEST_POSTGRES_URL not set')
|
||||
return url
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
async def postgres_engine(postgres_url):
|
||||
"""Create async PostgreSQL engine."""
|
||||
engine = create_async_engine(postgres_url, isolation_level="AUTOCOMMIT")
|
||||
engine = create_async_engine(postgres_url, isolation_level='AUTOCOMMIT')
|
||||
yield engine
|
||||
await engine.dispose()
|
||||
|
||||
@@ -66,7 +66,7 @@ async def clean_alembic_version(postgres_engine):
|
||||
async with postgres_engine.begin() as conn:
|
||||
# Drop alembic_version table if exists
|
||||
try:
|
||||
await conn.execute(text("DROP TABLE IF EXISTS alembic_version"))
|
||||
await conn.execute(text('DROP TABLE IF EXISTS alembic_version'))
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
@@ -74,7 +74,7 @@ async def clean_alembic_version(postgres_engine):
|
||||
|
||||
async with postgres_engine.begin() as conn:
|
||||
try:
|
||||
await conn.execute(text("DROP TABLE IF EXISTS alembic_version"))
|
||||
await conn.execute(text('DROP TABLE IF EXISTS alembic_version'))
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
@@ -83,9 +83,7 @@ class TestPostgreSQLMigrationBaseline:
|
||||
"""Tests for baseline stamp workflow on PostgreSQL."""
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_postgres_baseline_stamp_sets_revision(
|
||||
self, postgres_engine, clean_tables, clean_alembic_version
|
||||
):
|
||||
async def test_postgres_baseline_stamp_sets_revision(self, postgres_engine, clean_tables, clean_alembic_version):
|
||||
"""
|
||||
Stamp baseline on existing tables sets correct revision.
|
||||
|
||||
@@ -106,9 +104,7 @@ class TestPostgreSQLMigrationBaseline:
|
||||
assert rev == '0001_baseline', f"Expected '0001_baseline', got {rev}"
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_postgres_baseline_stamp_on_empty_db(
|
||||
self, postgres_engine, clean_tables, clean_alembic_version
|
||||
):
|
||||
async def test_postgres_baseline_stamp_on_empty_db(self, postgres_engine, clean_tables, clean_alembic_version):
|
||||
"""
|
||||
Stamp on empty database (no tables) still sets revision.
|
||||
|
||||
@@ -125,9 +121,7 @@ class TestPostgreSQLMigrationUpgrade:
|
||||
"""Tests for upgrade to head workflow on PostgreSQL."""
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_postgres_upgrade_from_baseline_to_head(
|
||||
self, postgres_engine, clean_tables, clean_alembic_version
|
||||
):
|
||||
async def test_postgres_upgrade_from_baseline_to_head(self, postgres_engine, clean_tables, clean_alembic_version):
|
||||
"""
|
||||
Upgrade from baseline to head applies all migrations.
|
||||
|
||||
@@ -149,14 +143,12 @@ class TestPostgreSQLMigrationUpgrade:
|
||||
|
||||
# Verify revision
|
||||
rev = await get_alembic_current(postgres_engine)
|
||||
assert rev is not None, "Expected a revision after upgrade"
|
||||
assert rev is not None, 'Expected a revision after upgrade'
|
||||
# Head should be the latest migration (0005 for current state)
|
||||
assert rev.startswith('0005'), f"Expected head to be 0005_*, got {rev}"
|
||||
assert rev.startswith('0005'), f'Expected head to be 0005_*, got {rev}'
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_postgres_upgrade_idempotent(
|
||||
self, postgres_engine, clean_tables, clean_alembic_version
|
||||
):
|
||||
async def test_postgres_upgrade_idempotent(self, postgres_engine, clean_tables, clean_alembic_version):
|
||||
"""
|
||||
Running upgrade to head multiple times is idempotent.
|
||||
|
||||
@@ -180,7 +172,7 @@ class TestPostgreSQLMigrationUpgrade:
|
||||
await run_alembic_upgrade(postgres_engine, 'head')
|
||||
|
||||
rev2 = await get_alembic_current(postgres_engine)
|
||||
assert rev2 == rev1, f"Expected {rev1}, got {rev2}"
|
||||
assert rev2 == rev1, f'Expected {rev1}, got {rev2}'
|
||||
|
||||
|
||||
class TestPostgreSQLMigrationGetCurrent:
|
||||
@@ -199,7 +191,7 @@ class TestPostgreSQLMigrationGetCurrent:
|
||||
|
||||
# No stamp - should return None
|
||||
rev = await get_alembic_current(postgres_engine)
|
||||
assert rev is None, f"Expected None for unstamped DB, got {rev}"
|
||||
assert rev is None, f'Expected None for unstamped DB, got {rev}'
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_postgres_get_current_after_stamp_returns_revision(
|
||||
@@ -214,4 +206,4 @@ class TestPostgreSQLMigrationGetCurrent:
|
||||
await run_alembic_stamp(postgres_engine, '0001_baseline')
|
||||
|
||||
rev = await get_alembic_current(postgres_engine)
|
||||
assert rev == '0001_baseline'
|
||||
assert rev == '0001_baseline'
|
||||
|
||||
Reference in New Issue
Block a user