mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-06-02 03:55:55 +00:00
* fix(ci): update unit-test workflow paths to match current source layout Replace stale pkg/** filter with src/langbot/** and add uv.lock. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs(tests): update README to reflect current test layout - Fix stale paths: tests/pipeline → tests/unit_tests/pipeline - Update CI Python versions: 3.11, 3.12, 3.13 - Add test directory structure for box, config, platform, plugin, provider, storage - Document pytest markers and uv commands - Mention planned E2E tests Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add shared test factories package Create tests/factories/ with reusable test factories: - FakeApp: mock application with all dependencies - Message chains: text_chain, mention_chain, image_chain - Query factories: text_query, group_text_query, command_query, etc. No test changes - maintains backward compatibility. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add fake provider factory Add tests/factories/provider.py with: - FakeProvider: deterministic fake LLM provider - Error simulation: timeout, auth, rate-limit, malformed - Request capture for assertions - fake_model: mock model with attached provider Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add fake platform factory Add tests/factories/platform.py with: - FakePlatform: simulated platform adapter - Inbound message construction: friend/group/image - Mention-bot flag simulation - Outbound message capture for assertions - Streaming output support simulation - Send failure simulation Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add comprehensive message/query factories Extend tests/factories/message.py with: - file_query: file attachment query - unsupported_query: unknown message segment - voice_query: audio/voice query - at_all_query: group @All mention - query_with_session: query with session object - query_with_config: query with custom pipeline config Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add fake message flow smoke test Create tests/smoke/test_fake_message_flow.py: - TestFakeMessageFlow: factory verification tests - TestMessageFlowIntegration: minimal flow smoke test - Tests FakeApp, FakeProvider, FakePlatform, query factories - Verifies LANGBOT_FAKE_PONG marker response - Captures outbound messages for assertions Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add developer test-quick command Add scripts/test-quick.sh and Makefile with: - test-quick: runs ruff check + unit tests + smoke tests - No real provider keys or platform accounts required - Suitable for local branch self-test Update tests/README.md: - Document test-quick command - Document test factories package - Add smoke tests and factories directory structure Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(test): make test-quick reliable as developer gate Fixes for D-001验收问题: 1. test-quick.sh: use set -euo pipefail, uv run ruff, no tail pipe 2. Remove unused imports in factories (app.py, platform.py, provider.py) 3. Fix unused variable in smoke test 4. Add noqa: E402 to test_n8nsvapi.py lazy imports 5. Update smoke test docs: "minimal fake flow" not full pipeline Now test-quick is a reliable gate: lint failures exit 1, test failures propagate. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(unit): add preproc and taskmgr unit tests U-001: Pipeline Preprocessor tests - Normal text message processing - Empty message handling - Image segment with/without vision model - Model selection and fallback - Variable extraction U-004: Core Task Manager tests (pattern-based) - Task creation and tracking patterns - Task cancellation patterns - Scope-based cancellation - Task type filtering - Pruning completed tasks - Wait all tasks Taskmgr tests use pattern-based approach to avoid circular import in source code (taskmgr → app → http_controller → migration → taskmgr). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(unit): add config loader unit tests U-005: Config Loader tests - Valid YAML config loading - Valid JSON config loading - Invalid YAML/JSON error behavior - Missing config file creation from template - Template completion for missing keys - ConfigManager load/dump operations - Exists check for both YAML and JSON All tests use tmp_path fixture, no real project config. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(unit): add chat and command handler pattern tests U-002: Chat Handler tests (pattern-based) - Normal message event emission pattern - prevent_default handling - User message alteration pattern - Runner selection pattern - Streaming/non-streaming response patterns - Exception handling modes (show-error, show-hint, hide) - Message history update pattern - Telemetry payload pattern U-003: Command Handler tests (pattern-based) - Command parsing and text extraction - Event creation pattern - Privilege/admin check pattern - Command result handling (text, error, image) - prevent_default handling - String truncation helper Uses pattern-based testing to avoid circular import issues in source code. Direct imports of handler modules trigger circular import chain. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * style: fix unused imports after ruff auto-fix Remove unused imports in test files: - test_config_loader.py: remove unused os - test_taskmgr.py: remove unused Mock - test_preproc.py: remove unused unsupported_query, image_chain Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(unit): improve taskmgr tests to test real classes U-004 improved: Tests now import and test actual classes: - TaskContext: new(), trace(), to_dict(), placeholder() - TaskWrapper: task creation, context, exception/result capture, cancel, to_dict - AsyncTaskManager: create_task, create_user_task, cancel_task, cancel_by_scope - Task pruning behavior Uses pre-mocking technique: - Mock langbot.pkg.core.app before import (breaks circular chain) - Mock langbot.pkg.core.entities with proper Enum All 24 tests now test real class behavior, not patterns. taskmgr.py coverage should improve significantly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(test): consolidate FakeApp and add sys.modules isolation utility - Extract tests/utils/import_isolation.py with isolated_sys_modules context manager - Extend tests/factories/app.py FakeApp with handler-specific attributes - Refactor test_chat_handler.py to use centralized FakeApp and cached imports - Refactor test_command_handler.py with mock_execute_factory fixture - Refactor test_smoke.py to move import-time sys.modules manipulation into fixture - Add SQLite migration integration tests (G-002) - Add HTTP API smoke integration tests (G-005) - Update CI workflow to call pytest for SQLite migrations (G-004) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add developer quality gate consolidation (G-007) - Add scripts/test-integration-fast.sh for fast integration tests - Add scripts/test-coverage.sh with 12% baseline threshold - Update Makefile with test-integration-fast, test-coverage, test-all-local - Update CI workflow with integration and coverage jobs - Add smoke marker to pytest.ini - Update tests/README.md with quality gate layers documentation - Add tests/integration/pipeline/ for pipeline stage-chain tests Quality gate layers: - Quick: ruff + unit + smoke (~2 min) - Fast Integration: SQLite/API/Pipeline (~3 min) - Coverage: 12% threshold gate (~8 min) - Full Local: all three combined Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): add PostgreSQL migration slow integration tests (G-003) - Add tests/integration/persistence/test_migrations_postgres.py - All tests marked with @pytest.mark.slow - Tests skip when TEST_POSTGRES_URL is not set (no local PostgreSQL) - Database isolation via clean_tables and clean_alembic_version fixtures - Update CI workflow to use pytest instead of inline Python script - Remove TODO(G-003) comment - Update tests/README.md with PostgreSQL test documentation Covered scenarios: - Baseline stamp sets revision - Upgrade from baseline to head - Upgrade idempotent - Get current on unstamped DB returns None Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(test): Phase 1.5 coverage expansion - COV-001 to COV-013 Coverage baseline raised from 13.65% to 26% (+12.35%) Gate raised from 12% to 18% Tasks completed: - COV-001: Command system unit tests (100% coverage) - COV-002: API service unit tests batch 1 (user/apikey/model/provider) - COV-003: Provider model manager unit tests - COV-004: Pipeline remaining stage tests (aggregator/cntfilter/longtext/msgtrun) - COV-005: Storage and utils coverage pass - COV-006: Gate ratchet 12%→15% - COV-007: Gate ratchet 15%→18% - COV-008: API service batch 2 (bot/pipeline/webhook/space/maintenance/mcp) - COV-009: Blocked - API controller circular import issue documented - COV-010: Plugin runtime unit tests (+0.08%) - COV-011: RAG and vector unit tests (+0.68%) - COV-012: Core boot and migration unit tests - COV-013: Provider requester logic unit tests (+0.62%) Key additions: - tests/utils/import_isolation.py: sys.modules isolation for circular imports - Provider requester mock tests: proved HTTP-dependent code can be tested locally - Vector filter utilities: 100% coverage on pure functions - API services: fake persistence pattern for unit testing Blocked issue COV-009 documented in langbot-test-plan/1.5/issues/ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(phase1): add unit tests for telemetry, plugin, rag, persistence Add initial unit tests for Phase 1 of test coverage improvement: - telemetry: test initialization, payload sanitization, early returns (14.3% → 62.9%) - plugin: test _parse_plugin_id static method - rag: test _to_i18n_name static method - persistence: test serialize_model with datetime handling Overall core coverage: 41.9% → 42.2% Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(phase2): add unit tests for core, persistence, plugin, utils - Add test_handler_helpers.py for plugin handler helpers (7 tests) - Add test_mgr_methods.py for persistence manager (5 tests) - Add test_app_config_validation.py for core app config (12 tests) - Add test_knowledge_service.py for API knowledge service (22 tests) - Add test_kbmgr.py for RAG knowledge base manager (39 tests) - Add test_survey_manager.py for survey manager (22 tests) - Add test_connector_methods.py for plugin connector (24 tests) - Add test_funcschema.py for utils function schema (9 tests) - Add test_platform.py for utils platform detection (7 tests) - Add test_extract_deps.py for plugin deps extraction (7 tests) - Add test_database_decorator.py for persistence decorator (7 tests) - Add test_load_config.py for core config loading (19 tests) - Add COVERAGE_EXCLUSIONS.md documenting external adapter exclusions - Fix test_chat_session_limit.py path for portability Coverage: core 28% → 30%, persistence 24% → 24.4%, plugin 27% → 28% Total: 1082 tests passed, core module coverage 45.5% Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(integration): add API controller integration tests - Add test_pipelines.py (10 tests) covering pipelines CRUD operations - GET/POST/PUT/DELETE on /api/v1/pipelines - Extensions endpoint - Metadata endpoint - Coverage: pipelines controller 27% → 80% - Add test_providers.py (10 tests) covering provider/model management - Provider CRUD with model counts - LLM model CRUD - Coverage: providers controller 23% → 81%, models 29% → 45% Tests use Quart TestClient with mocked services for real HTTP behavior without external dependencies. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(integration): add knowledge, bots, and model endpoints tests - Add test_knowledge.py (10 tests) covering knowledge base management - CRUD operations on /api/v1/knowledge/bases - Files management endpoints - Retrieve endpoint with validation - Coverage: knowledge/base.py 26% → 91% - Add test_bots.py (9 tests) covering bot management - CRUD operations on /api/v1/platform/bots - Logs endpoint - Send message endpoint with validation - Coverage: platform/bots.py 24% → 87% - Extend test_providers.py (+4 tests) for embedding/rerank models - Embedding models CRUD - Rerank models CRUD - Coverage: provider/models.py 29% → 60% Total integration tests: 53 (smoke 12 + pipelines 10 + providers 14 + knowledge 10 + bots 9) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(integration): add embed and monitoring endpoint tests Add integration tests for embed widget and monitoring API endpoints: - test_embed.py: 15 tests for widget.js, logo, turnstile, messages, reset, feedback - test_monitoring.py: 15 tests for overview, messages, llm-calls, sessions, errors, export Coverage improvements: - embed.py: 17% → 56% - monitoring.py: 17% → 93% Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(e2e): add minimal startup E2E tests Add E2E tests for LangBot startup flow: - tests/e2e/utils/config_factory.py: minimal config generation - tests/e2e/utils/process_manager.py: LangBot subprocess management - tests/e2e/conftest.py: E2E fixtures (session-scoped process) - tests/e2e/test_startup.py: 12 tests for startup verification Tests verify: - boot.py + stages execution - database initialization (SQLite) - API availability - migrations applied Uses embedded databases (SQLite, Chroma) - no external dependencies. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(quality): fix fake tests and add missing coverage P0 fixes: - telemetry: rewrite fake tests with real behavior verification (25 tests) - config: delete copied-source tests, use proper imports (2 deleted) - persistence: fix try-except pass to verify specific errors P1 fixes: - pipeline: add real FixedWindowAlgo tests instead of mocks (12 tests) - provider: add SessionManager and ToolManager tests (25 tests) - storage: add S3StorageProvider tests with moto mock (16 tests) - plugin: add handler action tests for setting inheritance (15 tests) - rag: add file storage and ZIP processing tests (21 tests) - vector: add VDB filter conversion tests (30 tests) P2 fixes: - pipeline/msgtrun: strengthen assertions for exact message count - api: add response structure validation in integration tests New test files: - provider/test_session_manager.py - provider/test_tool_manager.py - storage/test_s3storage.py - plugin/test_handler_actions.py - rag/test_file_storage.py - vector/test_vdb_filter_conversion.py Source code bugs documented: - provider: TokenManager.next_token() ZeroDivisionError - telemetry: send_tasks class variable shared state - command: empty command IndexError, unused parameters - utils: funcschema KeyError - entity: vector.py independent declarative_base Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs(test): update coverage stats and test structure - Update coverage from 22% to 30% - Add new test files to structure: - provider: session_manager, tool_manager - storage: s3storage - plugin: handler_actions - rag: file_storage - vector: vdb_filter_conversion - telemetry: rewritten tests - Update module coverage percentages Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test: add 105 new unit tests for untested core functionality Add comprehensive tests for B-class issues (core functionality untested): Pipeline: - test_pool.py: QueryPool ID generation, caching, async context (12 tests) - test_ratelimit.py: Fixed timing-sensitive test tolerance - test_pipelinemgr.py: Use real Pydantic StageProcessResult instead of Mock Utils: - test_version.py: Version comparison functions (20 tests) - test_logcache.py: Log page management and retrieval (18 tests) - test_httpclient.py: HTTP session pool management (10 tests) - test_proxy.py: Proxy configuration from env and config (10 tests) - test_image.py: URL parsing and base64 extraction (12 tests) - test_pkgmgr.py: Pip command generation (8 tests) Discover: - test_engine.py: I18nString, Metadata, Component manifest (15 tests) Test count: 1193 → 1298 (+105 tests) Note: Some B-class issues cannot be tested due to circular import bugs filed as GitHub issues #2175 (pipeline) and #2176 (persistence). * test: tighten phase 1 coverage contracts * test: align ci integration isolation --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
663 lines
22 KiB
Python
663 lines
22 KiB
Python
"""
|
|
Unit tests for BotService.
|
|
|
|
Tests bot CRUD operations with mocked persistence and runtime managers.
|
|
|
|
Source: src/langbot/pkg/api/http/service/bot.py
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
from unittest.mock import AsyncMock, Mock, patch
|
|
from types import SimpleNamespace
|
|
import uuid
|
|
|
|
from langbot.pkg.api.http.service.bot import BotService
|
|
from langbot.pkg.entity.persistence.bot import Bot
|
|
|
|
|
|
pytestmark = pytest.mark.asyncio
|
|
|
|
|
|
def _create_mock_bot(
|
|
bot_uuid: str = None,
|
|
name: str = 'Test Bot',
|
|
description: str = 'Test Description',
|
|
adapter: str = 'telegram',
|
|
adapter_config: dict = None,
|
|
enable: bool = True,
|
|
use_pipeline_uuid: str = None,
|
|
use_pipeline_name: str = None,
|
|
) -> Mock:
|
|
"""Helper to create mock Bot entity."""
|
|
bot = Mock(spec=Bot)
|
|
bot.uuid = bot_uuid or str(uuid.uuid4())
|
|
bot.name = name
|
|
bot.description = description
|
|
bot.adapter = adapter
|
|
bot.adapter_config = adapter_config or {'token': 'test_token'}
|
|
bot.enable = enable
|
|
bot.use_pipeline_uuid = use_pipeline_uuid
|
|
bot.use_pipeline_name = use_pipeline_name
|
|
bot.pipeline_routing_rules = []
|
|
return bot
|
|
|
|
|
|
def _create_mock_result(items: list = None, first_item=None):
|
|
"""Create mock result object for persistence queries."""
|
|
result = Mock()
|
|
result.all = Mock(return_value=items or [])
|
|
result.first = Mock(return_value=first_item)
|
|
return result
|
|
|
|
|
|
class TestBotServiceGetBots:
|
|
"""Tests for get_bots method."""
|
|
|
|
async def test_get_bots_empty_list(self):
|
|
"""Returns empty list when no bots exist."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
mock_result = _create_mock_result([])
|
|
ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
|
|
ap.persistence_mgr.serialize_model = Mock(
|
|
side_effect=lambda model_cls, entity, masked_columns=None: {
|
|
'uuid': entity.uuid,
|
|
'name': entity.name,
|
|
'adapter': entity.adapter,
|
|
}
|
|
)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute
|
|
result = await service.get_bots()
|
|
|
|
# Verify
|
|
assert result == []
|
|
|
|
async def test_get_bots_returns_list_with_secrets(self):
|
|
"""Returns bot list including adapter_config by default."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
|
|
bot1 = _create_mock_bot(bot_uuid='uuid-1', name='Bot 1')
|
|
bot2 = _create_mock_bot(bot_uuid='uuid-2', name='Bot 2')
|
|
|
|
mock_result = _create_mock_result([bot1, bot2])
|
|
ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
|
|
ap.persistence_mgr.serialize_model = Mock(
|
|
side_effect=lambda model_cls, entity, masked_columns=None: {
|
|
'uuid': entity.uuid,
|
|
'name': entity.name,
|
|
'adapter': entity.adapter,
|
|
'adapter_config': entity.adapter_config if 'adapter_config' not in (masked_columns or []) else None,
|
|
}
|
|
)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute
|
|
result = await service.get_bots(include_secret=True)
|
|
|
|
# Verify
|
|
assert len(result) == 2
|
|
assert result[0]['name'] == 'Bot 1'
|
|
assert result[0]['adapter_config'] is not None
|
|
|
|
async def test_get_bots_masks_secrets(self):
|
|
"""Returns bot list without adapter_config when include_secret=False."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
|
|
bot1 = _create_mock_bot(bot_uuid='uuid-1', name='Bot 1')
|
|
|
|
mock_result = _create_mock_result([bot1])
|
|
ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
|
|
ap.persistence_mgr.serialize_model = Mock(
|
|
side_effect=lambda model_cls, entity, masked_columns=None: {
|
|
'uuid': entity.uuid,
|
|
'name': entity.name,
|
|
'adapter': entity.adapter,
|
|
'adapter_config': entity.adapter_config if 'adapter_config' not in (masked_columns or []) else None,
|
|
}
|
|
)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute
|
|
result = await service.get_bots(include_secret=False)
|
|
|
|
# Verify - adapter_config should be masked
|
|
assert result[0]['adapter_config'] is None
|
|
|
|
|
|
class TestBotServiceGetBot:
|
|
"""Tests for get_bot method."""
|
|
|
|
async def test_get_bot_by_uuid_found(self):
|
|
"""Returns bot when found by UUID."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
|
|
bot = _create_mock_bot(bot_uuid='test-uuid', name='Found Bot')
|
|
mock_result = _create_mock_result(first_item=bot)
|
|
ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
|
|
ap.persistence_mgr.serialize_model = Mock(
|
|
return_value={
|
|
'uuid': 'test-uuid',
|
|
'name': 'Found Bot',
|
|
'adapter': 'telegram',
|
|
}
|
|
)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute
|
|
result = await service.get_bot('test-uuid')
|
|
|
|
# Verify
|
|
assert result is not None
|
|
assert result['uuid'] == 'test-uuid'
|
|
assert result['name'] == 'Found Bot'
|
|
|
|
async def test_get_bot_by_uuid_not_found(self):
|
|
"""Returns None when bot not found."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
|
|
mock_result = _create_mock_result(first_item=None)
|
|
ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute
|
|
result = await service.get_bot('nonexistent-uuid')
|
|
|
|
# Verify
|
|
assert result is None
|
|
|
|
|
|
class TestBotServiceGetRuntimeBotInfo:
|
|
"""Tests for get_runtime_bot_info method."""
|
|
|
|
async def test_get_runtime_bot_info_bot_not_found_raises(self):
|
|
"""Raises Exception when bot not found."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
|
|
mock_result = _create_mock_result(first_item=None)
|
|
ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Mock get_bot to return None
|
|
service.get_bot = AsyncMock(return_value=None)
|
|
|
|
# Execute & Verify
|
|
with pytest.raises(Exception, match='Bot not found'):
|
|
await service.get_runtime_bot_info('nonexistent-uuid')
|
|
|
|
async def test_get_runtime_bot_info_returns_webhook_for_wecom(self):
|
|
"""Returns webhook URL for wecom adapter."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
ap.instance_config = SimpleNamespace()
|
|
ap.instance_config.data = {
|
|
'api': {
|
|
'webhook_prefix': 'http://127.0.0.1:5300',
|
|
'extra_webhook_prefix': 'http://extra.example.com',
|
|
}
|
|
}
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.get_bot_by_uuid = AsyncMock(return_value=None)
|
|
|
|
bot_data = {
|
|
'uuid': 'wecom-uuid',
|
|
'name': 'WeCom Bot',
|
|
'adapter': 'wecom',
|
|
'adapter_config': {'token': 'test'},
|
|
}
|
|
|
|
service = BotService(ap)
|
|
service.get_bot = AsyncMock(return_value=bot_data)
|
|
|
|
# Execute
|
|
result = await service.get_runtime_bot_info('wecom-uuid')
|
|
|
|
# Verify
|
|
assert result['adapter_runtime_values']['webhook_url'] == '/bots/wecom-uuid'
|
|
assert result['adapter_runtime_values']['webhook_full_url'] == 'http://127.0.0.1:5300/bots/wecom-uuid'
|
|
|
|
async def test_get_runtime_bot_info_no_webhook_for_telegram(self):
|
|
"""Returns no webhook URL for non-webhook adapters like telegram."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.instance_config = SimpleNamespace()
|
|
ap.instance_config.data = {'api': {}}
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.get_bot_by_uuid = AsyncMock(return_value=None)
|
|
|
|
bot_data = {
|
|
'uuid': 'telegram-uuid',
|
|
'name': 'Telegram Bot',
|
|
'adapter': 'telegram',
|
|
'adapter_config': {'token': 'test'},
|
|
}
|
|
|
|
service = BotService(ap)
|
|
service.get_bot = AsyncMock(return_value=bot_data)
|
|
|
|
# Execute
|
|
result = await service.get_runtime_bot_info('telegram-uuid')
|
|
|
|
# Verify - no webhook for telegram
|
|
assert result['adapter_runtime_values']['webhook_url'] is None
|
|
assert result['adapter_runtime_values']['webhook_full_url'] is None
|
|
|
|
async def test_get_runtime_bot_info_with_runtime_bot(self):
|
|
"""Returns bot_account_id when runtime bot exists."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.instance_config = SimpleNamespace()
|
|
ap.instance_config.data = {'api': {}}
|
|
ap.platform_mgr = SimpleNamespace()
|
|
|
|
# Mock runtime bot with adapter
|
|
runtime_bot = SimpleNamespace()
|
|
runtime_bot.adapter = SimpleNamespace()
|
|
runtime_bot.adapter.bot_account_id = 'runtime-account-123'
|
|
ap.platform_mgr.get_bot_by_uuid = AsyncMock(return_value=runtime_bot)
|
|
|
|
bot_data = {
|
|
'uuid': 'runtime-uuid',
|
|
'name': 'Runtime Bot',
|
|
'adapter': 'telegram',
|
|
'adapter_config': {},
|
|
}
|
|
|
|
service = BotService(ap)
|
|
service.get_bot = AsyncMock(return_value=bot_data)
|
|
|
|
# Execute
|
|
result = await service.get_runtime_bot_info('runtime-uuid')
|
|
|
|
# Verify
|
|
assert result['adapter_runtime_values']['bot_account_id'] == 'runtime-account-123'
|
|
|
|
|
|
class TestBotServiceCreateBot:
|
|
"""Tests for create_bot method."""
|
|
|
|
async def test_create_bot_max_limit_reached_raises(self):
|
|
"""Raises ValueError when max_bots limit reached."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
ap.instance_config = SimpleNamespace()
|
|
ap.instance_config.data = {
|
|
'system': {
|
|
'limitation': {
|
|
'max_bots': 2
|
|
}
|
|
}
|
|
}
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.load_bot = AsyncMock()
|
|
|
|
# Mock get_bots to return 2 bots already
|
|
bot1 = _create_mock_bot(bot_uuid='uuid-1')
|
|
bot2 = _create_mock_bot(bot_uuid='uuid-2')
|
|
mock_result = _create_mock_result([bot1, bot2])
|
|
ap.persistence_mgr.execute_async = AsyncMock(return_value=mock_result)
|
|
ap.persistence_mgr.serialize_model = Mock(
|
|
return_value={'uuid': 'uuid-1', 'name': 'Bot 1'}
|
|
)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute & Verify
|
|
with pytest.raises(ValueError, match='Maximum number of bots'):
|
|
await service.create_bot({'name': 'New Bot'})
|
|
|
|
async def test_create_bot_no_limit(self):
|
|
"""Creates bot without limit check when max_bots=-1."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
ap.instance_config = SimpleNamespace()
|
|
ap.instance_config.data = {
|
|
'system': {
|
|
'limitation': {
|
|
'max_bots': -1 # No limit
|
|
}
|
|
}
|
|
}
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.load_bot = AsyncMock()
|
|
|
|
# Mock pipeline query
|
|
pipeline_result = Mock()
|
|
pipeline_result.first = Mock(return_value=None)
|
|
# Mock bot query after insert
|
|
bot_result = Mock()
|
|
bot_result.first = Mock(return_value=_create_mock_bot())
|
|
|
|
call_count = 0
|
|
async def mock_execute(query):
|
|
nonlocal call_count
|
|
call_count += 1
|
|
if call_count <= 2:
|
|
return pipeline_result # First call: check pipeline
|
|
elif call_count == 3:
|
|
return Mock() # Insert
|
|
return bot_result # Get bot
|
|
|
|
ap.persistence_mgr.execute_async = AsyncMock(side_effect=mock_execute)
|
|
ap.persistence_mgr.serialize_model = Mock(
|
|
return_value={'uuid': 'new-uuid', 'name': 'New Bot'}
|
|
)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute
|
|
bot_uuid = await service.create_bot({'name': 'New Bot', 'adapter': 'telegram', 'adapter_config': {}})
|
|
|
|
# Verify
|
|
assert bot_uuid is not None
|
|
assert len(bot_uuid) == 36 # UUID format
|
|
|
|
async def test_create_bot_sets_default_pipeline(self):
|
|
"""Sets default pipeline when one exists."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
ap.instance_config = SimpleNamespace()
|
|
ap.instance_config.data = {'system': {'limitation': {'max_bots': -1}}}
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.load_bot = AsyncMock()
|
|
|
|
# Mock default pipeline
|
|
mock_pipeline = SimpleNamespace()
|
|
mock_pipeline.uuid = 'default-pipeline-uuid'
|
|
mock_pipeline.name = 'Default Pipeline'
|
|
pipeline_result = Mock()
|
|
pipeline_result.first = Mock(return_value=mock_pipeline)
|
|
|
|
# Mock bot after insert
|
|
bot_result = Mock()
|
|
bot_result.first = Mock(return_value=_create_mock_bot())
|
|
|
|
call_count = 0
|
|
async def mock_execute(query):
|
|
nonlocal call_count
|
|
call_count += 1
|
|
if call_count == 1:
|
|
return pipeline_result # Check default pipeline
|
|
elif call_count == 2:
|
|
return Mock() # Insert
|
|
return bot_result # Get bot
|
|
|
|
ap.persistence_mgr.execute_async = AsyncMock(side_effect=mock_execute)
|
|
ap.persistence_mgr.serialize_model = Mock(
|
|
return_value={
|
|
'uuid': 'new-uuid',
|
|
'name': 'New Bot',
|
|
'use_pipeline_uuid': 'default-pipeline-uuid',
|
|
'use_pipeline_name': 'Default Pipeline',
|
|
}
|
|
)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute
|
|
bot_data = {'name': 'New Bot', 'adapter': 'telegram', 'adapter_config': {}}
|
|
bot_uuid = await service.create_bot(bot_data)
|
|
|
|
# Verify - pipeline uuid and name were set
|
|
assert 'use_pipeline_uuid' in bot_data
|
|
assert 'use_pipeline_name' in bot_data
|
|
assert bot_uuid is not None # Verify UUID was returned
|
|
|
|
|
|
class TestBotServiceUpdateBot:
|
|
"""Tests for update_bot method."""
|
|
|
|
async def test_update_bot_removes_uuid_from_data(self):
|
|
"""Does not persist caller-provided uuid in update payload."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.remove_bot = AsyncMock()
|
|
|
|
# Mock pipeline query - not updating pipeline
|
|
ap.persistence_mgr.execute_async = AsyncMock()
|
|
ap.sess_mgr = SimpleNamespace()
|
|
ap.sess_mgr.session_list = []
|
|
|
|
service = BotService(ap)
|
|
service.get_bot = AsyncMock(return_value={'uuid': 'test-uuid', 'name': 'Updated'})
|
|
|
|
# Create mock runtime bot
|
|
runtime_bot = SimpleNamespace()
|
|
runtime_bot.enable = False
|
|
ap.platform_mgr.load_bot = AsyncMock(return_value=runtime_bot)
|
|
|
|
# Execute
|
|
update_data = {'uuid': 'should-be-removed', 'name': 'Updated Name'}
|
|
await service.update_bot('test-uuid', update_data)
|
|
|
|
update_params = ap.persistence_mgr.execute_async.await_args_list[0].args[0].compile().params
|
|
assert update_params['name'] == 'Updated Name'
|
|
assert 'should-be-removed' not in update_params.values()
|
|
|
|
async def test_update_bot_pipeline_not_found_raises(self):
|
|
"""Raises Exception when updating with nonexistent pipeline UUID."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
|
|
# Mock pipeline query returns None
|
|
pipeline_result = Mock()
|
|
pipeline_result.first = Mock(return_value=None)
|
|
ap.persistence_mgr.execute_async = AsyncMock(return_value=pipeline_result)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute & Verify
|
|
with pytest.raises(Exception, match='Pipeline not found'):
|
|
await service.update_bot('test-uuid', {'use_pipeline_uuid': 'nonexistent-pipeline'})
|
|
|
|
async def test_update_bot_sets_pipeline_name(self):
|
|
"""Sets use_pipeline_name when updating use_pipeline_uuid."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.remove_bot = AsyncMock()
|
|
|
|
# Mock pipeline query
|
|
mock_pipeline = SimpleNamespace()
|
|
mock_pipeline.name = 'Updated Pipeline'
|
|
pipeline_result = Mock()
|
|
pipeline_result.first = Mock(return_value=mock_pipeline)
|
|
|
|
call_count = 0
|
|
async def mock_execute(query):
|
|
nonlocal call_count
|
|
call_count += 1
|
|
if call_count == 1:
|
|
return pipeline_result
|
|
return Mock()
|
|
|
|
ap.persistence_mgr.execute_async = AsyncMock(side_effect=mock_execute)
|
|
ap.sess_mgr = SimpleNamespace()
|
|
ap.sess_mgr.session_list = []
|
|
|
|
service = BotService(ap)
|
|
service.get_bot = AsyncMock(return_value={'uuid': 'test-uuid'})
|
|
|
|
runtime_bot = SimpleNamespace()
|
|
runtime_bot.enable = False
|
|
ap.platform_mgr.load_bot = AsyncMock(return_value=runtime_bot)
|
|
|
|
# Execute
|
|
await service.update_bot('test-uuid', {'use_pipeline_uuid': 'pipeline-uuid'})
|
|
|
|
update_params = ap.persistence_mgr.execute_async.await_args_list[1].args[0].compile().params
|
|
assert update_params['use_pipeline_uuid'] == 'pipeline-uuid'
|
|
assert update_params['use_pipeline_name'] == 'Updated Pipeline'
|
|
|
|
|
|
class TestBotServiceDeleteBot:
|
|
"""Tests for delete_bot method."""
|
|
|
|
async def test_delete_bot_calls_remove_and_delete(self):
|
|
"""Calls both platform_mgr.remove_bot and persistence delete."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
ap.persistence_mgr.execute_async = AsyncMock()
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.remove_bot = AsyncMock()
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute
|
|
await service.delete_bot('test-uuid')
|
|
|
|
# Verify
|
|
ap.platform_mgr.remove_bot.assert_called_once_with('test-uuid')
|
|
ap.persistence_mgr.execute_async.assert_called_once()
|
|
|
|
async def test_delete_bot_nonexistent_uuid(self):
|
|
"""Delete operation completes even for nonexistent UUID."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = SimpleNamespace()
|
|
ap.persistence_mgr.execute_async = AsyncMock()
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.remove_bot = AsyncMock()
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute - should not raise
|
|
await service.delete_bot('nonexistent-uuid')
|
|
|
|
# Verify - both called regardless
|
|
ap.platform_mgr.remove_bot.assert_called_once()
|
|
|
|
|
|
class TestBotServiceListEventLogs:
|
|
"""Tests for list_event_logs method."""
|
|
|
|
async def test_list_event_logs_bot_not_found_raises(self):
|
|
"""Raises Exception when runtime bot not found."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.get_bot_by_uuid = AsyncMock(return_value=None)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute & Verify
|
|
with pytest.raises(Exception, match='Bot not found'):
|
|
await service.list_event_logs('nonexistent-uuid', 0, 10)
|
|
|
|
async def test_list_event_logs_returns_logs(self):
|
|
"""Returns logs from runtime bot logger."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.platform_mgr = SimpleNamespace()
|
|
|
|
# Mock runtime bot with logger
|
|
runtime_bot = SimpleNamespace()
|
|
runtime_bot.logger = SimpleNamespace()
|
|
runtime_bot.logger.get_logs = AsyncMock(return_value=(
|
|
[SimpleNamespace(to_json=Mock(return_value={'msg': 'log1'}))],
|
|
5
|
|
))
|
|
ap.platform_mgr.get_bot_by_uuid = AsyncMock(return_value=runtime_bot)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute
|
|
logs, total = await service.list_event_logs('bot-uuid', 0, 10)
|
|
|
|
# Verify
|
|
assert len(logs) == 1
|
|
assert logs[0] == {'msg': 'log1'}
|
|
assert total == 5
|
|
|
|
|
|
class TestBotServiceSendMessage:
|
|
"""Tests for send_message method."""
|
|
|
|
async def test_send_message_bot_not_found_raises(self):
|
|
"""Raises Exception when bot not found."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.platform_mgr = SimpleNamespace()
|
|
ap.platform_mgr.get_bot_by_uuid = AsyncMock(return_value=None)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute & Verify
|
|
with pytest.raises(Exception, match='Bot not found'):
|
|
await service.send_message('nonexistent-uuid', 'group', '123', {'test': 'data'})
|
|
|
|
async def test_send_message_invalid_message_chain_raises(self):
|
|
"""Raises Exception when message_chain_data is invalid."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.platform_mgr = SimpleNamespace()
|
|
|
|
runtime_bot = SimpleNamespace()
|
|
runtime_bot.adapter = SimpleNamespace()
|
|
runtime_bot.adapter.send_message = AsyncMock()
|
|
ap.platform_mgr.get_bot_by_uuid = AsyncMock(return_value=runtime_bot)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute & Verify - invalid format should raise
|
|
with pytest.raises(Exception, match='Invalid message_chain format'):
|
|
await service.send_message('bot-uuid', 'group', '123', {'invalid': 'format'})
|
|
|
|
async def test_send_message_valid_call(self):
|
|
"""Sends message through adapter when all valid."""
|
|
# Setup
|
|
ap = SimpleNamespace()
|
|
ap.platform_mgr = SimpleNamespace()
|
|
|
|
runtime_bot = SimpleNamespace()
|
|
runtime_bot.adapter = SimpleNamespace()
|
|
runtime_bot.adapter.send_message = AsyncMock()
|
|
ap.platform_mgr.get_bot_by_uuid = AsyncMock(return_value=runtime_bot)
|
|
|
|
service = BotService(ap)
|
|
|
|
# Execute with valid message chain format
|
|
message_chain_data = {
|
|
'messages': [
|
|
{'type': 'text', 'data': {'text': 'Hello'}}
|
|
]
|
|
}
|
|
|
|
# Patch the import location - the module imports inside the function
|
|
with patch('langbot_plugin.api.entities.builtin.platform.message.MessageChain') as MockMessageChain:
|
|
mock_chain = Mock()
|
|
MockMessageChain.model_validate = Mock(return_value=mock_chain)
|
|
await service.send_message('bot-uuid', 'group', '123', message_chain_data)
|
|
|
|
# Verify adapter.send_message was called
|
|
runtime_bot.adapter.send_message.assert_called_once_with('group', '123', mock_chain)
|