mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-09-16 14:57:15 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
374 lines
13 KiB
Python
374 lines
13 KiB
Python
from __future__ import annotations
|
|
|
|
import hashlib
|
|
import json
|
|
import re
|
|
from pathlib import PurePath
|
|
|
|
from ..core import app
|
|
from ..utils import bounded_executor
|
|
from ..api.http.authz import WorkspaceRequiredError
|
|
from ..api.http.context import ExecutionContext, RequestContext
|
|
from . import provider
|
|
from .providers import localstorage
|
|
|
|
|
|
_SAFE_OWNER_TYPE = re.compile(r'^[a-z][a-z0-9_-]{0,63}$')
|
|
_DEFAULT_OBJECT_READ_BYTES = 10 * 1024 * 1024
|
|
_SCOPED_KEY = re.compile(
|
|
r'^v1/(?P<instance>[a-f0-9]{24})/'
|
|
r'(?P<workspace>[0-9a-fA-F-]{36})/'
|
|
r'(?P<generation>[1-9][0-9]*)/'
|
|
r'(?P<owner_type>[a-z][a-z0-9_-]{0,63})/'
|
|
r'(?P<owner>[a-f0-9]{32})/'
|
|
r'(?P<key>[a-f0-9]{64})(?P<suffix>\.[a-zA-Z0-9]{1,16})?$'
|
|
)
|
|
|
|
|
|
class StorageMgr:
|
|
"""Storage manager"""
|
|
|
|
ap: app.Application
|
|
|
|
storage_provider: provider.StorageProvider
|
|
|
|
def __init__(self, ap: app.Application):
|
|
self.ap = ap
|
|
|
|
def _object_read_limit(self) -> int:
|
|
config = getattr(getattr(self.ap, 'instance_config', None), 'data', {})
|
|
try:
|
|
configured = int(
|
|
config.get('storage', {}).get(
|
|
'max_object_read_bytes',
|
|
_DEFAULT_OBJECT_READ_BYTES,
|
|
)
|
|
)
|
|
except (AttributeError, TypeError, ValueError):
|
|
configured = _DEFAULT_OBJECT_READ_BYTES
|
|
return min(max(configured, 1), provider.HARD_MAX_STORAGE_OBJECT_BYTES)
|
|
|
|
async def _load_object_bounded(self, object_key: str) -> bytes:
|
|
max_bytes = self._object_read_limit()
|
|
bounded_loader = getattr(self.storage_provider, 'load_bounded', None)
|
|
if callable(bounded_loader):
|
|
return await bounded_loader(object_key, max_bytes=max_bytes)
|
|
|
|
# Compatibility for lightweight and third-party providers. Built-in
|
|
# providers enforce the same bound in the actual read operation.
|
|
object_size = await self.storage_provider.size(object_key)
|
|
if object_size > max_bytes:
|
|
raise ValueError(f'Storage object exceeds the {max_bytes}-byte read limit')
|
|
value = await self.storage_provider.load(object_key)
|
|
if len(value) > max_bytes:
|
|
raise ValueError(f'Storage object exceeds the {max_bytes}-byte read limit')
|
|
return value
|
|
|
|
@staticmethod
|
|
def _require_execution_scope(
|
|
context: ExecutionContext | RequestContext,
|
|
) -> tuple[str, str, int]:
|
|
if not isinstance(context, (ExecutionContext, RequestContext)):
|
|
raise WorkspaceRequiredError('Storage operations require an explicit Workspace context')
|
|
instance_uuid = context.instance_uuid.strip()
|
|
workspace_uuid = context.workspace_uuid.strip()
|
|
generation = context.placement_generation
|
|
if not instance_uuid or not workspace_uuid:
|
|
raise WorkspaceRequiredError('Storage operations require an instance and Workspace')
|
|
if generation <= 0:
|
|
raise WorkspaceRequiredError('Storage operations require a positive placement generation')
|
|
return instance_uuid, workspace_uuid, generation
|
|
|
|
@staticmethod
|
|
def _digest(value: str, length: int) -> str:
|
|
return hashlib.sha256(value.encode('utf-8')).hexdigest()[:length]
|
|
|
|
async def _require_active_execution_scope(
|
|
self,
|
|
context: ExecutionContext | RequestContext,
|
|
) -> None:
|
|
"""Revalidate the captured generation before touching object storage."""
|
|
instance_uuid, workspace_uuid, generation = self._require_execution_scope(context)
|
|
workspace_service = getattr(self.ap, 'workspace_service', None)
|
|
if workspace_service is None:
|
|
raise WorkspaceRequiredError('Storage execution scope is unavailable')
|
|
try:
|
|
binding = await workspace_service.get_execution_binding(
|
|
workspace_uuid,
|
|
expected_generation=generation,
|
|
)
|
|
except Exception as exc:
|
|
raise WorkspaceRequiredError('Storage execution scope is unavailable') from exc
|
|
if (
|
|
getattr(binding, 'instance_uuid', None) != instance_uuid
|
|
or getattr(binding, 'workspace_uuid', None) != workspace_uuid
|
|
or getattr(binding, 'placement_generation', None) != generation
|
|
):
|
|
raise WorkspaceRequiredError('Storage execution scope is unavailable')
|
|
|
|
@classmethod
|
|
def canonical_binary_storage_key(
|
|
cls,
|
|
context: ExecutionContext | RequestContext,
|
|
*,
|
|
owner_type: str,
|
|
owner: str,
|
|
key: str,
|
|
) -> str:
|
|
"""Return a bounded canonical key over every BinaryStorage owner dimension."""
|
|
|
|
instance_uuid, workspace_uuid, _ = cls._require_execution_scope(context)
|
|
if not _SAFE_OWNER_TYPE.fullmatch(owner_type):
|
|
raise ValueError('Invalid storage owner_type')
|
|
if not owner or not key:
|
|
raise ValueError('Storage owner and key are required')
|
|
canonical = json.dumps(
|
|
[instance_uuid, workspace_uuid, owner_type, owner, key],
|
|
ensure_ascii=False,
|
|
separators=(',', ':'),
|
|
)
|
|
return f'v1:{cls._digest(instance_uuid, 24)}:{workspace_uuid}:{owner_type}:{hashlib.sha256(canonical.encode()).hexdigest()}'
|
|
|
|
@classmethod
|
|
def scoped_object_key(
|
|
cls,
|
|
context: ExecutionContext | RequestContext,
|
|
*,
|
|
owner_type: str,
|
|
owner: str,
|
|
key: str,
|
|
preserve_suffix: bool = True,
|
|
) -> str:
|
|
"""Build a non-enumerable object key with an explicit tenant boundary."""
|
|
|
|
instance_uuid, workspace_uuid, generation = cls._require_execution_scope(context)
|
|
if not _SAFE_OWNER_TYPE.fullmatch(owner_type):
|
|
raise ValueError('Invalid storage owner_type')
|
|
if not owner or not key:
|
|
raise ValueError('Storage owner and key are required')
|
|
suffix = PurePath(key).suffix.lower() if preserve_suffix else ''
|
|
if not re.fullmatch(r'\.[a-z0-9]{1,16}', suffix):
|
|
suffix = ''
|
|
return (
|
|
f'v1/{cls._digest(instance_uuid, 24)}/{workspace_uuid}/{generation}/'
|
|
f'{owner_type}/{cls._digest(owner, 32)}/{cls._digest(key, 64)}{suffix}'
|
|
)
|
|
|
|
@classmethod
|
|
def scoped_prefix(
|
|
cls,
|
|
context: ExecutionContext | RequestContext,
|
|
*,
|
|
owner_type: str | None = None,
|
|
) -> str:
|
|
instance_uuid, workspace_uuid, generation = cls._require_execution_scope(context)
|
|
prefix = f'v1/{cls._digest(instance_uuid, 24)}/{workspace_uuid}/{generation}/'
|
|
if owner_type is not None:
|
|
if not _SAFE_OWNER_TYPE.fullmatch(owner_type):
|
|
raise ValueError('Invalid storage owner_type')
|
|
prefix += f'{owner_type}/'
|
|
return prefix
|
|
|
|
async def save_scoped(
|
|
self,
|
|
context: ExecutionContext | RequestContext,
|
|
*,
|
|
owner_type: str,
|
|
owner: str,
|
|
key: str,
|
|
value: bytes,
|
|
preserve_suffix: bool = True,
|
|
) -> str:
|
|
await self._require_active_execution_scope(context)
|
|
max_bytes = self._object_read_limit()
|
|
if len(value) > max_bytes:
|
|
raise ValueError(f'Storage object exceeds the {max_bytes}-byte write limit')
|
|
object_key = self.scoped_object_key(
|
|
context,
|
|
owner_type=owner_type,
|
|
owner=owner,
|
|
key=key,
|
|
preserve_suffix=preserve_suffix,
|
|
)
|
|
await self.storage_provider.save(object_key, value)
|
|
return object_key
|
|
|
|
async def load_scoped(
|
|
self,
|
|
context: ExecutionContext | RequestContext,
|
|
*,
|
|
owner_type: str,
|
|
owner: str,
|
|
key: str,
|
|
preserve_suffix: bool = True,
|
|
) -> bytes:
|
|
await self._require_active_execution_scope(context)
|
|
object_key = self.scoped_object_key(
|
|
context,
|
|
owner_type=owner_type,
|
|
owner=owner,
|
|
key=key,
|
|
preserve_suffix=preserve_suffix,
|
|
)
|
|
return await self._load_object_bounded(object_key)
|
|
|
|
async def delete_scoped(
|
|
self,
|
|
context: ExecutionContext | RequestContext,
|
|
*,
|
|
owner_type: str,
|
|
owner: str,
|
|
key: str,
|
|
preserve_suffix: bool = True,
|
|
) -> None:
|
|
await self._require_active_execution_scope(context)
|
|
object_key = self.scoped_object_key(
|
|
context,
|
|
owner_type=owner_type,
|
|
owner=owner,
|
|
key=key,
|
|
preserve_suffix=preserve_suffix,
|
|
)
|
|
await self.storage_provider.delete(object_key)
|
|
|
|
async def resolve_public_object(
|
|
self,
|
|
object_key: str,
|
|
*,
|
|
expected_owner_type: str,
|
|
) -> bytes | None:
|
|
"""Load an opaque public object after validating its trusted scope."""
|
|
|
|
match = _SCOPED_KEY.fullmatch(object_key)
|
|
if match is None or match.group('owner_type') != expected_owner_type:
|
|
return None
|
|
if match.group('instance') != self._digest(self.ap.workspace_service.instance_uuid, 24):
|
|
return None
|
|
workspace_uuid = match.group('workspace')
|
|
generation = int(match.group('generation'))
|
|
with bounded_executor.blocking_work_scope(workspace_uuid):
|
|
try:
|
|
await self.ap.workspace_service.get_execution_binding(
|
|
workspace_uuid,
|
|
expected_generation=generation,
|
|
)
|
|
except Exception:
|
|
return None
|
|
if not await self.storage_provider.exists(object_key):
|
|
return None
|
|
return await self._load_object_bounded(object_key)
|
|
|
|
@classmethod
|
|
def require_scoped_object_key(
|
|
cls,
|
|
context: ExecutionContext | RequestContext,
|
|
object_key: str,
|
|
*,
|
|
expected_owner_type: str,
|
|
) -> None:
|
|
"""Validate an opaque object key against every captured scope field."""
|
|
|
|
instance_uuid, workspace_uuid, generation = cls._require_execution_scope(context)
|
|
match = _SCOPED_KEY.fullmatch(object_key)
|
|
if (
|
|
match is None
|
|
or match.group('instance') != cls._digest(instance_uuid, 24)
|
|
or match.group('workspace') != workspace_uuid
|
|
or int(match.group('generation')) != generation
|
|
or match.group('owner_type') != expected_owner_type
|
|
):
|
|
raise WorkspaceRequiredError('Object key does not belong to the execution scope')
|
|
|
|
async def exists_scoped_object_key(
|
|
self,
|
|
context: ExecutionContext | RequestContext,
|
|
object_key: str,
|
|
*,
|
|
expected_owner_type: str,
|
|
) -> bool:
|
|
await self._require_active_execution_scope(context)
|
|
self.require_scoped_object_key(
|
|
context,
|
|
object_key,
|
|
expected_owner_type=expected_owner_type,
|
|
)
|
|
return await self.storage_provider.exists(object_key)
|
|
|
|
async def load_scoped_object_key(
|
|
self,
|
|
context: ExecutionContext | RequestContext,
|
|
object_key: str,
|
|
*,
|
|
expected_owner_type: str,
|
|
) -> bytes:
|
|
await self._require_active_execution_scope(context)
|
|
self.require_scoped_object_key(
|
|
context,
|
|
object_key,
|
|
expected_owner_type=expected_owner_type,
|
|
)
|
|
return await self._load_object_bounded(object_key)
|
|
|
|
async def size_scoped_object_key(
|
|
self,
|
|
context: ExecutionContext | RequestContext,
|
|
object_key: str,
|
|
*,
|
|
expected_owner_type: str,
|
|
) -> int:
|
|
await self._require_active_execution_scope(context)
|
|
self.require_scoped_object_key(
|
|
context,
|
|
object_key,
|
|
expected_owner_type=expected_owner_type,
|
|
)
|
|
return await self.storage_provider.size(object_key)
|
|
|
|
async def delete_scoped_object_key(
|
|
self,
|
|
context: ExecutionContext | RequestContext,
|
|
object_key: str,
|
|
*,
|
|
expected_owner_type: str,
|
|
) -> None:
|
|
"""Delete a previously returned key only inside the captured scope."""
|
|
|
|
await self._require_active_execution_scope(context)
|
|
self.require_scoped_object_key(
|
|
context,
|
|
object_key,
|
|
expected_owner_type=expected_owner_type,
|
|
)
|
|
if await self.storage_provider.exists(object_key):
|
|
await self.storage_provider.delete(object_key)
|
|
|
|
@classmethod
|
|
def is_scoped_object_key(
|
|
cls,
|
|
object_key: str,
|
|
*,
|
|
expected_owner_type: str | None = None,
|
|
) -> bool:
|
|
match = _SCOPED_KEY.fullmatch(object_key)
|
|
return match is not None and (expected_owner_type is None or match.group('owner_type') == expected_owner_type)
|
|
|
|
async def initialize(self):
|
|
storage_config = self.ap.instance_config.data.get('storage', {})
|
|
storage_type = storage_config.get('use', 'local')
|
|
|
|
if storage_type == 's3':
|
|
from .providers import s3storage
|
|
|
|
self.storage_provider = s3storage.S3StorageProvider(self.ap)
|
|
self.ap.logger.info('Initialized S3 storage backend.')
|
|
else:
|
|
self.storage_provider = localstorage.LocalStorageProvider(self.ap)
|
|
self.ap.logger.info('Initialized local storage backend.')
|
|
|
|
await self.storage_provider.initialize()
|
|
|
|
async def shutdown(self) -> None:
|
|
storage_provider = getattr(self, 'storage_provider', None)
|
|
if storage_provider is not None:
|
|
await storage_provider.shutdown()
|