mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-09 12:40:59 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
224 lines
6.7 KiB
Python
224 lines
6.7 KiB
Python
"""Tests for Lark adapter helper behavior."""
|
||
|
||
import threading
|
||
from unittest.mock import MagicMock
|
||
|
||
import pytest
|
||
|
||
from langbot.pkg.platform.sources.lark import (
|
||
LarkAdapter,
|
||
_decode_lark_base64_limited,
|
||
_lark_clean_form_content,
|
||
_lark_completed_input_lines,
|
||
_lark_current_input_defs,
|
||
_lark_extract_action_form_inputs,
|
||
_lark_should_update_stream_element,
|
||
_lark_visible_form_content,
|
||
)
|
||
|
||
|
||
def test_lark_base64_decode_is_bounded(monkeypatch):
|
||
import langbot.pkg.platform.sources.lark as lark_module
|
||
|
||
monkeypatch.setattr(lark_module, '_MAX_LARK_MEDIA_BYTES', 4)
|
||
|
||
with pytest.raises(ValueError, match='exceeds'):
|
||
_decode_lark_base64_limited('A' * 12)
|
||
|
||
|
||
def test_lark_threadsafe_callbacks_are_bounded():
|
||
adapter = LarkAdapter.model_construct()
|
||
adapter.threadsafe_event_lock = threading.Lock()
|
||
adapter.threadsafe_event_futures = {MagicMock(done=MagicMock(return_value=False)) for _ in range(100)}
|
||
|
||
async def callback():
|
||
raise AssertionError('rejected callback must not run')
|
||
|
||
assert adapter._schedule_threadsafe_event(callback()) is None
|
||
assert len(adapter.threadsafe_event_futures) == 100
|
||
|
||
|
||
def test_lark_current_input_defs_only_returns_active_stage():
|
||
input_defs = [
|
||
{'output_variable_name': 'us_input', 'type': 'paragraph'},
|
||
{'output_variable_name': 'xiala', 'type': 'select'},
|
||
]
|
||
|
||
assert _lark_current_input_defs(
|
||
{
|
||
'_current_input_field': 'xiala',
|
||
'input_defs': input_defs,
|
||
}
|
||
) == [input_defs[1]]
|
||
assert (
|
||
_lark_current_input_defs(
|
||
{
|
||
'_action_select_only': True,
|
||
'input_defs': input_defs,
|
||
}
|
||
)
|
||
== []
|
||
)
|
||
|
||
|
||
def test_lark_form_field_elements_only_render_active_stage():
|
||
adapter = LarkAdapter.model_construct()
|
||
form_data = {
|
||
'_current_input_field': 'xiala',
|
||
'input_defs': [
|
||
{'output_variable_name': 'us_input', 'type': 'paragraph'},
|
||
{
|
||
'output_variable_name': 'xiala',
|
||
'type': 'select',
|
||
'option_source': {'type': 'constant', 'value': ['1', '2']},
|
||
},
|
||
],
|
||
}
|
||
|
||
elements, input_name_map, file_help_lines = adapter._build_lark_form_field_elements(form_data)
|
||
|
||
assert len(elements) == 1
|
||
assert elements[0]['tag'] == 'select_static'
|
||
assert elements[0]['label']['content'] == 'xiala'
|
||
assert list(input_name_map.values()) == ['xiala']
|
||
assert file_help_lines == []
|
||
|
||
|
||
def test_lark_form_stage_skips_closed_streaming_element_update():
|
||
assert not _lark_should_update_stream_element(
|
||
resume_from=False,
|
||
form_data={'_current_input_field': 'xiala'},
|
||
msg_seq=1,
|
||
is_final=True,
|
||
)
|
||
assert _lark_should_update_stream_element(
|
||
resume_from=False,
|
||
form_data=None,
|
||
msg_seq=1,
|
||
is_final=True,
|
||
)
|
||
|
||
|
||
def test_lark_final_action_stage_interleaves_prompts_and_completed_values():
|
||
form_content = _lark_visible_form_content(
|
||
{
|
||
'_action_select_only': True,
|
||
'raw_form_content': ('11\nQuestion\n{{#$output.us_input#}}\nChoose an answer\n{{#$output.xiala#}}\n'),
|
||
'all_input_defs': [
|
||
{'output_variable_name': 'us_input', 'type': 'paragraph'},
|
||
{'output_variable_name': 'xiala', 'type': 'select'},
|
||
],
|
||
'inputs': {'us_input': 'hello', 'xiala': '2'},
|
||
}
|
||
)
|
||
|
||
assert '{{#$output.' not in form_content
|
||
assert form_content.startswith('11\nQuestion')
|
||
assert form_content.index('Question') < form_content.index('us_input')
|
||
assert form_content.index('us_input') < form_content.index('Choose an answer')
|
||
assert form_content.index('Choose an answer') < form_content.index('xiala')
|
||
|
||
|
||
def test_lark_completed_input_lines_include_text_select_and_files():
|
||
lines = _lark_completed_input_lines(
|
||
{
|
||
'all_input_defs': [
|
||
{'output_variable_name': 'us_input', 'type': 'paragraph'},
|
||
{'output_variable_name': 'xiala', 'type': 'select'},
|
||
{'output_variable_name': 'files', 'type': 'file-list'},
|
||
],
|
||
'inputs': {
|
||
'us_input': '你好',
|
||
'xiala': 'or',
|
||
'files': [{'upload_file_id': 'file-1'}, {'upload_file_id': 'file-2'}],
|
||
},
|
||
}
|
||
)
|
||
|
||
assert lines == [
|
||
'✅ us_input:你好',
|
||
'✅ xiala:or',
|
||
'✅ files:2 file(s)',
|
||
]
|
||
|
||
|
||
def test_lark_clean_form_content_removes_all_input_placeholders():
|
||
content = _lark_clean_form_content(
|
||
'人工介入\n\n{{#$output.us_input#}}\n\n{{#$output.xiala#}}\n',
|
||
[
|
||
{'output_variable_name': 'us_input', 'type': 'paragraph'},
|
||
{'output_variable_name': 'xiala', 'type': 'select'},
|
||
],
|
||
)
|
||
|
||
assert content == '人工介入'
|
||
|
||
|
||
def test_lark_extract_action_form_inputs_from_json_form_value():
|
||
class Action:
|
||
form_value = '{"Input_1_us_input_abcd12": "hello", "Select_2_xiala_abcd12": "B"}'
|
||
input_value = None
|
||
option = None
|
||
name = None
|
||
|
||
inputs = _lark_extract_action_form_inputs(
|
||
Action(),
|
||
{
|
||
'input_name_map': {
|
||
'Input_1_us_input_abcd12': 'us_input',
|
||
'Select_2_xiala_abcd12': 'xiala',
|
||
}
|
||
},
|
||
)
|
||
|
||
assert inputs == {'us_input': 'hello', 'xiala': 'B'}
|
||
|
||
|
||
def test_lark_extract_action_form_inputs_from_webhook_dict_action():
|
||
inputs = _lark_extract_action_form_inputs(
|
||
{
|
||
'form_value': {
|
||
'Input_1_us_input_abcd12': 'hello',
|
||
'Select_2_xiala_abcd12': {'value': 'B', 'text': {'content': 'Option B'}},
|
||
}
|
||
},
|
||
{
|
||
'input_name_map': {
|
||
'Input_1_us_input_abcd12': 'us_input',
|
||
'Select_2_xiala_abcd12': 'xiala',
|
||
}
|
||
},
|
||
)
|
||
|
||
assert inputs == {'us_input': 'hello', 'xiala': {'value': 'B', 'text': {'content': 'Option B'}}}
|
||
|
||
|
||
def test_lark_extract_action_form_inputs_maps_dotted_component_names():
|
||
inputs = _lark_extract_action_form_inputs(
|
||
{
|
||
'form_value': {
|
||
'Form_1_token_abcd12.Input_1_us_input_abcd12': 'hello',
|
||
}
|
||
},
|
||
{
|
||
'input_name_map': {
|
||
'Input_1_us_input_abcd12': 'us_input',
|
||
}
|
||
},
|
||
)
|
||
|
||
assert inputs == {'us_input': 'hello'}
|
||
|
||
|
||
def test_lark_completed_input_lines_display_select_value_from_object():
|
||
lines = _lark_completed_input_lines(
|
||
{
|
||
'all_input_defs': [
|
||
{'output_variable_name': 'xiala', 'type': 'select'},
|
||
],
|
||
'inputs': {'xiala': {'value': 'B', 'text': {'content': 'Option B'}}},
|
||
}
|
||
)
|
||
|
||
assert lines == ['✅ xiala:B']
|