mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-09 12:40:59 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
122 lines
4.5 KiB
Python
122 lines
4.5 KiB
Python
from __future__ import annotations
|
|
|
|
import asyncio
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock
|
|
|
|
import pytest
|
|
import sqlalchemy as sa
|
|
from sqlalchemy.ext.asyncio import create_async_engine
|
|
|
|
from langbot.pkg.api.http.service.apikey import ApiKeyIdentity
|
|
from langbot.pkg.api.mcp.context import get_request_context
|
|
from langbot.pkg.api.mcp.mount import MCPMount
|
|
from langbot.pkg.persistence.mgr import PersistenceManager, PersistenceMode
|
|
from langbot.pkg.persistence.tenant_uow import PersistenceScopeKind
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_mcp_mount_keeps_request_context_but_no_session_during_stream_wait(tmp_path) -> None:
|
|
engine = create_async_engine(f'sqlite+aiosqlite:///{tmp_path / "mcp-short-scope.db"}')
|
|
table = sa.Table('mcp_scope_probe', sa.MetaData(), sa.Column('id', sa.Integer, primary_key=True))
|
|
manager = PersistenceManager(object(), mode=PersistenceMode.CLOUD_RUNTIME)
|
|
manager.db = SimpleNamespace(get_engine=lambda: engine)
|
|
checked_out = 0
|
|
|
|
def on_checkout(*_args):
|
|
nonlocal checked_out
|
|
checked_out += 1
|
|
|
|
def on_checkin(*_args):
|
|
nonlocal checked_out
|
|
checked_out -= 1
|
|
|
|
sa.event.listen(engine.sync_engine, 'checkout', on_checkout)
|
|
sa.event.listen(engine.sync_engine, 'checkin', on_checkin)
|
|
try:
|
|
async with engine.begin() as conn:
|
|
await conn.run_sync(table.metadata.create_all)
|
|
|
|
identity = ApiKeyIdentity(
|
|
instance_uuid='instance-1',
|
|
workspace_uuid='workspace-1',
|
|
placement_generation=7,
|
|
api_key_uuid='key-1',
|
|
permissions=frozenset({'pipelines:read'}),
|
|
)
|
|
app = SimpleNamespace(
|
|
apikey_service=SimpleNamespace(authenticate_api_key=AsyncMock(return_value=identity)),
|
|
persistence_mgr=manager,
|
|
deployment_admission=None,
|
|
deployment=None,
|
|
)
|
|
stream_waiting = asyncio.Event()
|
|
release_stream = asyncio.Event()
|
|
observations: list[tuple[str, str, bool]] = []
|
|
|
|
async def fake_mcp_asgi(scope, receive, send):
|
|
del scope, receive
|
|
context = get_request_context()
|
|
assert manager.current_scope().kind is PersistenceScopeKind.WORKSPACE
|
|
assert manager.current_session() is None
|
|
await manager.execute_async(sa.select(table.c.id))
|
|
assert manager.current_session() is None
|
|
observations.append((context.request_id, context.workspace_uuid, manager.current_session() is None))
|
|
stream_waiting.set()
|
|
await release_stream.wait()
|
|
preserved_context = get_request_context()
|
|
observations.append(
|
|
(
|
|
preserved_context.request_id,
|
|
preserved_context.workspace_uuid,
|
|
manager.current_session() is None,
|
|
)
|
|
)
|
|
await manager.execute_async(sa.select(table.c.id))
|
|
assert manager.current_session() is None
|
|
await send({'type': 'http.response.start', 'status': 200, 'headers': []})
|
|
await send({'type': 'http.response.body', 'body': b'{}'})
|
|
|
|
async def unused_quart_asgi(scope, receive, send):
|
|
del scope, receive, send
|
|
raise AssertionError('MCP request was routed to Quart')
|
|
|
|
mount = MCPMount.__new__(MCPMount)
|
|
mount.ap = app
|
|
mount._mcp_asgi = fake_mcp_asgi
|
|
sent_messages: list[dict] = []
|
|
|
|
async def receive():
|
|
return {'type': 'http.request', 'body': b'', 'more_body': False}
|
|
|
|
async def send(message):
|
|
sent_messages.append(message)
|
|
|
|
async def release_after_observation() -> None:
|
|
await asyncio.wait_for(stream_waiting.wait(), timeout=2)
|
|
assert checked_out == 0
|
|
release_stream.set()
|
|
|
|
release_task = asyncio.create_task(release_after_observation())
|
|
await mount.wrap(unused_quart_asgi)(
|
|
{
|
|
'type': 'http',
|
|
'path': '/mcp',
|
|
'headers': [(b'x-api-key', b'secret')],
|
|
},
|
|
receive,
|
|
send,
|
|
)
|
|
await release_task
|
|
|
|
assert sent_messages[0]['status'] == 200
|
|
assert len(observations) == 2
|
|
assert observations[0] == observations[1]
|
|
assert observations[0][1:] == ('workspace-1', True)
|
|
assert checked_out == 0
|
|
assert manager.current_scope() is None
|
|
with pytest.raises(RuntimeError, match='context is unavailable'):
|
|
get_request_context()
|
|
finally:
|
|
await engine.dispose()
|