mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-07 03:46:38 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
240 lines
9.3 KiB
Python
240 lines
9.3 KiB
Python
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import os
|
|
import typing
|
|
|
|
import quart
|
|
import quart_cors
|
|
from werkzeug.exceptions import RequestEntityTooLarge
|
|
|
|
from ....core import app, entities as core_entities
|
|
from ....utils import importutil
|
|
|
|
from . import groups
|
|
from . import group
|
|
from .groups import provider as groups_provider
|
|
from .groups import platform as groups_platform
|
|
from .groups import pipelines as groups_pipelines
|
|
from .groups import knowledge as groups_knowledge
|
|
from .groups import resources as groups_resources
|
|
from ...mcp.mount import MCPMount
|
|
|
|
importutil.import_modules_in_pkg(groups)
|
|
importutil.import_modules_in_pkg(groups_provider)
|
|
importutil.import_modules_in_pkg(groups_platform)
|
|
importutil.import_modules_in_pkg(groups_pipelines)
|
|
importutil.import_modules_in_pkg(groups_knowledge)
|
|
importutil.import_modules_in_pkg(groups_resources)
|
|
|
|
|
|
class BoundedJSONRequest(quart.Request):
|
|
"""Parse bounded HTTP JSON bodies outside the shared event loop."""
|
|
|
|
async def get_json(
|
|
self,
|
|
force: bool = False,
|
|
silent: bool = False,
|
|
cache: bool = True,
|
|
) -> typing.Any:
|
|
# Keep Quart's cache and error semantics, changing only where the
|
|
# potentially 10 MiB JSON decoder runs. The RouterGroup establishes a
|
|
# trusted Workspace blocking-work scope before calling route handlers.
|
|
if cache and self._cached_json[silent] is not Ellipsis:
|
|
return self._cached_json[silent]
|
|
if not (force or self.is_json):
|
|
return None
|
|
|
|
data = await self.get_data(cache=cache, as_text=False)
|
|
try:
|
|
result = await asyncio.to_thread(self.json_module.loads, data)
|
|
except ValueError as error:
|
|
if silent:
|
|
result = None
|
|
else:
|
|
result = self.on_json_loading_failed(error)
|
|
|
|
if cache:
|
|
self._cached_json[silent] = result
|
|
return result
|
|
|
|
|
|
class HTTPController:
|
|
ap: app.Application
|
|
|
|
quart_app: quart.Quart
|
|
|
|
def __init__(self, ap: app.Application) -> None:
|
|
self.ap = ap
|
|
self.quart_app = quart.Quart(__name__)
|
|
self.quart_app.request_class = BoundedJSONRequest
|
|
quart_cors.cors(self.quart_app, allow_origin='*')
|
|
|
|
# Set maximum content length to prevent large file uploads
|
|
self.quart_app.config['MAX_CONTENT_LENGTH'] = group.MAX_FILE_SIZE
|
|
|
|
# MCP server (mounted at /mcp, see ..mcp.mount). Built lazily in
|
|
# initialize() so the service layer is ready.
|
|
self.mcp_mount: MCPMount | None = None
|
|
|
|
async def initialize(self) -> None:
|
|
# Register custom error handler for file size limit
|
|
@self.quart_app.errorhandler(RequestEntityTooLarge)
|
|
async def handle_request_entity_too_large(e):
|
|
return quart.jsonify(
|
|
{
|
|
'code': 400,
|
|
'msg': 'File size exceeds 10MB limit. Please split large files into smaller parts.',
|
|
}
|
|
), 400
|
|
|
|
await self.register_routes()
|
|
|
|
# Build the MCP server and start its session-manager lifespan in the
|
|
# background so the streamable-HTTP transport is ready to serve.
|
|
self.mcp_mount = MCPMount(self.ap)
|
|
await self.mcp_mount.start_session_manager()
|
|
self.ap.logger.info('LangBot MCP server mounted at /mcp (API-key authenticated).')
|
|
|
|
async def run(self) -> None:
|
|
if True:
|
|
|
|
async def shutdown_trigger_placeholder():
|
|
while True:
|
|
await asyncio.sleep(1)
|
|
|
|
async def exception_handler(*args, **kwargs):
|
|
try:
|
|
await self._run_task(*args, **kwargs)
|
|
except Exception as e:
|
|
self.ap.logger.error(f'Failed to start HTTP service: {e}')
|
|
|
|
self.ap.task_mgr.create_task(
|
|
exception_handler(
|
|
host='0.0.0.0',
|
|
port=self.ap.instance_config.data['api']['port'],
|
|
shutdown_trigger=shutdown_trigger_placeholder,
|
|
),
|
|
name='http-api-quart',
|
|
scopes=[core_entities.LifecycleControlScope.APPLICATION],
|
|
)
|
|
|
|
# await asyncio.sleep(5)
|
|
|
|
async def _run_task(self, host: str, port: int, shutdown_trigger) -> None:
|
|
"""Serve the Quart app, fronted by the MCP dispatcher at /mcp.
|
|
|
|
Mirrors Quart.run_task() but wraps the ASGI app so MCP requests are
|
|
intercepted before Quart's router. Falls back to plain Quart if the
|
|
MCP mount failed to build for any reason.
|
|
"""
|
|
from hypercorn.config import Config as HyperConfig
|
|
from hypercorn.asyncio import serve as hypercorn_serve
|
|
|
|
config = HyperConfig()
|
|
config.access_log_format = '%(h)s %(r)s %(s)s %(b)s %(D)s'
|
|
config.accesslog = '-'
|
|
config.bind = [f'{host}:{port}']
|
|
config.errorlog = config.accesslog
|
|
config.websocket_max_message_size = group.MAX_FILE_SIZE
|
|
|
|
asgi_app = self.quart_app
|
|
if self.mcp_mount is not None:
|
|
asgi_app = self.mcp_mount.wrap(self.quart_app)
|
|
|
|
await hypercorn_serve(asgi_app, config, shutdown_trigger=shutdown_trigger)
|
|
|
|
async def register_routes(self) -> None:
|
|
@self.quart_app.route('/healthz')
|
|
async def healthz():
|
|
get_resource_stats = getattr(
|
|
self.ap,
|
|
'get_runtime_resource_stats',
|
|
None,
|
|
)
|
|
return {
|
|
'code': 0,
|
|
'msg': 'ok',
|
|
'resources': (get_resource_stats() if callable(get_resource_stats) else {}),
|
|
}
|
|
|
|
for g in group.preregistered_groups:
|
|
ginst = g(self.ap, self.quart_app)
|
|
await ginst.initialize()
|
|
|
|
from ....utils import paths
|
|
|
|
frontend_path = paths.get_frontend_path()
|
|
|
|
@self.quart_app.route('/')
|
|
async def index():
|
|
response = await quart.send_from_directory(frontend_path, 'index.html', mimetype='text/html')
|
|
response.headers['Cache-Control'] = 'no-cache, no-store, must-revalidate'
|
|
response.headers['Pragma'] = 'no-cache'
|
|
response.headers['Expires'] = '0'
|
|
return response
|
|
|
|
@self.quart_app.route('/<path:path>')
|
|
async def static_file(path: str):
|
|
if not (
|
|
os.path.exists(os.path.join(frontend_path, path)) and os.path.isfile(os.path.join(frontend_path, path))
|
|
):
|
|
if os.path.exists(os.path.join(frontend_path, path + '.html')):
|
|
path += '.html'
|
|
elif not path.startswith('api/'):
|
|
# SPA fallback: serve index.html for all non-API, non-static routes
|
|
# so that React Router can handle client-side routing (Vite SPA).
|
|
# For /home/* sub-routes, first try parent .html files (pre-rendered pages).
|
|
if path.startswith('home/'):
|
|
segments = path.rstrip('/').split('/')
|
|
for i in range(len(segments) - 1, 0, -1):
|
|
parent_path = '/'.join(segments[:i]) + '.html'
|
|
if os.path.exists(os.path.join(frontend_path, parent_path)):
|
|
response = await quart.send_from_directory(
|
|
frontend_path, parent_path, mimetype='text/html'
|
|
)
|
|
response.headers['Cache-Control'] = 'no-cache, no-store, must-revalidate'
|
|
response.headers['Pragma'] = 'no-cache'
|
|
response.headers['Expires'] = '0'
|
|
return response
|
|
|
|
# Fallback to index.html for SPA client-side routing
|
|
response = await quart.send_from_directory(frontend_path, 'index.html', mimetype='text/html')
|
|
response.headers['Cache-Control'] = 'no-cache, no-store, must-revalidate'
|
|
response.headers['Pragma'] = 'no-cache'
|
|
response.headers['Expires'] = '0'
|
|
return response
|
|
else:
|
|
return await quart.send_from_directory(frontend_path, '404.html')
|
|
|
|
mimetype = None
|
|
|
|
if path.endswith('.html'):
|
|
mimetype = 'text/html'
|
|
elif path.endswith('.js'):
|
|
mimetype = 'application/javascript'
|
|
elif path.endswith('.css'):
|
|
mimetype = 'text/css'
|
|
elif path.endswith('.png'):
|
|
mimetype = 'image/png'
|
|
elif path.endswith('.jpg'):
|
|
mimetype = 'image/jpeg'
|
|
elif path.endswith('.jpeg'):
|
|
mimetype = 'image/jpeg'
|
|
elif path.endswith('.gif'):
|
|
mimetype = 'image/gif'
|
|
elif path.endswith('.svg'):
|
|
mimetype = 'image/svg+xml'
|
|
elif path.endswith('.ico'):
|
|
mimetype = 'image/x-icon'
|
|
elif path.endswith('.json'):
|
|
mimetype = 'application/json'
|
|
elif path.endswith('.txt'):
|
|
mimetype = 'text/plain'
|
|
|
|
response = await quart.send_from_directory(frontend_path, path, mimetype=mimetype)
|
|
response.headers['Cache-Control'] = 'no-cache, no-store, must-revalidate'
|
|
response.headers['Pragma'] = 'no-cache'
|
|
response.headers['Expires'] = '0'
|
|
return response
|