mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-09-22 17:36:59 +08:00
TyperBody
163dac48b0
Addresses review feedback on the marketplace installed-state change. - Progress: byte-derived progress no longer has time-based drift layered on top, and fallback drift is clamped to the current stage range, so the bar cannot exceed the download band. 90/100 bytes at 40s elapsed used to report 61% against a declared 5-45% band; it now reports 41%. Drift is measured from when the stage was entered rather than from task start. - Skills: a marketplace skill is no longer reported installed from a bare skill name. The backend names skills from their own SKILL.md and records no publisher, so alice/review and bob/review install identically; matching the bare name marked every publisher's skill as installed. Skill cards now resolve to not-installed until the installed skill carries a publisher. - Stages: "installing plugin dependencies" and "launching plugin" described work this task context cannot observe (installation persistence ran under the former; the runtime installs dependencies and starts the plugin inside apply_plugin_installation under the latter). They become "persisting the installation" and "installing or starting plugin", and the frontend maps that combined step to the dependency stage rather than the launch stage. - Removed the per-dependency progress fields: the backend never populated them, so the UI could never have displayed them. The stage mapping and progress maths move to install-progress.ts, and the installed-state matching to a React-free marketplace-installed.ts, so both are covered by executable tests (+9). Verified: ruff, tsc --noEmit, prettier --check, eslint (0 errors), 98/98 unit tests.
122 lines
3.2 KiB
JavaScript
122 lines
3.2 KiB
JavaScript
import assert from 'node:assert/strict';
|
|
import fs from 'node:fs';
|
|
import path from 'node:path';
|
|
import test from 'node:test';
|
|
import { createRequire } from 'node:module';
|
|
import { fileURLToPath } from 'node:url';
|
|
import ts from 'typescript';
|
|
|
|
const currentDirectory = path.dirname(fileURLToPath(import.meta.url));
|
|
const sourcePath = path.resolve(
|
|
currentDirectory,
|
|
'../../src/app/home/plugins/components/plugin-market/marketplace-installed.ts',
|
|
);
|
|
const source = fs.readFileSync(sourcePath, 'utf8');
|
|
const compiled = ts.transpileModule(source, {
|
|
compilerOptions: { module: ts.ModuleKind.CommonJS },
|
|
}).outputText;
|
|
const sourceRequire = createRequire(sourcePath);
|
|
const loadedModule = { exports: {} };
|
|
new Function('require', 'module', 'exports', compiled)(
|
|
sourceRequire,
|
|
loadedModule,
|
|
loadedModule.exports,
|
|
);
|
|
|
|
const { buildInstalledIndex, resolveInstalledState, installedExtensionKey } =
|
|
loadedModule.exports;
|
|
|
|
test('matches installed plugins by author and name', () => {
|
|
const index = buildInstalledIndex(
|
|
[{ id: 'alice/review', hasUpdate: true }],
|
|
[],
|
|
[],
|
|
);
|
|
|
|
assert.deepEqual(
|
|
resolveInstalledState(index, {
|
|
type: 'plugin',
|
|
author: 'alice',
|
|
pluginName: 'review',
|
|
}),
|
|
{ installed: true, hasUpdate: true },
|
|
);
|
|
assert.deepEqual(
|
|
resolveInstalledState(index, {
|
|
type: 'plugin',
|
|
author: 'bob',
|
|
pluginName: 'review',
|
|
}),
|
|
{ installed: false, hasUpdate: false },
|
|
'a different publisher must not match',
|
|
);
|
|
});
|
|
|
|
test('normalises MCP servers from `author__name` to `author/name`', () => {
|
|
const index = buildInstalledIndex([], [{ id: 'acme__search' }], []);
|
|
|
|
assert.equal(
|
|
resolveInstalledState(index, {
|
|
type: 'mcp',
|
|
author: 'acme',
|
|
pluginName: 'search',
|
|
}).installed,
|
|
true,
|
|
);
|
|
assert.equal(
|
|
resolveInstalledState(index, {
|
|
type: 'mcp',
|
|
author: 'other',
|
|
pluginName: 'search',
|
|
}).installed,
|
|
false,
|
|
);
|
|
});
|
|
|
|
test('does not mark skills installed from a bare name', () => {
|
|
// Two publishers ship a skill that both install as the plain name
|
|
// `review`; the sidebar records no publisher for either.
|
|
const index = buildInstalledIndex([], [], [{ id: 'review' }]);
|
|
|
|
const alice = resolveInstalledState(index, {
|
|
type: 'skill',
|
|
author: 'alice',
|
|
pluginName: 'review',
|
|
});
|
|
const bob = resolveInstalledState(index, {
|
|
type: 'skill',
|
|
author: 'bob',
|
|
pluginName: 'review',
|
|
});
|
|
|
|
assert.equal(
|
|
alice.installed,
|
|
false,
|
|
'alice/review must not be reported installed from a bare skill name',
|
|
);
|
|
assert.equal(
|
|
bob.installed,
|
|
false,
|
|
'bob/review must not be reported installed from a bare skill name',
|
|
);
|
|
});
|
|
|
|
test('keeps extension kinds separate for identical identities', () => {
|
|
const index = buildInstalledIndex([{ id: 'alice/toolkit' }], [], []);
|
|
|
|
assert.equal(
|
|
resolveInstalledState(index, {
|
|
type: 'mcp',
|
|
author: 'alice',
|
|
pluginName: 'toolkit',
|
|
}).installed,
|
|
false,
|
|
'a plugin must not mark the same-named MCP server as installed',
|
|
);
|
|
assert.equal(
|
|
installedExtensionKey(undefined, 'alice', 'toolkit'),
|
|
'plugin:alice/toolkit',
|
|
'a missing type must default to plugin',
|
|
);
|
|
});
|