mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-14 22:40:59 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
237 lines
7.4 KiB
TypeScript
237 lines
7.4 KiB
TypeScript
import { useEffect, useState } from 'react';
|
|
import { useNavigate } from 'react-router-dom';
|
|
import { useTranslation } from 'react-i18next';
|
|
import { toast } from 'sonner';
|
|
import { Button } from '@/components/ui/button';
|
|
import { Badge } from '@/components/ui/badge';
|
|
import {
|
|
Card,
|
|
CardContent,
|
|
CardDescription,
|
|
CardHeader,
|
|
CardTitle,
|
|
} from '@/components/ui/card';
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
} from '@/components/ui/dialog';
|
|
import { useSidebarData } from '@/app/home/components/home-sidebar/SidebarDataContext';
|
|
import { httpClient } from '@/app/infra/http/HttpClient';
|
|
import SkillForm from '@/app/home/skills/components/skill-form/SkillForm';
|
|
import { BoxUnavailableNotice } from '@/app/home/components/BoxUnavailableNotice';
|
|
import { useBoxStatus } from '@/app/infra/hooks/useBoxStatus';
|
|
import { Sparkles, Trash2 } from 'lucide-react';
|
|
import { useCurrentWorkspace } from '@/app/infra/http';
|
|
|
|
export default function SkillDetailContent({ id }: { id: string }) {
|
|
const isCreateMode = id === 'new';
|
|
const navigate = useNavigate();
|
|
const { t } = useTranslation();
|
|
const currentWorkspace = useCurrentWorkspace();
|
|
const canManage =
|
|
currentWorkspace?.permissions.includes('resource.manage') ?? false;
|
|
const { refreshSkills, skills, setDetailEntityName } = useSidebarData();
|
|
const [showDeleteConfirm, setShowDeleteConfirm] = useState(false);
|
|
const skill = skills.find((item) => item.id === id);
|
|
const {
|
|
available: boxAvailable,
|
|
hint: boxHint,
|
|
reason: boxReason,
|
|
} = useBoxStatus();
|
|
|
|
useEffect(() => {
|
|
if (isCreateMode) {
|
|
setDetailEntityName(t('skills.createSkill'));
|
|
} else {
|
|
setDetailEntityName(skill?.name ?? id);
|
|
}
|
|
return () => setDetailEntityName(null);
|
|
}, [id, isCreateMode, setDetailEntityName, skill, t]);
|
|
|
|
function handleImportedSkills(skillNames: string[]) {
|
|
void refreshSkills();
|
|
const primarySkill = skillNames[0];
|
|
if (primarySkill) {
|
|
navigate(`/home/skills?id=${encodeURIComponent(primarySkill)}`);
|
|
return;
|
|
}
|
|
navigate('/home/skills');
|
|
}
|
|
|
|
function handleSkillUpdated() {
|
|
void refreshSkills();
|
|
}
|
|
|
|
async function confirmDelete() {
|
|
try {
|
|
await httpClient.deleteSkill(id);
|
|
toast.success(t('skills.deleteSuccess'));
|
|
setShowDeleteConfirm(false);
|
|
void refreshSkills();
|
|
navigate('/home/skills');
|
|
} catch (error) {
|
|
toast.error(t('skills.deleteError') + String(error));
|
|
}
|
|
}
|
|
|
|
if (isCreateMode) {
|
|
return (
|
|
<div className="flex h-full flex-col">
|
|
<div className="flex shrink-0 flex-col gap-3 pb-4 sm:flex-row sm:items-start sm:justify-between">
|
|
<div className="min-w-0 space-y-1">
|
|
<div className="flex min-w-0 items-center gap-3">
|
|
<h1 className="truncate text-xl font-semibold">
|
|
{t('skills.createSkill')}
|
|
</h1>
|
|
<Badge variant="outline" className="shrink-0 text-[0.7rem]">
|
|
<Sparkles className="size-3.5" />
|
|
{t('skills.title')}
|
|
</Badge>
|
|
</div>
|
|
</div>
|
|
{canManage && (
|
|
<Button
|
|
type="submit"
|
|
form="skill-form"
|
|
className="shrink-0"
|
|
disabled={!boxAvailable}
|
|
>
|
|
{t('common.save')}
|
|
</Button>
|
|
)}
|
|
</div>
|
|
|
|
{!boxAvailable && (
|
|
<div className="pb-4 shrink-0">
|
|
<BoxUnavailableNotice hint={boxHint} reason={boxReason} />
|
|
</div>
|
|
)}
|
|
|
|
<div className="min-h-0 flex-1">
|
|
<fieldset className="contents" disabled={!canManage}>
|
|
<SkillForm
|
|
key="new-skill"
|
|
initSkillName={undefined}
|
|
layout="split"
|
|
onNewSkillCreated={(skillName) =>
|
|
handleImportedSkills([skillName])
|
|
}
|
|
onSkillUpdated={() => {}}
|
|
/>
|
|
</fieldset>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
const editActions = (
|
|
<Card className="border-destructive/50">
|
|
<CardHeader>
|
|
<CardTitle className="text-destructive">
|
|
{t('skills.dangerZone')}
|
|
</CardTitle>
|
|
<CardDescription>{t('skills.dangerZoneDescription')}</CardDescription>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<div className="flex flex-col gap-3 sm:flex-row sm:items-center sm:justify-between">
|
|
<div className="space-y-1">
|
|
<p className="text-sm font-medium">{t('skills.delete')}</p>
|
|
<p className="text-sm text-muted-foreground">
|
|
{t('skills.deleteConfirmation')}
|
|
</p>
|
|
</div>
|
|
{canManage && (
|
|
<Button
|
|
variant="destructive"
|
|
type="button"
|
|
size="sm"
|
|
onClick={() => setShowDeleteConfirm(true)}
|
|
className="shrink-0"
|
|
>
|
|
<Trash2 className="mr-1.5 size-4" />
|
|
{t('common.delete')}
|
|
</Button>
|
|
)}
|
|
</div>
|
|
</CardContent>
|
|
</Card>
|
|
);
|
|
|
|
return (
|
|
<>
|
|
<div className="flex h-full flex-col">
|
|
<div className="flex shrink-0 flex-col gap-3 pb-4 sm:flex-row sm:items-start sm:justify-between">
|
|
<div className="min-w-0 space-y-1">
|
|
<div className="flex min-w-0 items-center gap-3">
|
|
<h1 className="truncate text-xl font-semibold">
|
|
{skill?.name ?? id}
|
|
</h1>
|
|
<Badge variant="outline" className="shrink-0 text-[0.7rem]">
|
|
<Sparkles className="size-3.5" />
|
|
{t('skills.title')}
|
|
</Badge>
|
|
</div>
|
|
{skill?.description && (
|
|
<p className="line-clamp-2 text-sm text-muted-foreground">
|
|
{skill.description}
|
|
</p>
|
|
)}
|
|
</div>
|
|
<Button
|
|
type="submit"
|
|
form="skill-form"
|
|
className="shrink-0"
|
|
disabled={!boxAvailable}
|
|
>
|
|
{t('common.save')}
|
|
</Button>
|
|
</div>
|
|
|
|
{!boxAvailable && (
|
|
<div className="pb-4 shrink-0">
|
|
<BoxUnavailableNotice hint={boxHint} reason={boxReason} />
|
|
</div>
|
|
)}
|
|
|
|
<div className="min-h-0 flex-1">
|
|
<fieldset className="contents" disabled={!canManage}>
|
|
<SkillForm
|
|
key={id}
|
|
initSkillName={id}
|
|
layout="split"
|
|
sideFooter={canManage ? editActions : undefined}
|
|
onNewSkillCreated={(skillName) =>
|
|
handleImportedSkills([skillName])
|
|
}
|
|
onSkillUpdated={handleSkillUpdated}
|
|
/>
|
|
</fieldset>
|
|
</div>
|
|
</div>
|
|
|
|
<Dialog open={showDeleteConfirm} onOpenChange={setShowDeleteConfirm}>
|
|
<DialogContent className="max-h-[min(420px,80vh)] overflow-y-auto">
|
|
<DialogHeader>
|
|
<DialogTitle>{t('common.confirmDelete')}</DialogTitle>
|
|
</DialogHeader>
|
|
<div className="py-4">{t('skills.deleteConfirmation')}</div>
|
|
<DialogFooter>
|
|
<Button
|
|
variant="outline"
|
|
onClick={() => setShowDeleteConfirm(false)}
|
|
>
|
|
{t('common.cancel')}
|
|
</Button>
|
|
<Button variant="destructive" onClick={confirmDelete}>
|
|
{t('common.confirmDelete')}
|
|
</Button>
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
</>
|
|
);
|
|
}
|