LangBot/src/langbot/pkg/api/http/controller/groups/plugins.py

from __future__ import annotations

import asyncio
import base64
import collections.abc
import copy
import quart
import re
import httpx
import uuid
import os
import zipfile
from urllib.parse import urlparse
import posixpath
import sqlalchemy

from .....core import taskmgr
from .....core.task_boundary import run_in_workspace_uow
from .....entity.persistence import plugin as persistence_plugin
from ...authz import Permission
from ...context import ExecutionContext, RequestContext
from .. import group
from .....workspace.errors import WorkspaceNotFoundError
from .....plugin.github import validate_github_plugin_install_info
from .....plugin.archive import inspect_plugin_archive_metadata
from .....utils import httpclient
from langbot_plugin.runtime.plugin.mgr import PluginInstallSource


_SECRET_MASK = '***'
_MISSING_SECRET = object()
_SENSITIVE_CONFIG_NAMES = frozenset(
    {
        'api_key',
        'apikey',
        'auth',
        'authorization',
        'cookie',
        'credentials',
        'database_url',
        'dsn',
        'key',
        'proxy_authorization',
        'set_cookie',
    }
)
_SENSITIVE_CONFIG_TOKENS = frozenset(
    {
        'credential',
        'credentials',
        'passwd',
        'password',
        'secret',
        'token',
    }
)
_SENSITIVE_KEY_QUALIFIERS = frozenset(
    {
        'access',
        'api',
        'auth',
        'bearer',
        'client',
        'debug',
        'encryption',
        'private',
        'signing',
    }
)


def _normalize_config_key(key: object) -> str:
    value = re.sub(r'([a-z0-9])([A-Z])', r'\1_\2', str(key or ''))
    return re.sub(r'[^a-zA-Z0-9]+', '_', value).strip('_').lower()


def _is_sensitive_config_key(key: object) -> bool:
    normalized = _normalize_config_key(key)
    if normalized in _SENSITIVE_CONFIG_NAMES:
        return True
    tokens = frozenset(token for token in normalized.split('_') if token)
    if tokens & _SENSITIVE_CONFIG_TOKENS:
        return True
    return 'key' in tokens and bool(tokens & _SENSITIVE_KEY_QUALIFIERS)


def _mask_secret_structure(value):
    """Mask every non-empty leaf while preserving container structure."""

    if isinstance(value, dict):
        return {key: _mask_secret_structure(item) for key, item in value.items()}
    if isinstance(value, list):
        return [_mask_secret_structure(item) for item in value]
    if isinstance(value, tuple):
        return tuple(_mask_secret_structure(item) for item in value)
    if value is None or value == '':
        return value
    return _SECRET_MASK


def redact_plugin_secrets(value):
    """Return a recursively redacted copy of plugin-facing data."""

    if isinstance(value, dict):
        return {
            key: (_mask_secret_structure(item) if _is_sensitive_config_key(key) else redact_plugin_secrets(item))
            for key, item in value.items()
        }
    if isinstance(value, list):
        return [redact_plugin_secrets(item) for item in value]
    if isinstance(value, tuple):
        return tuple(redact_plugin_secrets(item) for item in value)
    return value


def restore_plugin_secret_placeholders(value, current_value=_MISSING_SECRET, *, sensitive: bool = False):
    """Restore masked leaves from the current config before a management write."""

    if sensitive and value == _SECRET_MASK:
        if current_value is _MISSING_SECRET:
            raise ValueError('Masked plugin secret has no existing value')
        return copy.deepcopy(current_value)
    if isinstance(value, dict):
        current_mapping = current_value if isinstance(current_value, dict) else {}
        return {
            key: restore_plugin_secret_placeholders(
                item,
                current_mapping.get(key, _MISSING_SECRET),
                sensitive=sensitive or _is_sensitive_config_key(key),
            )
            for key, item in value.items()
        }
    if isinstance(value, list):
        current_items = current_value if isinstance(current_value, (list, tuple)) else ()
        return [
            restore_plugin_secret_placeholders(
                item,
                current_items[index] if index < len(current_items) else _MISSING_SECRET,
                sensitive=sensitive,
            )
            for index, item in enumerate(value)
        ]
    if isinstance(value, tuple):
        current_items = current_value if isinstance(current_value, (list, tuple)) else ()
        return tuple(
            restore_plugin_secret_placeholders(
                item,
                current_items[index] if index < len(current_items) else _MISSING_SECRET,
                sensitive=sensitive,
            )
            for index, item in enumerate(value)
        )
    return value


# Resolve the built-in page SDK JS from the langbot_plugin package
_PAGE_SDK_PATH = None
try:
    import langbot_plugin.assets as _assets_pkg

    _candidate = os.path.join(os.path.dirname(_assets_pkg.__file__), 'langbot-page-sdk.js')
    if os.path.exists(_candidate):
        _PAGE_SDK_PATH = _candidate
except Exception:
    pass


def _normalize_plugin_asset_path(filepath: str) -> str | None:
    filepath = filepath.replace('\\', '/')
    if filepath.startswith('/'):
        return None

    normalized = posixpath.normpath(filepath)
    if normalized == '.' or normalized.startswith('../') or normalized == '..':
        return None

    if normalized.startswith('components/pages/'):
        return normalized

    return f'assets/{normalized}'


def _get_request_origin() -> str:
    """Return the public request origin, respecting reverse-proxy headers."""
    forwarded_proto = quart.request.headers.get('X-Forwarded-Proto', '').split(',')[0].strip()
    forwarded_host = quart.request.headers.get('X-Forwarded-Host', '').split(',')[0].strip()

    scheme = forwarded_proto or quart.request.scheme
    host = forwarded_host or quart.request.host
    return f'{scheme}://{host}'


@group.group_class('plugins', '/api/v1/plugins')
class PluginsRouterGroup(group.RouterGroup):
    @staticmethod
    def _normalize_archive_path(path: str) -> str:
        normalized = str(path or '').replace('\\', '/').strip('/')
        return posixpath.normpath(normalized) if normalized else ''

    @classmethod
    def _component_source_path(cls, entry) -> str:
        if isinstance(entry, dict):
            return cls._normalize_archive_path(entry.get('path') or '')
        return cls._normalize_archive_path(str(entry or ''))

    @classmethod
    def _count_component_configs(cls, component_config, archive_names: list[str]) -> int:
        normalized_names = [cls._normalize_archive_path(name) for name in archive_names]
        component_files: set[str] = set()

        if isinstance(component_config, list):
            return len(component_config)
        if not isinstance(component_config, dict):
            return 1 if component_config else 0

        for entry in component_config.get('fromFiles') or []:
            source_path = cls._component_source_path(entry)
            if source_path and source_path in normalized_names:
                component_files.add(source_path)

        for entry in component_config.get('fromDirs') or []:
            source_dir = cls._component_source_path(entry).rstrip('/')
            if not source_dir:
                continue
            prefix = f'{source_dir}/'
            for archive_name in normalized_names:
                if not archive_name.startswith(prefix):
                    continue
                if archive_name.lower().endswith(('.yaml', '.yml')):
                    component_files.add(archive_name)

        if component_files:
            return len(component_files)

        return 1 if any(key in component_config for key in ('path', 'name', 'kind')) else 0

    @classmethod
    def _count_plugin_components(cls, components, archive_names: list[str]) -> dict[str, int]:
        if not isinstance(components, dict):
            return {}

        component_counts: dict[str, int] = {}
        for kind, component_config in components.items():
            count = cls._count_component_configs(component_config, archive_names)
            if count > 0:
                component_counts[str(kind)] = count
        return component_counts

    @staticmethod
    def _parse_github_repo_url(repo_url: str) -> dict | None:
        raw_url = str(repo_url or '').strip()
        if not raw_url:
            return None

        if not re.match(r'^[a-zA-Z][a-zA-Z0-9+.-]*://', raw_url):
            raw_url = f'https://{raw_url}'

        parsed = urlparse(raw_url)
        if parsed.netloc.lower() not in ('github.com', 'www.github.com'):
            return None

        parts = [part for part in parsed.path.strip('/').split('/') if part]
        if len(parts) < 2:
            return None

        owner = parts[0]
        repo = parts[1]
        if repo.endswith('.git'):
            repo = repo[:-4]
        if not owner or not repo:
            return None

        ref = ''
        subdir = ''
        if len(parts) >= 4 and parts[2] in ('tree', 'blob'):
            ref = parts[3]
            subdir = '/'.join(parts[4:]).strip('/')

        return {
            'owner': owner,
            'repo': repo,
            'ref': ref,
            'subdir': subdir,
        }

    async def _check_extensions_limit(self, request_context: RequestContext) -> str | None:
        """Check if extensions limit is reached. Returns error response if limit exceeded, None otherwise."""
        await self.ap.plugin_connector.require_workspace_context(request_context)
        limitation = self.ap.instance_config.data.get('system', {}).get('limitation', {})
        max_extensions = limitation.get('max_extensions', -1)
        if max_extensions >= 0:
            plugins = await self.ap.plugin_connector.list_plugins()
            mcp_servers = await self.ap.mcp_service.get_mcp_servers(request_context)
            total_extensions = len(plugins) + len(mcp_servers)
            if total_extensions >= max_extensions:
                return self.http_status(400, -1, f'Maximum number of extensions ({max_extensions}) reached')
        return None

    @staticmethod
    def _task_scope(request_context: RequestContext) -> dict[str, str | int]:
        return {
            'instance_uuid': request_context.instance_uuid,
            'workspace_uuid': request_context.workspace_uuid,
            'placement_generation': request_context.placement_generation,
        }

    async def _run_fenced_plugin_operation(
        self,
        execution_context: ExecutionContext,
        operation: collections.abc.Callable[[], collections.abc.Awaitable],
    ):
        """Revalidate a captured task context immediately before Runtime I/O."""

        await run_in_workspace_uow(
            self.ap,
            execution_context.workspace_uuid,
            lambda: self.ap.plugin_connector.require_workspace_context(execution_context),
        )
        return await operation()

    async def _require_public_plugin_runtime_context(self) -> ExecutionContext:
        """Resolve public assets only for the OSS singleton Workspace.

        Public image and iframe requests cannot carry the WebUI bearer token.
        They therefore remain available for the one-Workspace Core deployment,
        but fail closed instead of guessing a Workspace when multi-Workspace
        policy is active.
        """

        workspace_service = getattr(self.ap, 'workspace_service', None)
        policy = getattr(workspace_service, 'policy', None)
        if workspace_service is None or policy is None or getattr(policy, 'multi_workspace_enabled', False):
            raise WorkspaceNotFoundError('Plugin resource not found')
        binding = await workspace_service.get_local_execution_binding()
        execution_context = ExecutionContext(
            instance_uuid=binding.instance_uuid,
            workspace_uuid=binding.workspace_uuid,
            placement_generation=binding.placement_generation,
        )
        return await self.ap.plugin_connector.require_workspace_context(execution_context)

    async def _get_stored_plugin_config(
        self,
        request_context: RequestContext,
        author: str,
        plugin_name: str,
        plugin: dict,
    ):
        result = await self.ap.persistence_mgr.execute_async(
            sqlalchemy.select(persistence_plugin.PluginSetting.config)
            .where(persistence_plugin.PluginSetting.workspace_uuid == request_context.workspace_uuid)
            .where(persistence_plugin.PluginSetting.plugin_author == author)
            .where(persistence_plugin.PluginSetting.plugin_name == plugin_name)
        )
        persisted_config = result.scalar_one_or_none()
        return persisted_config if persisted_config is not None else plugin['plugin_config']

    async def initialize(self) -> None:
        @self.route('/_sdk/page-sdk.js', methods=['GET'], auth_type=group.AuthType.NONE)
        async def _() -> quart.Response:
            """Serve the built-in LangBot page SDK JavaScript."""
            if _PAGE_SDK_PATH and os.path.exists(_PAGE_SDK_PATH):
                with open(_PAGE_SDK_PATH, 'r') as f:
                    content = f.read()
                return quart.Response(content, mimetype='application/javascript')
            return quart.Response('// SDK not found', status=404, mimetype='application/javascript')

        @self.route(
            '',
            methods=['GET'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_VIEW,
        )
        async def _(request_context: RequestContext) -> str:
            await self.ap.plugin_connector.require_workspace_context(request_context)
            plugins = await self.ap.plugin_connector.list_plugins()

            return self.success(data={'plugins': redact_plugin_secrets(plugins)})

        @self.route(
            '/debug-info',
            methods=['GET'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(request_context: RequestContext) -> str:
            """Get plugin debug information including debug URL and key"""
            await self.ap.plugin_connector.require_workspace_context(request_context)
            debug_info = await self.ap.plugin_connector.get_debug_info()

            # Get debug URL from config
            plugin_config = self.ap.instance_config.data.get('plugin', {})
            debug_url = plugin_config.get('display_plugin_debug_url', 'http://localhost:5401')

            return self.success(
                data={
                    'debug_url': debug_url,
                    'plugin_debug_key': debug_info.get('plugin_debug_key', ''),
                }
            )

        @self.route(
            '/<author>/<plugin_name>/upgrade',
            methods=['POST'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(author: str, plugin_name: str, request_context: RequestContext) -> str:
            execution_context = await self.ap.plugin_connector.require_workspace_context(request_context)
            ctx = taskmgr.TaskContext.new()
            wrapper = self.ap.task_mgr.create_user_task(
                self._run_fenced_plugin_operation(
                    execution_context,
                    lambda: self.ap.plugin_connector.upgrade_plugin(author, plugin_name, task_context=ctx),
                ),
                kind='plugin-operation',
                name=f'plugin-upgrade-{plugin_name}',
                label=f'Upgrading plugin {plugin_name}',
                context=ctx,
                **self._task_scope(request_context),
            )
            return self.success(data={'task_id': wrapper.id})

        @self.route(
            '/<author>/<plugin_name>',
            methods=['GET'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_VIEW,
        )
        async def _(author: str, plugin_name: str, request_context: RequestContext) -> str:
            await self.ap.plugin_connector.require_workspace_context(request_context)
            plugin = await self.ap.plugin_connector.get_plugin_info(author, plugin_name)
            if plugin is None:
                return self.http_status(404, -1, 'plugin not found')
            return self.success(data={'plugin': redact_plugin_secrets(plugin)})

        @self.route(
            '/<author>/<plugin_name>',
            methods=['DELETE'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(author: str, plugin_name: str, request_context: RequestContext) -> str:
            execution_context = await self.ap.plugin_connector.require_workspace_context(request_context)
            delete_data = quart.request.args.get('delete_data', 'false').lower() == 'true'
            ctx = taskmgr.TaskContext.new()
            wrapper = self.ap.task_mgr.create_user_task(
                self._run_fenced_plugin_operation(
                    execution_context,
                    lambda: self.ap.plugin_connector.delete_plugin(
                        author,
                        plugin_name,
                        delete_data=delete_data,
                        task_context=ctx,
                    ),
                ),
                kind='plugin-operation',
                name=f'plugin-remove-{plugin_name}',
                label=f'Removing plugin {plugin_name}',
                context=ctx,
                **self._task_scope(request_context),
            )
            return self.success(data={'task_id': wrapper.id})

        @self.route(
            '/<author>/<plugin_name>/config',
            methods=['GET'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_VIEW,
        )
        async def _(author: str, plugin_name: str, request_context: RequestContext) -> quart.Response:
            await self.ap.plugin_connector.require_workspace_context(request_context)
            plugin = await self.ap.plugin_connector.get_plugin_info(author, plugin_name)
            if plugin is None:
                return self.http_status(404, -1, 'plugin not found')

            config = await self._get_stored_plugin_config(
                request_context,
                author,
                plugin_name,
                plugin,
            )
            return self.success(data={'config': redact_plugin_secrets(config)})

        @self.route(
            '/<author>/<plugin_name>/config',
            methods=['PUT'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(author: str, plugin_name: str, request_context: RequestContext) -> quart.Response:
            await self.ap.plugin_connector.require_workspace_context(request_context)
            plugin = await self.ap.plugin_connector.get_plugin_info(author, plugin_name)
            if plugin is None:
                return self.http_status(404, -1, 'plugin not found')
            current_config = await self._get_stored_plugin_config(
                request_context,
                author,
                plugin_name,
                plugin,
            )
            try:
                config = restore_plugin_secret_placeholders(
                    await quart.request.json,
                    current_config,
                )
            except ValueError as exc:
                return self.http_status(400, -1, str(exc))
            await self.ap.plugin_connector.require_workspace_context(request_context)
            await self.ap.plugin_connector.set_plugin_config(author, plugin_name, config)
            return self.success(data={})

        @self.route(
            '/<author>/<plugin_name>/readme',
            methods=['GET'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_VIEW,
        )
        async def _(author: str, plugin_name: str, request_context: RequestContext) -> quart.Response:
            await self.ap.plugin_connector.require_workspace_context(request_context)
            language = quart.request.args.get('language', 'en')
            readme = await self.ap.plugin_connector.get_plugin_readme(author, plugin_name, language=language)
            return self.success(data={'readme': readme})

        @self.route(
            '/<author>/<plugin_name>/logs',
            methods=['GET'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.AUDIT_VIEW,
        )
        async def _(author: str, plugin_name: str, request_context: RequestContext) -> quart.Response:
            await self.ap.plugin_connector.require_workspace_context(request_context)
            try:
                limit = int(quart.request.args.get('limit', 200))
            except (TypeError, ValueError):
                limit = 200
            level = quart.request.args.get('level') or None
            logs = await self.ap.plugin_connector.get_plugin_logs(author, plugin_name, limit=limit, level=level)
            return self.success(data={'logs': logs})

        @self.route(
            '/<author>/<plugin_name>/icon',
            methods=['GET'],
            auth_type=group.AuthType.NONE,
        )
        async def _(author: str, plugin_name: str) -> quart.Response:
            await self._require_public_plugin_runtime_context()
            icon_data = await self.ap.plugin_connector.get_plugin_icon(author, plugin_name)
            icon_base64 = icon_data['plugin_icon_base64']
            mime_type = icon_data['mime_type']

            icon_data = await asyncio.to_thread(base64.b64decode, icon_base64)

            return quart.Response(icon_data, mimetype=mime_type)

        @self.route(
            '/<author>/<plugin_name>/assets/<path:filepath>',
            methods=['GET'],
            auth_type=group.AuthType.NONE,
        )
        async def _(author: str, plugin_name: str, filepath: str) -> quart.Response:
            await self._require_public_plugin_runtime_context()
            asset_path = _normalize_plugin_asset_path(filepath)
            if asset_path is None:
                return quart.Response('Asset not found', status=404)

            asset_data = await self.ap.plugin_connector.get_plugin_assets(author, plugin_name, asset_path)
            if not asset_data.get('asset_base64'):
                return quart.Response('Asset not found', status=404)
            asset_bytes = await asyncio.to_thread(
                base64.b64decode,
                asset_data['asset_base64'],
            )
            mime_type = asset_data['mime_type']
            resp = quart.Response(asset_bytes, mimetype=mime_type)
            # CSP for HTML pages served to sandboxed iframes (opaque origin).
            # 'self' doesn't work in sandboxed iframes — use actual server origin.
            if mime_type and mime_type.startswith('text/html'):
                origin = _get_request_origin()
                resp.headers['Content-Security-Policy'] = (
                    f'default-src {origin}; '
                    f"script-src {origin} 'unsafe-inline'; "
                    f"style-src {origin} 'unsafe-inline'; "
                    f'img-src {origin} data:; '
                    f'connect-src {origin}; '
                    "frame-src 'none'; "
                    "object-src 'none'"
                )
            return resp

        @self.route(
            '/<author>/<plugin_name>/page-api',
            methods=['POST'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(author: str, plugin_name: str, request_context: RequestContext) -> str:
            """Forward a page API request to the plugin."""
            await self.ap.plugin_connector.require_workspace_context(request_context)
            data = await quart.request.json
            if not isinstance(data, dict):
                return self.http_status(400, -1, 'invalid request body')

            page_id = data.get('page_id', '')
            endpoint = data.get('endpoint', '')
            method = data.get('method', 'POST')
            body = data.get('body')
            if not isinstance(page_id, str) or not isinstance(endpoint, str) or not isinstance(method, str):
                return self.http_status(400, -1, 'invalid page api request')
            if not endpoint.startswith('/') or '..' in endpoint:
                return self.http_status(400, -1, 'invalid endpoint')

            result = await self.ap.plugin_connector.handle_page_api(
                author, plugin_name, page_id, endpoint, method.upper(), body
            )
            if result.get('error'):
                return self.http_status(400, -1, result['error'])
            return self.success(data=result.get('data'))

        @self.route(
            '/github/releases',
            methods=['POST'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_VIEW,
        )
        async def _(request_context: RequestContext) -> str:
            """Get releases from a GitHub repository URL"""
            await self.ap.plugin_connector.require_workspace_context(request_context)
            data = await quart.request.json
            repo_url = data.get('repo_url', '')

            parsed_repo = self._parse_github_repo_url(repo_url)
            if not parsed_repo:
                return self.http_status(400, -1, 'Invalid GitHub repository URL')

            owner = parsed_repo['owner']
            repo = parsed_repo['repo']
            requested_ref = parsed_repo['ref']
            requested_subdir = parsed_repo['subdir']

            try:
                if requested_ref:
                    return self.success(
                        data={
                            'releases': [
                                {
                                    'id': 0,
                                    'tag_name': requested_ref,
                                    'name': requested_ref,
                                    'published_at': '',
                                    'prerelease': False,
                                    'draft': False,
                                    'source_type': 'branch',
                                    'archive_url': f'https://api.github.com/repos/{owner}/{repo}/zipball/{requested_ref}',
                                }
                            ],
                            'owner': owner,
                            'repo': repo,
                            'source_subdir': requested_subdir,
                        }
                    )

                # Fetch releases from GitHub API
                url = f'https://api.github.com/repos/{owner}/{repo}/releases'
                async with httpx.AsyncClient(
                    trust_env=True,
                    follow_redirects=True,
                    timeout=10,
                    event_hooks=httpclient.httpx_response_limit_hooks(),
                ) as client:
                    response = await client.get(url)
                    response.raise_for_status()
                    releases = await httpclient.parse_json_response(response)

                # Format releases data for frontend
                formatted_releases = []
                for release in releases:
                    formatted_releases.append(
                        {
                            'id': release['id'],
                            'tag_name': release['tag_name'],
                            'name': release['name'],
                            'published_at': release['published_at'],
                            'prerelease': release['prerelease'],
                            'draft': release['draft'],
                        }
                    )

                return self.success(
                    data={
                        'releases': formatted_releases,
                        'owner': owner,
                        'repo': repo,
                        'source_subdir': requested_subdir,
                    }
                )
            except httpx.RequestError:
                raise

        @self.route(
            '/github/release-assets',
            methods=['POST'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_VIEW,
        )
        async def _(request_context: RequestContext) -> str:
            """Get assets from a specific GitHub release"""
            await self.ap.plugin_connector.require_workspace_context(request_context)
            data = await quart.request.json
            owner = data.get('owner', '')
            repo = data.get('repo', '')
            release_id = data.get('release_id', '')

            if not all([owner, repo, release_id]):
                return self.http_status(400, -1, 'Missing required parameters')

            try:
                # Fetch release assets from GitHub API
                url = f'https://api.github.com/repos/{owner}/{repo}/releases/{release_id}'
                async with httpx.AsyncClient(
                    trust_env=True,
                    follow_redirects=True,
                    timeout=10,
                    event_hooks=httpclient.httpx_response_limit_hooks(),
                ) as client:
                    response = await client.get(
                        url,
                    )
                    response.raise_for_status()
                    release = await httpclient.parse_json_response(response)

                # Format assets data for frontend
                formatted_assets = []
                for asset in release.get('assets', []):
                    formatted_assets.append(
                        {
                            'id': asset['id'],
                            'name': asset['name'],
                            'size': asset['size'],
                            'download_url': asset['browser_download_url'],
                            'content_type': asset['content_type'],
                        }
                    )

                # add zipball as a downloadable asset
                # formatted_assets.append(
                #     {
                #         "id": 0,
                #         "name": "Source code (zip)",
                #         "size": -1,
                #         "download_url": release["zipball_url"],
                #         "content_type": "application/zip",
                #     }
                # )

                return self.success(data={'assets': formatted_assets})
            except httpx.RequestError:
                raise

        @self.route(
            '/install/github',
            methods=['POST'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(request_context: RequestContext) -> str:
            """Install plugin from GitHub release asset"""
            limit_error = await self._check_extensions_limit(request_context)
            if limit_error is not None:
                return limit_error

            data = await quart.request.json or {}
            try:
                install_info = validate_github_plugin_install_info(
                    {
                        'asset_url': data.get('asset_url'),
                        'asset_id': data.get('asset_id'),
                        'release_id': data.get('release_id'),
                        'owner': data.get('owner'),
                        'repo': data.get('repo'),
                        'release_tag': data.get('release_tag'),
                        'github_url': f'https://github.com/{data.get("owner", "")}/{data.get("repo", "")}',
                    }
                )
            except ValueError as exc:
                return self.http_status(400, -1, str(exc))

            owner = install_info['owner']
            repo = install_info['repo']
            release_tag = install_info['release_tag']

            execution_context = await self.ap.plugin_connector.require_workspace_context(request_context)

            ctx = taskmgr.TaskContext.new()
            ctx.metadata['plugin_name'] = f'{owner}/{repo}'
            ctx.metadata['install_source'] = 'github'

            wrapper = self.ap.task_mgr.create_user_task(
                self._run_fenced_plugin_operation(
                    execution_context,
                    lambda: self.ap.plugin_connector.install_plugin(
                        PluginInstallSource.GITHUB,
                        install_info,
                        task_context=ctx,
                    ),
                ),
                kind='plugin-operation',
                name='plugin-install-github',
                label=f'Installing plugin from GitHub {owner}/{repo}@{release_tag}',
                context=ctx,
                **self._task_scope(request_context),
            )

            return self.success(data={'task_id': wrapper.id})

        @self.route(
            '/install/marketplace',
            methods=['POST'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(request_context: RequestContext) -> str:
            limit_error = await self._check_extensions_limit(request_context)
            if limit_error is not None:
                return limit_error

            data = await quart.request.json

            plugin_author = data.get('plugin_author', '')
            plugin_name = data.get('plugin_name', '')
            execution_context = await self.ap.plugin_connector.require_workspace_context(request_context)

            ctx = taskmgr.TaskContext.new()
            ctx.metadata['plugin_name'] = f'{plugin_author}/{plugin_name}'
            ctx.metadata['install_source'] = 'marketplace'
            wrapper = self.ap.task_mgr.create_user_task(
                self._run_fenced_plugin_operation(
                    execution_context,
                    lambda: self.ap.plugin_connector.install_plugin(
                        PluginInstallSource.MARKETPLACE,
                        data,
                        task_context=ctx,
                    ),
                ),
                kind='plugin-operation',
                name='plugin-install-marketplace',
                label=f'Installing plugin from marketplace {plugin_author}/{plugin_name}',
                context=ctx,
                **self._task_scope(request_context),
            )

            return self.success(data={'task_id': wrapper.id})

        @self.route(
            '/install/local',
            methods=['POST'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(request_context: RequestContext) -> str:
            limit_error = await self._check_extensions_limit(request_context)
            if limit_error is not None:
                return limit_error

            file = (await quart.request.files).get('file')
            if file is None:
                return self.http_status(400, -1, 'file is required')

            file_bytes = file.read()
            execution_context = await self.ap.plugin_connector.require_workspace_context(request_context)

            data = {
                'plugin_file': file_bytes,
            }

            ctx = taskmgr.TaskContext.new()
            ctx.metadata['plugin_name'] = file.filename or 'local plugin'
            ctx.metadata['install_source'] = 'local'
            wrapper = self.ap.task_mgr.create_user_task(
                self._run_fenced_plugin_operation(
                    execution_context,
                    lambda: self.ap.plugin_connector.install_plugin(
                        PluginInstallSource.LOCAL,
                        data,
                        task_context=ctx,
                    ),
                ),
                kind='plugin-operation',
                name='plugin-install-local',
                label=f'Installing plugin from local {file.filename}',
                context=ctx,
                **self._task_scope(request_context),
            )

            return self.success(data={'task_id': wrapper.id})

        @self.route(
            '/install/local/preview',
            methods=['POST'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(request_context: RequestContext) -> str:
            await self.ap.plugin_connector.require_workspace_context(request_context)
            file = (await quart.request.files).get('file')
            if file is None:
                return self.http_status(400, -1, 'file is required')

            file_bytes = file.read()
            try:
                manifest, requirements, names = await asyncio.to_thread(
                    inspect_plugin_archive_metadata,
                    file_bytes,
                )
                spec = manifest.get('spec') or {}
                components = spec.get('components') or {}
                component_counts = self._count_plugin_components(components, names)
                component_types = list(component_counts.keys())

                return self.success(
                    data={
                        'filename': file.filename or 'local plugin',
                        'size': len(file_bytes),
                        'manifest': manifest,
                        'metadata': manifest.get('metadata') or {},
                        'component_types': component_types,
                        'component_counts': component_counts,
                        'requirements': requirements,
                        'file_count': len(names),
                    }
                )
            except (zipfile.BadZipFile, ValueError) as exc:
                return self.http_status(400, -1, str(exc) or 'invalid .lbpkg file')
            except Exception:
                raise

        @self.route(
            '/config-files',
            methods=['POST'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(request_context: RequestContext) -> str:
            """Upload a file for plugin configuration"""
            await self.ap.plugin_connector.require_workspace_context(request_context)
            file = (await quart.request.files).get('file')
            if file is None:
                return self.http_status(400, -1, 'file is required')

            # Check file size (10MB limit)
            MAX_FILE_SIZE = 10 * 1024 * 1024  # 10MB
            file_bytes = file.read()
            if len(file_bytes) > MAX_FILE_SIZE:
                return self.http_status(400, -1, 'file size exceeds 10MB limit')

            original_filename = file.filename or 'config.bin'
            _, ext = os.path.splitext(original_filename)
            logical_key = f'plugin_config_{uuid.uuid4().hex}{ext}'
            file_key = await self.ap.storage_mgr.save_scoped(
                request_context,
                owner_type='plugin_config',
                owner=request_context.workspace_uuid,
                key=logical_key,
                value=file_bytes,
            )

            return self.success(data={'file_key': file_key})

        @self.route(
            '/config-files/<path:file_key>',
            methods=['DELETE'],
            auth_type=group.AuthType.USER_TOKEN_OR_API_KEY,
            permission=Permission.RESOURCE_MANAGE,
        )
        async def _(file_key: str, request_context: RequestContext) -> str:
            """Delete a plugin configuration file"""
            await self.ap.plugin_connector.require_workspace_context(request_context)
            if not self.ap.storage_mgr.is_scoped_object_key(file_key, expected_owner_type='plugin_config'):
                return self.http_status(400, -1, 'invalid file key')

            try:
                await self.ap.storage_mgr.delete_scoped_object_key(
                    request_context,
                    file_key,
                    expected_owner_type='plugin_config',
                )
                return self.success(data={'deleted': True})
            except Exception:
                raise