mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-08 20:30:59 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
168 lines
4.9 KiB
TypeScript
168 lines
4.9 KiB
TypeScript
import { expect, test } from '@playwright/test';
|
|
|
|
import { installLangBotApiMocks } from './fixtures/langbot-api';
|
|
|
|
test('terminal invitation errors refresh on a new fragment and allow account switching', async ({
|
|
page,
|
|
}) => {
|
|
await installLangBotApiMocks(page, {
|
|
storage: {
|
|
token: 'playwright-token',
|
|
userEmail: 'another-account@example.com',
|
|
},
|
|
});
|
|
await page.route('**/api/v1/invitations/inspect', async (route) => {
|
|
const body = JSON.parse(route.request().postData() || '{}') as {
|
|
token?: string;
|
|
};
|
|
const code =
|
|
body.token === 'revoked-invitation'
|
|
? 'invitation_revoked'
|
|
: 'invitation_used';
|
|
await route.fulfill({
|
|
status: 410,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({ code, msg: code }),
|
|
});
|
|
});
|
|
|
|
await page.goto('/invitations/accept#token=used-invitation');
|
|
await expect(
|
|
page.getByText('This invitation was already used.'),
|
|
).toBeVisible();
|
|
await expect
|
|
.poll(() =>
|
|
page.evaluate(() =>
|
|
sessionStorage.getItem('langbot_pending_invitation_token'),
|
|
),
|
|
)
|
|
.toBeNull();
|
|
|
|
await page.evaluate(() => {
|
|
window.location.hash = 'token=revoked-invitation';
|
|
});
|
|
await expect(page.getByText('This invitation was revoked.')).toBeVisible();
|
|
|
|
await page.getByRole('button', { name: 'Back to sign in' }).click();
|
|
await expect(page).toHaveURL(/\/login$/);
|
|
await expect(page.getByText('Welcome')).toBeVisible();
|
|
expect(
|
|
await page.evaluate(() => ({
|
|
token: localStorage.getItem('token'),
|
|
userEmail: localStorage.getItem('userEmail'),
|
|
})),
|
|
).toEqual({ token: null, userEmail: null });
|
|
});
|
|
|
|
test('login preserves an explicit invitation email mismatch error', async ({
|
|
page,
|
|
}) => {
|
|
await installLangBotApiMocks(page, { authenticated: false });
|
|
await page.route('**/api/v1/invitations/inspect', async (route) => {
|
|
await route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({
|
|
code: 0,
|
|
data: {
|
|
invitation: {
|
|
uuid: 'mismatch-invitation',
|
|
workspace_uuid: 'workspace-playwright',
|
|
normalized_email: 'invited@example.com',
|
|
role: 'viewer',
|
|
status: 'pending',
|
|
},
|
|
workspace: {
|
|
uuid: 'workspace-playwright',
|
|
name: 'Playwright Workspace',
|
|
},
|
|
},
|
|
msg: 'ok',
|
|
}),
|
|
});
|
|
});
|
|
await page.route('**/api/v1/invitations/accept', async (route) => {
|
|
await route.fulfill({
|
|
status: 400,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({
|
|
code: 'invitation_email_mismatch',
|
|
msg: 'Invitation email does not match the Account',
|
|
}),
|
|
});
|
|
});
|
|
|
|
await page.goto('/invitations/accept#token=mismatch-invitation');
|
|
await page.getByRole('button', { name: 'I already have an account' }).click();
|
|
await page.getByPlaceholder('Enter email address').fill('other@example.com');
|
|
await page.getByPlaceholder('Enter password').fill('password');
|
|
await page.getByRole('button', { name: 'Login with password' }).click();
|
|
|
|
await expect(page).toHaveURL(
|
|
/\/invitations\/accept\?error=invitation_email_mismatch$/,
|
|
);
|
|
await expect(
|
|
page.getByText('This invitation belongs to a different email address.'),
|
|
).toBeVisible();
|
|
await expect(page.getByText('Login successful')).toHaveCount(0);
|
|
});
|
|
|
|
test('an authenticated OSS invitation requires logout before registration', async ({
|
|
page,
|
|
}) => {
|
|
await installLangBotApiMocks(page, {
|
|
storage: {
|
|
token: 'playwright-token',
|
|
userEmail: 'invited@example.com',
|
|
},
|
|
});
|
|
await page.route('**/api/v1/invitations/inspect', async (route) => {
|
|
await route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({
|
|
code: 0,
|
|
data: {
|
|
invitation: {
|
|
uuid: 'logout-invitation',
|
|
workspace_uuid: 'workspace-playwright',
|
|
normalized_email: 'invited@example.com',
|
|
role: 'viewer',
|
|
status: 'pending',
|
|
},
|
|
workspace: {
|
|
uuid: 'workspace-playwright',
|
|
name: 'Playwright Workspace',
|
|
},
|
|
},
|
|
msg: 'ok',
|
|
}),
|
|
});
|
|
});
|
|
|
|
await page.goto('/invitations/accept#token=logout-invitation');
|
|
await expect(
|
|
page.getByText(
|
|
'Sign out first, then sign in with the invited account. Your invitation will be preserved.',
|
|
),
|
|
).toBeVisible();
|
|
await page
|
|
.getByRole('button', {
|
|
name: 'Sign out and return to this invitation',
|
|
})
|
|
.click();
|
|
|
|
await expect(page).toHaveURL(/\/login\?invitation=1$/);
|
|
expect(
|
|
await page.evaluate(() => ({
|
|
token: localStorage.getItem('token'),
|
|
userEmail: localStorage.getItem('userEmail'),
|
|
invitation: sessionStorage.getItem('langbot_pending_invitation_token'),
|
|
})),
|
|
).toEqual({
|
|
token: null,
|
|
userEmail: null,
|
|
invitation: 'logout-invitation',
|
|
});
|
|
});
|