mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-09 12:40:59 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
120 lines
4.4 KiB
Python
120 lines
4.4 KiB
Python
"""Unit tests for WebSocketAdapter._process_image_components.
|
|
|
|
The web debug client uploads Image / Voice / File components carrying a storage
|
|
key in ``path``. This helper resolves each to a base64 data URI (so multimodal
|
|
LLM input and the Box sandbox inbox have usable bytes), then deletes the
|
|
consumed storage object and clears ``path``. Covers mimetype selection per
|
|
type and fail-closed error handling.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import base64
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, Mock
|
|
|
|
import pytest
|
|
|
|
from langbot.pkg.api.http.context import ExecutionContext
|
|
from langbot.pkg.platform.sources.websocket_adapter import WebSocketAdapter
|
|
|
|
|
|
_CONTEXT = ExecutionContext(
|
|
instance_uuid='instance-a',
|
|
workspace_uuid='workspace-a',
|
|
placement_generation=1,
|
|
pipeline_uuid='pipeline-a',
|
|
)
|
|
_UPLOAD_PREFIX = 'v1/instance-a/workspace-a/1/upload_image/'
|
|
|
|
|
|
def _make_connection():
|
|
return SimpleNamespace(execution_context=_CONTEXT)
|
|
|
|
|
|
def _make_adapter(load_return=b'hello', load_side_effect=None):
|
|
provider = Mock()
|
|
provider.load = AsyncMock(return_value=load_return, side_effect=load_side_effect)
|
|
storage_mgr = Mock()
|
|
storage_mgr.storage_provider = provider
|
|
storage_mgr.load_scoped_object_key = AsyncMock(return_value=load_return, side_effect=load_side_effect)
|
|
storage_mgr.scoped_prefix.return_value = _UPLOAD_PREFIX
|
|
storage_mgr.is_scoped_object_key.return_value = True
|
|
storage_mgr.delete_scoped_object_key = AsyncMock()
|
|
ap = Mock()
|
|
ap.storage_mgr = storage_mgr
|
|
logger = Mock()
|
|
logger.error = AsyncMock()
|
|
logger.warning = AsyncMock()
|
|
# WebSocketAdapter is a pydantic model; bypass full __init__/validation.
|
|
adapter = WebSocketAdapter.model_construct(ap=ap, logger=logger)
|
|
return adapter, storage_mgr, provider
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_image_jpeg_mimetype_and_cleanup():
|
|
adapter, storage_mgr, _ = _make_adapter(load_return=b'\xff\xd8\xff')
|
|
path = f'{_UPLOAD_PREFIX}photo.jpg'
|
|
chain = [{'type': 'Image', 'path': path}]
|
|
|
|
await adapter._process_image_components(_make_connection(), chain)
|
|
|
|
expected_b64 = base64.b64encode(b'\xff\xd8\xff').decode('utf-8')
|
|
assert chain[0]['base64'] == f'data:image/jpeg;base64,{expected_b64}'
|
|
assert chain[0]['path'] == '' # consumed
|
|
storage_mgr.delete_scoped_object_key.assert_awaited_once_with(
|
|
_CONTEXT,
|
|
path,
|
|
expected_owner_type='upload_image',
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_image_defaults_to_png():
|
|
adapter, _, _ = _make_adapter()
|
|
chain = [{'type': 'Image', 'path': f'{_UPLOAD_PREFIX}blob'}]
|
|
await adapter._process_image_components(_make_connection(), chain)
|
|
assert chain[0]['base64'].startswith('data:image/png;base64,')
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_voice_uses_guessed_or_wav_mimetype():
|
|
adapter, _, _ = _make_adapter()
|
|
chain = [{'type': 'Voice', 'path': f'{_UPLOAD_PREFIX}clip.wav'}]
|
|
await adapter._process_image_components(_make_connection(), chain)
|
|
assert chain[0]['base64'].startswith('data:audio/')
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_file_uses_octet_stream_fallback():
|
|
adapter, _, _ = _make_adapter()
|
|
chain = [{'type': 'File', 'path': f'{_UPLOAD_PREFIX}unknownblob'}]
|
|
await adapter._process_image_components(_make_connection(), chain)
|
|
assert chain[0]['base64'].startswith('data:application/octet-stream;base64,')
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_skips_components_without_path_or_unknown_type():
|
|
adapter, storage_mgr, provider = _make_adapter()
|
|
chain = [
|
|
{'type': 'Image', 'path': ''}, # no path
|
|
{'type': 'Plain', 'path': 'storage://abc/x'}, # not a file component
|
|
{'type': 'At', 'target': '123'}, # no path key at all
|
|
]
|
|
await adapter._process_image_components(_make_connection(), chain)
|
|
provider.load.assert_not_awaited()
|
|
storage_mgr.load_scoped_object_key.assert_not_awaited()
|
|
assert 'base64' not in chain[0]
|
|
assert 'base64' not in chain[1]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_load_failure_is_logged_and_aborts_processing():
|
|
adapter, _, _ = _make_adapter(load_side_effect=RuntimeError('storage down'))
|
|
chain = [{'type': 'File', 'path': f'{_UPLOAD_PREFIX}doc.pdf'}]
|
|
|
|
with pytest.raises(RuntimeError, match='storage down'):
|
|
await adapter._process_image_components(_make_connection(), chain)
|
|
assert 'base64' not in chain[0]
|
|
adapter.logger.error.assert_awaited_once()
|