mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-08 20:30:59 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
181 lines
6.4 KiB
Python
181 lines
6.4 KiB
Python
"""Tests for Telegram Dify form callback helpers."""
|
|
|
|
import json
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
from telegram import ForceReply
|
|
|
|
import langbot_plugin.api.entities.builtin.platform.entities as platform_entities
|
|
import langbot_plugin.api.entities.builtin.platform.events as platform_events
|
|
import langbot_plugin.api.entities.builtin.platform.message as platform_message
|
|
from langbot.pkg.platform.sources.telegram import (
|
|
TelegramAdapter,
|
|
_decode_telegram_base64_limited,
|
|
_telegram_form_action_from_callback,
|
|
_telegram_select_field_options,
|
|
)
|
|
|
|
|
|
def test_telegram_base64_decode_is_bounded(monkeypatch):
|
|
import langbot.pkg.platform.sources.telegram as telegram_module
|
|
|
|
monkeypatch.setattr(telegram_module, '_MAX_TELEGRAM_MEDIA_BYTES', 4)
|
|
|
|
with pytest.raises(ValueError, match='exceeds'):
|
|
_decode_telegram_base64_limited('A' * 12)
|
|
|
|
|
|
def _select_form_data() -> dict:
|
|
return {
|
|
'_current_input_field': 'choice',
|
|
'input_defs': [
|
|
{
|
|
'output_variable_name': 'choice',
|
|
'type': 'select',
|
|
'option_source': {'type': 'constant', 'value': ['A', 'B', 'C']},
|
|
}
|
|
],
|
|
}
|
|
|
|
|
|
def test_telegram_select_field_options_are_extracted():
|
|
assert _telegram_select_field_options(_select_form_data()) == ('choice', ['A', 'B', 'C'])
|
|
|
|
|
|
def test_telegram_select_callback_becomes_input_progress():
|
|
assert _telegram_form_action_from_callback({'f': 1, 'x': 1}) == {
|
|
'action_id': '',
|
|
'inputs': {'select': {'index': 1}},
|
|
'_input_progress': True,
|
|
}
|
|
|
|
|
|
def test_telegram_action_callback_remains_final_action():
|
|
assert _telegram_form_action_from_callback({'f': 1, 'a': 'approve'}) == {
|
|
'action_id': 'approve',
|
|
'inputs': {},
|
|
}
|
|
|
|
|
|
def test_telegram_invalid_select_callback_is_rejected():
|
|
assert _telegram_form_action_from_callback({'f': 1, 'x': -1}) is None
|
|
assert _telegram_form_action_from_callback({'f': 1, 'x': 'invalid'}) is None
|
|
|
|
|
|
def test_telegram_form_callback_cache_consumes_the_whole_form_group():
|
|
adapter = TelegramAdapter.model_construct()
|
|
adapter._form_action_titles = {}
|
|
adapter._cache_form_action_titles({'callback-a': 'A', 'callback-b': 'B'}, now=100.0)
|
|
|
|
assert adapter._take_form_action_title('callback-a', now=101.0) == 'A'
|
|
assert adapter._take_form_action_title('callback-a', now=101.0) is None
|
|
assert adapter._take_form_action_title('callback-b', now=101.0) is None
|
|
assert adapter._form_action_titles == {}
|
|
|
|
|
|
def test_telegram_form_callback_cache_prunes_expired_entries():
|
|
adapter = TelegramAdapter.model_construct()
|
|
adapter._form_action_titles = {}
|
|
adapter._cache_form_action_titles({'callback-a': 'A'}, now=100.0)
|
|
|
|
assert adapter._take_form_action_title('callback-a', now=100.0 + adapter._FORM_ACTION_CACHE_TTL) is None
|
|
assert adapter._form_action_titles == {}
|
|
|
|
|
|
def test_telegram_form_callback_cache_preserves_pipeline_uuid():
|
|
adapter = TelegramAdapter.model_construct()
|
|
adapter._form_action_titles = {}
|
|
adapter._cache_form_action_titles(
|
|
{'callback-a': 'Approve'},
|
|
pipeline_uuid='pipeline-routed',
|
|
now=100.0,
|
|
)
|
|
|
|
assert adapter._take_form_action_context('callback-a', now=101.0) == (
|
|
'Approve',
|
|
'pipeline-routed',
|
|
)
|
|
|
|
|
|
def test_telegram_form_callback_cache_is_bounded():
|
|
adapter = TelegramAdapter.model_construct()
|
|
adapter._form_action_titles = {}
|
|
|
|
adapter._cache_form_action_titles(
|
|
{f'callback-{index}': str(index) for index in range(5000)},
|
|
now=100.0,
|
|
)
|
|
|
|
assert len(adapter._form_action_titles) == adapter._MAX_FORM_ACTION_TITLES
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_telegram_select_field_sends_two_column_inline_keyboard():
|
|
bot = MagicMock()
|
|
bot.send_message = AsyncMock()
|
|
adapter = TelegramAdapter.model_construct(bot=bot, config={}, msg_stream_id={}, seq=1, listeners={})
|
|
adapter._form_action_titles = {}
|
|
|
|
update = MagicMock()
|
|
update.effective_chat.id = 123
|
|
update.effective_message.message_thread_id = None
|
|
event = platform_events.FriendMessage(
|
|
sender=platform_entities.Friend(id='user-1', nickname='', remark=''),
|
|
message_chain=platform_message.MessageChain([]),
|
|
source_platform_object=update,
|
|
)
|
|
form_data = {
|
|
**_select_form_data(),
|
|
'node_title': 'Review',
|
|
'form_content': 'Choose one',
|
|
'workflow_run_id': 'workflow-run-12345678',
|
|
'actions': [{'id': 'approve', 'title': 'Approve'}],
|
|
}
|
|
|
|
await adapter._send_form_action_buttons(event, form_data)
|
|
|
|
args = bot.send_message.await_args.kwargs
|
|
rows = args['reply_markup'].inline_keyboard
|
|
assert [[button.text for button in row] for row in rows] == [['A', 'B'], ['C']]
|
|
callback_data = rows[0][1].callback_data
|
|
assert len(callback_data.encode('utf-8')) <= 64
|
|
assert json.loads(callback_data)['x'] == 1
|
|
assert callback_data in adapter._form_action_titles
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_telegram_text_field_does_not_show_action_buttons():
|
|
bot = MagicMock()
|
|
bot.send_message = AsyncMock()
|
|
adapter = TelegramAdapter.model_construct(bot=bot, config={}, msg_stream_id={}, seq=1, listeners={})
|
|
adapter._form_action_titles = {}
|
|
|
|
update = MagicMock()
|
|
update.effective_chat.id = 123
|
|
update.effective_message.message_thread_id = None
|
|
event = platform_events.FriendMessage(
|
|
sender=platform_entities.Friend(id='user-1', nickname='', remark=''),
|
|
message_chain=platform_message.MessageChain([]),
|
|
source_platform_object=update,
|
|
)
|
|
form_data = {
|
|
'_current_input_field': 'us_input',
|
|
'input_defs': [{'output_variable_name': 'us_input', 'type': 'paragraph'}],
|
|
'node_title': '人工介入',
|
|
'form_content': 'us_input (paragraph): reply "us_input: <value>"',
|
|
'workflow_run_id': 'workflow-run-12345678',
|
|
'actions': [{'id': 'yes', 'title': 'yes'}, {'id': 'no', 'title': 'no'}],
|
|
}
|
|
|
|
await adapter._send_form_action_buttons(event, form_data)
|
|
|
|
args = bot.send_message.await_args.kwargs
|
|
assert isinstance(args['reply_markup'], ForceReply)
|
|
assert args['reply_markup'].selective is False
|
|
assert args['reply_markup'].input_field_placeholder == 'us_input'
|
|
assert 'Please reply' not in args['text']
|
|
assert args['text'].startswith('[人工介入]')
|
|
assert 'us_input (paragraph)' in args['text']
|
|
assert adapter._form_action_titles == {}
|