mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-08 04:10:59 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
374 lines
12 KiB
Python
374 lines
12 KiB
Python
"""Integration tests for LangBot Box.
|
|
|
|
These tests verify the end-to-end behavior of the Box sandbox execution
|
|
system. Tests decorated with ``requires_container`` need a real container
|
|
runtime (Podman or Docker) and are skipped otherwise.
|
|
|
|
CI only runs ``tests/unit_tests/``, so these tests never execute in the
|
|
CI pipeline. Run them locally with::
|
|
|
|
pytest tests/integration_tests/ -v
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import logging
|
|
import shutil
|
|
import socket
|
|
import subprocess
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock
|
|
|
|
import pytest
|
|
|
|
from langbot.pkg.box.service import BoxService
|
|
from langbot_plugin.box.backend import BaseSandboxBackend
|
|
from langbot_plugin.box.client import ActionRPCBoxClient
|
|
from langbot_plugin.box.errors import BoxBackendUnavailableError
|
|
from langbot_plugin.box.models import BoxExecutionStatus, BoxNetworkMode, BoxSpec
|
|
from langbot_plugin.box.runtime import BoxRuntime
|
|
from langbot_plugin.box.server import BoxGenerationFence, BoxServerHandler
|
|
from langbot_plugin.entities.io.context import ActionContext
|
|
|
|
import langbot_plugin.api.entities.builtin.pipeline.query as pipeline_query
|
|
|
|
_logger = logging.getLogger('test.box.integration')
|
|
|
|
# Default image for integration tests — small and fast to pull.
|
|
_TEST_IMAGE = 'alpine:latest'
|
|
_ACTION_CONTEXT = ActionContext(
|
|
instance_uuid='box-integration-instance',
|
|
workspace_uuid='box-integration-workspace',
|
|
placement_generation=1,
|
|
)
|
|
|
|
|
|
# ── Skip helpers ──────────────────────────────────────────────────────
|
|
|
|
|
|
def _has_container_runtime() -> bool:
|
|
for cmd in ('podman', 'docker'):
|
|
if shutil.which(cmd) is None:
|
|
continue
|
|
try:
|
|
result = subprocess.run(
|
|
[cmd, 'info'],
|
|
capture_output=True,
|
|
timeout=10,
|
|
)
|
|
if result.returncode == 0:
|
|
return True
|
|
except Exception:
|
|
continue
|
|
return False
|
|
|
|
|
|
def _can_open_test_socket() -> bool:
|
|
try:
|
|
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
|
|
except OSError:
|
|
return False
|
|
sock.close()
|
|
return True
|
|
|
|
|
|
requires_container = pytest.mark.skipif(
|
|
not _has_container_runtime(),
|
|
reason='no container runtime (podman/docker) available',
|
|
)
|
|
|
|
requires_socket = pytest.mark.skipif(
|
|
not _can_open_test_socket(),
|
|
reason='local test environment does not permit opening TCP sockets',
|
|
)
|
|
|
|
|
|
# ── Helpers ──────────────────────────────────────────────────────────
|
|
|
|
|
|
class _QueueConnection:
|
|
"""In-process Connection backed by asyncio Queues — no real IO."""
|
|
|
|
def __init__(self, rx: asyncio.Queue[str], tx: asyncio.Queue[str]):
|
|
self._rx = rx
|
|
self._tx = tx
|
|
|
|
async def send(self, message: str) -> None:
|
|
await self._tx.put(message)
|
|
|
|
async def receive(self) -> str:
|
|
return await self._rx.get()
|
|
|
|
async def close(self) -> None:
|
|
pass
|
|
|
|
|
|
class _TenantBoxClient(ActionRPCBoxClient):
|
|
async def _call(
|
|
self,
|
|
action,
|
|
data,
|
|
timeout=15.0,
|
|
action_context=None,
|
|
):
|
|
return await super()._call(
|
|
action,
|
|
data,
|
|
timeout=timeout,
|
|
action_context=action_context or _ACTION_CONTEXT,
|
|
)
|
|
|
|
|
|
async def _make_rpc_pair(runtime: BoxRuntime):
|
|
"""Create an in-process (ActionRPCBoxClient, server_task, client_task) connected via queues."""
|
|
from langbot_plugin.runtime.io.handler import Handler
|
|
|
|
c2s: asyncio.Queue[str] = asyncio.Queue()
|
|
s2c: asyncio.Queue[str] = asyncio.Queue()
|
|
client_conn = _QueueConnection(rx=s2c, tx=c2s)
|
|
server_conn = _QueueConnection(rx=c2s, tx=s2c)
|
|
|
|
server_handler = BoxServerHandler(
|
|
server_conn,
|
|
runtime,
|
|
host_control_authenticated=True,
|
|
trusted_instance_uuid=_ACTION_CONTEXT.instance_uuid,
|
|
generation_fence=BoxGenerationFence(),
|
|
)
|
|
server_task = asyncio.create_task(server_handler.run())
|
|
|
|
client_handler = Handler.__new__(Handler)
|
|
Handler.__init__(client_handler, client_conn)
|
|
client_task = asyncio.create_task(client_handler.run())
|
|
|
|
client = _TenantBoxClient(logger=_logger)
|
|
client.set_handler(client_handler)
|
|
|
|
return client, server_task, client_task
|
|
|
|
|
|
# ── Fixtures ──────────────────────────────────────────────────────────
|
|
|
|
|
|
@pytest.fixture
|
|
async def box_client():
|
|
"""Yield an ActionRPCBoxClient backed by a real BoxRuntime via in-process RPC."""
|
|
runtime = BoxRuntime(logger=_logger)
|
|
await runtime.initialize()
|
|
client, server_task, client_task = await _make_rpc_pair(runtime)
|
|
yield client
|
|
server_task.cancel()
|
|
client_task.cancel()
|
|
await runtime.shutdown()
|
|
|
|
|
|
# ── 1. Simple command execution ───────────────────────────────────────
|
|
|
|
|
|
@requires_container
|
|
@requires_socket
|
|
@pytest.mark.asyncio
|
|
async def test_exec_simple_command(box_client: ActionRPCBoxClient):
|
|
"""Box starts a simple command and returns stdout."""
|
|
spec = BoxSpec(
|
|
cmd='echo hello-box',
|
|
session_id='int-simple',
|
|
workdir='/tmp',
|
|
image=_TEST_IMAGE,
|
|
)
|
|
result = await box_client.execute(spec)
|
|
|
|
assert result.status == BoxExecutionStatus.COMPLETED
|
|
assert result.exit_code == 0
|
|
assert 'hello-box' in result.stdout
|
|
|
|
|
|
# ── 2. Session file persistence ───────────────────────────────────────
|
|
|
|
|
|
@requires_container
|
|
@requires_socket
|
|
@pytest.mark.asyncio
|
|
async def test_session_persists_files(box_client: ActionRPCBoxClient):
|
|
"""Write a file in one exec, read it back in a second exec on the same session."""
|
|
sid = 'int-persist'
|
|
|
|
write_result = await box_client.execute(
|
|
BoxSpec(
|
|
cmd='echo "hello from file" > /tmp/testfile.txt',
|
|
session_id=sid,
|
|
workdir='/tmp',
|
|
image=_TEST_IMAGE,
|
|
)
|
|
)
|
|
assert write_result.exit_code == 0
|
|
|
|
read_result = await box_client.execute(
|
|
BoxSpec(
|
|
cmd='cat /tmp/testfile.txt',
|
|
session_id=sid,
|
|
workdir='/tmp',
|
|
image=_TEST_IMAGE,
|
|
)
|
|
)
|
|
assert read_result.exit_code == 0
|
|
assert 'hello from file' in read_result.stdout
|
|
|
|
|
|
# ── 3. Timeout handling ───────────────────────────────────────────────
|
|
|
|
|
|
@requires_container
|
|
@requires_socket
|
|
@pytest.mark.asyncio
|
|
async def test_timeout_kills_command(box_client: ActionRPCBoxClient):
|
|
"""A long-running command is killed after timeout_sec."""
|
|
session_id = 'int-timeout'
|
|
spec = BoxSpec(
|
|
cmd='sleep 120',
|
|
session_id=session_id,
|
|
workdir='/tmp',
|
|
timeout_sec=3,
|
|
image=_TEST_IMAGE,
|
|
)
|
|
result = await box_client.execute(spec)
|
|
|
|
assert result.status == BoxExecutionStatus.TIMED_OUT
|
|
assert result.exit_code is None
|
|
|
|
sessions = await box_client.get_sessions()
|
|
assert all(session['session_id'] != session_id for session in sessions)
|
|
|
|
|
|
# ── 4. Network isolation ─────────────────────────────────────────────
|
|
|
|
|
|
@requires_container
|
|
@requires_socket
|
|
@pytest.mark.asyncio
|
|
async def test_offline_cannot_reach_network(box_client: ActionRPCBoxClient):
|
|
"""With network=OFF the sandbox cannot reach the internet."""
|
|
spec = BoxSpec(
|
|
cmd='wget -q -O /dev/null --timeout=3 http://1.1.1.1 2>&1; exit $?',
|
|
session_id='int-offline',
|
|
workdir='/tmp',
|
|
network=BoxNetworkMode.OFF,
|
|
image=_TEST_IMAGE,
|
|
)
|
|
result = await box_client.execute(spec)
|
|
|
|
assert result.exit_code != 0
|
|
|
|
|
|
# ── 5. Backend unavailable ───────────────────────────────────────────
|
|
|
|
|
|
class _UnavailableBackend(BaseSandboxBackend):
|
|
"""A backend that always reports itself as unavailable."""
|
|
|
|
name = 'unavailable'
|
|
|
|
def __init__(self):
|
|
super().__init__(logging.getLogger('test'))
|
|
|
|
async def is_available(self) -> bool:
|
|
return False
|
|
|
|
async def start_session(self, spec):
|
|
raise NotImplementedError
|
|
|
|
async def exec(self, session, spec):
|
|
raise NotImplementedError
|
|
|
|
async def stop_session(self, session):
|
|
pass
|
|
|
|
|
|
@requires_socket
|
|
@pytest.mark.asyncio
|
|
async def test_backend_unavailable_returns_error():
|
|
"""When no backend is available the full RPC path returns BoxBackendUnavailableError."""
|
|
runtime = BoxRuntime(logger=_logger, backends=[_UnavailableBackend()])
|
|
await runtime.initialize()
|
|
client, server_task, client_task = await _make_rpc_pair(runtime)
|
|
try:
|
|
spec = BoxSpec(
|
|
cmd='echo hello',
|
|
session_id='int-no-backend',
|
|
workdir='/tmp',
|
|
)
|
|
with pytest.raises(BoxBackendUnavailableError):
|
|
await client.execute(spec)
|
|
finally:
|
|
server_task.cancel()
|
|
client_task.cancel()
|
|
await runtime.shutdown()
|
|
|
|
|
|
# ── 6. Full service-to-runtime path ──────────────────────────────────
|
|
|
|
|
|
@requires_container
|
|
@requires_socket
|
|
@pytest.mark.asyncio
|
|
async def test_full_service_to_remote_runtime(tmp_path):
|
|
"""BoxService -> ActionRPCBoxClient -> RPC -> BoxRuntime -> real backend."""
|
|
runtime = BoxRuntime(logger=_logger)
|
|
await runtime.initialize()
|
|
client, server_task, client_task = await _make_rpc_pair(runtime)
|
|
try:
|
|
host_dir = tmp_path / 'workspace'
|
|
host_dir.mkdir()
|
|
|
|
mock_ap = SimpleNamespace(
|
|
logger=_logger,
|
|
workspace_service=SimpleNamespace(
|
|
instance_uuid=_ACTION_CONTEXT.instance_uuid,
|
|
get_execution_binding=AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
instance_uuid=_ACTION_CONTEXT.instance_uuid,
|
|
workspace_uuid=_ACTION_CONTEXT.workspace_uuid,
|
|
placement_generation=_ACTION_CONTEXT.placement_generation,
|
|
)
|
|
),
|
|
),
|
|
instance_config=SimpleNamespace(
|
|
data={
|
|
'box': {
|
|
'backend': 'local',
|
|
'runtime': {'endpoint': ''},
|
|
'local': {
|
|
'profile': 'default',
|
|
'allowed_mount_roots': [str(tmp_path)],
|
|
'default_workspace': str(host_dir),
|
|
},
|
|
'e2b': {'api_key': '', 'api_url': '', 'template': ''},
|
|
}
|
|
}
|
|
),
|
|
)
|
|
|
|
service = BoxService(mock_ap, client=client)
|
|
await service.initialize()
|
|
|
|
query = pipeline_query.Query.model_construct(
|
|
query_id=42,
|
|
instance_uuid=_ACTION_CONTEXT.instance_uuid,
|
|
workspace_uuid=_ACTION_CONTEXT.workspace_uuid,
|
|
placement_generation=_ACTION_CONTEXT.placement_generation,
|
|
)
|
|
result = await service.execute_tool(
|
|
{'command': 'echo service-path'},
|
|
query,
|
|
)
|
|
|
|
assert result['ok'] is True
|
|
assert result['status'] == 'completed'
|
|
assert 'service-path' in result['stdout']
|
|
assert result['session_id'] == 'query_42'
|
|
finally:
|
|
server_task.cancel()
|
|
client_task.cancel()
|
|
await runtime.shutdown()
|