mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-05 02:56:06 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
143 lines
5.9 KiB
Python
143 lines
5.9 KiB
Python
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock
|
|
|
|
import pytest
|
|
import quart
|
|
import sqlalchemy
|
|
from sqlalchemy.ext.asyncio import create_async_engine
|
|
|
|
from langbot.pkg.api.http.controller.groups.extensions import ExtensionsRouterGroup
|
|
from langbot.pkg.persistence.mgr import PersistenceManager
|
|
from langbot.pkg.workspace.errors import WorkspaceNotFoundError
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_extensions_route_hides_runtime_bound_to_another_workspace():
|
|
account = SimpleNamespace(uuid='account-a', user='owner@example.com')
|
|
connector = SimpleNamespace(
|
|
is_enable_plugin=True,
|
|
require_workspace_context=AsyncMock(side_effect=WorkspaceNotFoundError('Plugin resource not found')),
|
|
list_plugins=AsyncMock(return_value=[]),
|
|
)
|
|
ap = SimpleNamespace(
|
|
user_service=SimpleNamespace(
|
|
get_authenticated_account=AsyncMock(return_value=account),
|
|
),
|
|
workspace_collaboration_service=SimpleNamespace(
|
|
resolve_account_workspace=AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
workspace=SimpleNamespace(uuid='workspace-a'),
|
|
membership=SimpleNamespace(uuid='membership-a', role='owner', projection_revision=0),
|
|
execution=SimpleNamespace(instance_uuid='instance-a', placement_generation=2),
|
|
)
|
|
)
|
|
),
|
|
plugin_connector=connector,
|
|
mcp_service=SimpleNamespace(get_mcp_servers=AsyncMock(return_value=[])),
|
|
skill_service=SimpleNamespace(list_skills=AsyncMock(return_value=[])),
|
|
)
|
|
quart_app = quart.Quart(__name__)
|
|
router = ExtensionsRouterGroup(ap, quart_app)
|
|
await router.initialize()
|
|
|
|
response = await quart_app.test_client().get(
|
|
'/api/v1/extensions',
|
|
headers={'Authorization': 'Bearer token'},
|
|
)
|
|
|
|
assert response.status_code == 404
|
|
connector.list_plugins.assert_not_awaited()
|
|
ap.mcp_service.get_mcp_servers.assert_not_awaited()
|
|
ap.skill_service.list_skills.assert_not_awaited()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_extensions_route_redacts_plugin_secrets_without_mutating_runtime_data():
|
|
account = SimpleNamespace(uuid='account-a', user='viewer@example.com')
|
|
raw_plugin = {
|
|
'plugin_config': {'apiKey': 'plugin-secret', 'nested': {'token': 'nested-secret'}},
|
|
'debug': {'plugin_debug_key': 'debug-secret'},
|
|
}
|
|
connector = SimpleNamespace(
|
|
is_enable_plugin=True,
|
|
require_workspace_context=AsyncMock(),
|
|
list_plugins=AsyncMock(return_value=[raw_plugin]),
|
|
)
|
|
ap = SimpleNamespace(
|
|
user_service=SimpleNamespace(get_authenticated_account=AsyncMock(return_value=account)),
|
|
workspace_collaboration_service=SimpleNamespace(
|
|
resolve_account_workspace=AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
workspace=SimpleNamespace(uuid='workspace-a'),
|
|
membership=SimpleNamespace(uuid='membership-a', role='viewer', projection_revision=0),
|
|
execution=SimpleNamespace(instance_uuid='instance-a', placement_generation=2),
|
|
)
|
|
)
|
|
),
|
|
plugin_connector=connector,
|
|
mcp_service=SimpleNamespace(get_mcp_servers=AsyncMock(return_value=[])),
|
|
skill_service=SimpleNamespace(list_skills=AsyncMock(return_value=[])),
|
|
)
|
|
quart_app = quart.Quart(__name__)
|
|
router = ExtensionsRouterGroup(ap, quart_app)
|
|
await router.initialize()
|
|
|
|
response = await quart_app.test_client().get(
|
|
'/api/v1/extensions',
|
|
headers={'Authorization': 'Bearer token', 'X-Workspace-Id': 'workspace-a'},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
plugin = (await response.get_json())['data']['extensions'][0]['plugin']
|
|
assert plugin['plugin_config']['apiKey'] == '***'
|
|
assert plugin['plugin_config']['nested']['token'] == '***'
|
|
assert plugin['debug']['plugin_debug_key'] == '***'
|
|
assert raw_plugin['plugin_config']['apiKey'] == 'plugin-secret'
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_extensions_parallel_reads_open_explicit_child_task_scopes():
|
|
engine = create_async_engine('sqlite+aiosqlite:///:memory:')
|
|
account = SimpleNamespace(uuid='account-a', user='owner@example.com')
|
|
ap = SimpleNamespace()
|
|
ap.persistence_mgr = PersistenceManager(ap)
|
|
ap.persistence_mgr.db = SimpleNamespace(get_engine=lambda: engine)
|
|
ap.user_service = SimpleNamespace(get_authenticated_account=AsyncMock(return_value=account))
|
|
ap.workspace_collaboration_service = SimpleNamespace(
|
|
resolve_account_workspace=AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
workspace=SimpleNamespace(uuid='workspace-a'),
|
|
membership=SimpleNamespace(uuid='membership-a', role='owner', projection_revision=0),
|
|
execution=SimpleNamespace(instance_uuid='instance-a', placement_generation=2),
|
|
)
|
|
)
|
|
)
|
|
ap.plugin_connector = SimpleNamespace(
|
|
is_enable_plugin=False,
|
|
list_plugins=AsyncMock(return_value=[]),
|
|
)
|
|
|
|
async def list_mcp_servers(_context, *, contain_runtime_info):
|
|
await ap.persistence_mgr.execute_async(sqlalchemy.select(sqlalchemy.literal(1)))
|
|
assert contain_runtime_info is True
|
|
return [{'name': 'Scoped MCP'}]
|
|
|
|
ap.mcp_service = SimpleNamespace(get_mcp_servers=AsyncMock(side_effect=list_mcp_servers))
|
|
ap.skill_service = SimpleNamespace(list_skills=AsyncMock(return_value=[]))
|
|
quart_app = quart.Quart(__name__)
|
|
router = ExtensionsRouterGroup(ap, quart_app)
|
|
await router.initialize()
|
|
|
|
try:
|
|
response = await quart_app.test_client().get(
|
|
'/api/v1/extensions',
|
|
headers={'Authorization': 'Bearer token', 'X-Workspace-Id': 'workspace-a'},
|
|
)
|
|
finally:
|
|
await engine.dispose()
|
|
|
|
assert response.status_code == 200
|
|
assert (await response.get_json())['data']['extensions'] == [{'type': 'mcp', 'server': {'name': 'Scoped MCP'}}]
|